Re: [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-21 Thread Hong jinkun
在 2014/10/21 5:31, Kevin Hilman 写道: "jinkun.hong" writes: From: "jinkun.hong" Add power domain drivers based on generic power domain for Rockchip platform, and support RK3288. Signed-off-by: Jack Dai Signed-off-by: jinkun.hong [...] +static int rockchip_pmu_set_idle_request(struct

Re: [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-21 Thread Hong jinkun
在 2014/10/21 5:31, Kevin Hilman 写道: jinkun.hong jinkun.h...@rock-chips.com writes: From: jinkun.hong jinkun.h...@rock-chips.com Add power domain drivers based on generic power domain for Rockchip platform, and support RK3288. Signed-off-by: Jack Dai jack@rock-chips.com Signed-off-by:

Re: [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-20 Thread Russell King - ARM Linux
On Mon, Oct 20, 2014 at 02:31:17PM -0700, Kevin Hilman wrote: > "jinkun.hong" writes: > > + spin_lock_irqsave(>idle_lock, flags); > > + val = (idle) ? mask : 0; > > + regmap_update_bits(pd->regmap_pmu, REQ_OFFSET, mask, val); > > + dsb(); > > A summary of the locking and barriers here

Re: [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-20 Thread Kevin Hilman
"jinkun.hong" writes: > From: "jinkun.hong" > > Add power domain drivers based on generic power domain for Rockchip platform, > and support RK3288. > > Signed-off-by: Jack Dai > Signed-off-by: jinkun.hong [...] > +static int rockchip_pmu_set_idle_request(struct rockchip_domain *pd, > +

Re: [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-20 Thread Varka Bhadram
On 10/20/2014 02:33 PM, jinkun.hong wrote: From: "jinkun.hong" Add power domain drivers based on generic power domain for Rockchip platform, and support RK3288. Signed-off-by: Jack Dai Signed-off-by: jinkun.hong --- (...) +static int rockchip_pd_power(struct rockchip_domain *pd, bool

[PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-20 Thread jinkun.hong
From: "jinkun.hong" Add power domain drivers based on generic power domain for Rockchip platform, and support RK3288. Signed-off-by: Jack Dai Signed-off-by: jinkun.hong --- Changes in v4: - use list storage dev Changes in v3: - change use pm_clk_resume() and pm_clk_suspend() Changes in

[PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-20 Thread jinkun.hong
From: jinkun.hong jinkun.h...@rock-chips.com Add power domain drivers based on generic power domain for Rockchip platform, and support RK3288. Signed-off-by: Jack Dai jack@rock-chips.com Signed-off-by: jinkun.hong jinkun.h...@rock-chips.com --- Changes in v4: - use list storage dev

Re: [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-20 Thread Varka Bhadram
On 10/20/2014 02:33 PM, jinkun.hong wrote: From: jinkun.hong jinkun.h...@rock-chips.com Add power domain drivers based on generic power domain for Rockchip platform, and support RK3288. Signed-off-by: Jack Dai jack@rock-chips.com Signed-off-by: jinkun.hong jinkun.h...@rock-chips.com ---

Re: [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-20 Thread Kevin Hilman
jinkun.hong jinkun.h...@rock-chips.com writes: From: jinkun.hong jinkun.h...@rock-chips.com Add power domain drivers based on generic power domain for Rockchip platform, and support RK3288. Signed-off-by: Jack Dai jack@rock-chips.com Signed-off-by: jinkun.hong

Re: [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-20 Thread Russell King - ARM Linux
On Mon, Oct 20, 2014 at 02:31:17PM -0700, Kevin Hilman wrote: jinkun.hong jinkun.h...@rock-chips.com writes: + spin_lock_irqsave(pd-idle_lock, flags); + val = (idle) ? mask : 0; + regmap_update_bits(pd-regmap_pmu, REQ_OFFSET, mask, val); + dsb(); A summary of the locking and