Re: [PATCH v4 1/4] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume

2013-08-22 Thread Doug Anderson
Seungwon, On Wed, Aug 21, 2013 at 5:54 PM, Doug Anderson wrote: >> Doug, your analysis is right. >> But, let me suggest another approach. >> After step #1, core layer actually call mmc_power_off because slot is >> empthy(get_cd() is '0'). >> Then, set_ios is requested with 'ios->clock'. >> Howev

Re: [PATCH v4 1/4] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume

2013-08-21 Thread Doug Anderson
Seungwon, On Mon, Aug 12, 2013 at 12:14 AM, Seungwon Jeon wrote: > On Sat, August 10, 2013, Doug Anderson wrote: >> Seungwon and Jaehoon, >> >> On Fri, Aug 9, 2013 at 6:32 AM, Seungwon Jeon wrote: >> > On Wed, August 07, 2013, Doug Anderson wrote: >> >> The dw_mmc driver keeps a cache of the cur

RE: [PATCH v4 1/4] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume

2013-08-12 Thread Seungwon Jeon
On Sat, August 10, 2013, Doug Anderson wrote: > Seungwon and Jaehoon, > > On Fri, Aug 9, 2013 at 6:32 AM, Seungwon Jeon wrote: > > On Wed, August 07, 2013, Doug Anderson wrote: > >> The dw_mmc driver keeps a cache of the current slot->clock in order to > >> avoid doing a whole lot of work every t

Re: [PATCH v4 1/4] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume

2013-08-09 Thread Doug Anderson
Seungwon and Jaehoon, On Fri, Aug 9, 2013 at 6:32 AM, Seungwon Jeon wrote: > On Wed, August 07, 2013, Doug Anderson wrote: >> The dw_mmc driver keeps a cache of the current slot->clock in order to >> avoid doing a whole lot of work every time set_ios() is called. >> However, after suspend/resume

RE: [PATCH v4 1/4] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume

2013-08-09 Thread Seungwon Jeon
On Wed, August 07, 2013, Doug Anderson wrote: > The dw_mmc driver keeps a cache of the current slot->clock in order to > avoid doing a whole lot of work every time set_ios() is called. > However, after suspend/resume the register values are bogus so we need > to ensure that the cached value is inva

Re: [PATCH v4 1/4] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume

2013-08-07 Thread Jaehoon Chung
Hi Doung On 08/07/2013 06:37 AM, Doug Anderson wrote: > The dw_mmc driver keeps a cache of the current slot->clock in order to > avoid doing a whole lot of work every time set_ios() is called. > However, after suspend/resume the register values are bogus so we need > to ensure that the cached valu

Re: [PATCH v4 1/4] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume

2013-08-06 Thread Tomasz Figa
On Tuesday 06 of August 2013 14:37:48 Doug Anderson wrote: > The dw_mmc driver keeps a cache of the current slot->clock in order to > avoid doing a whole lot of work every time set_ios() is called. > However, after suspend/resume the register values are bogus so we need > to ensure that the cached

[PATCH v4 1/4] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume

2013-08-06 Thread Doug Anderson
The dw_mmc driver keeps a cache of the current slot->clock in order to avoid doing a whole lot of work every time set_ios() is called. However, after suspend/resume the register values are bogus so we need to ensure that the cached value is invalidated. In many cases we got by without this since t