Re: [PATCH v4 1/5] block: revert back to synchronous request_queue removal

2020-05-11 Thread Luis Chamberlain
On Sun, May 10, 2020 at 08:20:58AM +0200, Greg KH wrote: > On Sat, May 09, 2020 at 03:10:54AM +, Luis Chamberlain wrote: > > Commit dc9edc44de6c ("block: Fix a blk_exit_rl() regression") merged on > > v4.12 moved the work behind blk_release_queue() into a workqueue after a > > splat floated

Re: [PATCH v4 1/5] block: revert back to synchronous request_queue removal

2020-05-10 Thread Greg KH
On Sat, May 09, 2020 at 03:10:54AM +, Luis Chamberlain wrote: > Commit dc9edc44de6c ("block: Fix a blk_exit_rl() regression") merged on > v4.12 moved the work behind blk_release_queue() into a workqueue after a > splat floated around which indicated some work on blk_release_queue() > could

Re: [PATCH v4 1/5] block: revert back to synchronous request_queue removal

2020-05-09 Thread Bart Van Assche
On 2020-05-08 20:10, Luis Chamberlain wrote: > We revert back to synchronous request_queue removal because asynchronous > removal creates a regression with expected userspace interaction with > several drivers. An example is when removing the loopback driver, one > uses ioctls from userspace to do

[PATCH v4 1/5] block: revert back to synchronous request_queue removal

2020-05-08 Thread Luis Chamberlain
Commit dc9edc44de6c ("block: Fix a blk_exit_rl() regression") merged on v4.12 moved the work behind blk_release_queue() into a workqueue after a splat floated around which indicated some work on blk_release_queue() could sleep in blk_exit_rl(). This splat would be possible when a driver called