Re: [PATCH v4 1/7] pinctrl: qcom: Add msmgpio irqchip flags

[Maulik Shah]

Hi,

On 8/12/2020 1:02 AM, Stephen Boyd wrote:

Can the subject be more specific? "pinctrl: qcom: Set IRQCHIP_SET_TYPE_MASKED 
flag"?


Sure i can update subject in v5.

Thanks,
Maulik



Quoting Maulik Shah (2020-08-10 04:20:54)

Add irqchip specific flags for msmgpio irqchip to mask non wakeirqs
during suspend and mask before setting irq type.

Masking before changing type should make sure any spurious interrupt
is not detected during this operation.

Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy")
Acked-by: Linus Walleij 
Signed-off-by: Maulik Shah 
---


--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of 
Code Aurora Forum, hosted by The Linux Foundation

Re: [PATCH v4 1/7] pinctrl: qcom: Add msmgpio irqchip flags

[Doug Anderson]

Hi,

On Mon, Aug 10, 2020 at 4:21 AM Maulik Shah  wrote:
>
> Add irqchip specific flags for msmgpio irqchip to mask non wakeirqs
> during suspend and mask before setting irq type.
>
> Masking before changing type should make sure any spurious interrupt
> is not detected during this operation.
>
> Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy")
> Acked-by: Linus Walleij 
> Signed-off-by: Maulik Shah 
> ---
>  drivers/pinctrl/qcom/pinctrl-msm.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c 
> b/drivers/pinctrl/qcom/pinctrl-msm.c
> index a2567e7..90edf61 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -1243,6 +1243,8 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
> pctrl->irq_chip.irq_release_resources = msm_gpio_irq_relres;
> pctrl->irq_chip.irq_set_affinity = msm_gpio_irq_set_affinity;
> pctrl->irq_chip.irq_set_vcpu_affinity = 
> msm_gpio_irq_set_vcpu_affinity;
> +   pctrl->irq_chip.flags = IRQCHIP_MASK_ON_SUSPEND
> +   | IRQCHIP_SET_TYPE_MASKED;
>
> np = of_parse_phandle(pctrl->dev->of_node, "wakeup-parent", 0);
> if (np) {

After taking Stephen's suggestion of improving the subject:

Reviewed-by: Douglas Anderson 

Re: [PATCH v4 1/7] pinctrl: qcom: Add msmgpio irqchip flags

[Stephen Boyd]

Can the subject be more specific? "pinctrl: qcom: Set IRQCHIP_SET_TYPE_MASKED 
flag"?

Quoting Maulik Shah (2020-08-10 04:20:54)
> Add irqchip specific flags for msmgpio irqchip to mask non wakeirqs
> during suspend and mask before setting irq type.
> 
> Masking before changing type should make sure any spurious interrupt
> is not detected during this operation.
> 
> Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy")
> Acked-by: Linus Walleij 
> Signed-off-by: Maulik Shah 
> ---

[PATCH v4 1/7] pinctrl: qcom: Add msmgpio irqchip flags

[Maulik Shah]

Add irqchip specific flags for msmgpio irqchip to mask non wakeirqs
during suspend and mask before setting irq type.

Masking before changing type should make sure any spurious interrupt
is not detected during this operation.

Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy")
Acked-by: Linus Walleij 
Signed-off-by: Maulik Shah 
---
 drivers/pinctrl/qcom/pinctrl-msm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c 
b/drivers/pinctrl/qcom/pinctrl-msm.c
index a2567e7..90edf61 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -1243,6 +1243,8 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
pctrl->irq_chip.irq_release_resources = msm_gpio_irq_relres;
pctrl->irq_chip.irq_set_affinity = msm_gpio_irq_set_affinity;
pctrl->irq_chip.irq_set_vcpu_affinity = msm_gpio_irq_set_vcpu_affinity;
+   pctrl->irq_chip.flags = IRQCHIP_MASK_ON_SUSPEND
+   | IRQCHIP_SET_TYPE_MASKED;
 
np = of_parse_phandle(pctrl->dev->of_node, "wakeup-parent", 0);
if (np) {
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation