Re: [PATCH v4 1/9] ASoC: dt-bindings: wcd938x: add bindings for wcd938x
On 15/04/2021 17:29, Rob Herring wrote:
+codec {
+compatible = "qcom,wcd9380-codec";
+reset-gpios = < 32 0>;
+#sound-dai-cells = <1>;
+qcom,tx-device = <_tx>;
+qcom,rx-device = <_rx>;
+qcom,micbias1-microvolt = <180>;
+qcom,micbias2-microvolt = <180>;
+qcom,micbias3-microvolt = <180>;
+qcom,micbias4-microvolt = <180>;
+qcom,mbhc-hphl-switch;
+qcom,mbhc-ground-switch;
+qcom,mbhc-button0-vthreshold-microvolt = <75000>;
+qcom,mbhc-button1-vthreshold-microvolt = <15>;
+qcom,mbhc-button2-vthreshold-microvolt = <237000>;
+qcom,mbhc-button3-vthreshold-microvolt = <50>;
+qcom,mbhc-button5-vthreshold-microvolt = <50>;
+qcom,mbhc-button6-vthreshold-microvolt = <50>;
+qcom,mbhc-button7-vthreshold-microvolt = <50>;
+};
+
+/* ... */
+
+soundwire@323 {
+#address-cells = <2>;
+#size-cells = <0>;
+reg = <0x0323 0x2000>;
+wcd938x_tx: codec@0,3 {
+compatible = "sdw20217010d00";
+reg = <0 3>;
+qcom,direction = "tx";
+qcom,port-mapping = <2 3 4 5>;
+};
+
+wcd938x_rx: codec@0,4 {
+compatible = "sdw20217010d00";
+reg = <0 4>;
+qcom,direction = "rx";
+qcom,port-mapping = <1 2 3 4 5>;
+};
This is a single device, right? We shouldn't need 3 nodes to describe
Just realized that the example is bit misleading here.
It should look like:
codec {
compatible = "qcom,wcd9380-codec";
reset-gpios = < 32 0>;
#sound-dai-cells = <1>;
qcom,tx-device = <_tx>;
qcom,rx-device = <_rx>;
qcom,micbias1-microvolt = <180>;
qcom,micbias2-microvolt = <180>;
qcom,micbias3-microvolt = <180>;
qcom,micbias4-microvolt = <180>;
qcom,mbhc-hphl-switch;
qcom,mbhc-ground-switch;
qcom,mbhc-button0-vthreshold-microvolt = <75000>;
qcom,mbhc-button1-vthreshold-microvolt = <15>;
qcom,mbhc-button2-vthreshold-microvolt = <237000>;
qcom,mbhc-button3-vthreshold-microvolt = <50>;
qcom,mbhc-button5-vthreshold-microvolt = <50>;
qcom,mbhc-button6-vthreshold-microvolt = <50>;
qcom,mbhc-button7-vthreshold-microvolt = <50>;
};
soundwire-controller@323 {
reg = <0 0x323 0 0x2000>;
compatible = "qcom,soundwire-v1.5.1";
wcd938x_tx: codec@0,3 {
compatible = "sdw20217010d00";
reg = <0 3>;
qcom,direction = "tx";
qcom,port-mapping = <2 3 4 5>;
};
};
soundwire-controller@321 {
reg = <0 0x321 0 0x2000>;
compatible = "qcom,soundwire-v1.5.1";
wcd938x_rx: codec@0,4 {
compatible = "sdw20217010d00";
reg = <0 4>;
qcom,direction = "rx";
qcom,port-mapping = <1 2 3 4 5>;
};
};
--srini
Re: [PATCH v4 1/9] ASoC: dt-bindings: wcd938x: add bindings for wcd938x
Thanks Rob for quick review,
On 15/04/2021 17:29, Rob Herring wrote:
On Wed, Apr 14, 2021 at 04:48:37PM +0100, Srinivas Kandagatla wrote:
Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC
connected over SoundWire. This device has two SoundWire device RX and
TX respectively, supporting 4 x ADCs, ClassH, Ear, Aux PA, 2xHPH,
7 x TX diff inputs, 8 DMICs, MBHC.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/sound/qcom,wcd938x.yaml | 176 ++
1 file changed, 176 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
new file mode 100644
index ..4c8fa8290af0
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
@@ -0,0 +1,176 @@
...
+additionalProperties: false
+
+examples:
+ - |
+codec {
+compatible = "qcom,wcd9380-codec";
+reset-gpios = < 32 0>;
+#sound-dai-cells = <1>;
+qcom,tx-device = <_tx>;
+qcom,rx-device = <_rx>;
+qcom,micbias1-microvolt = <180>;
+qcom,micbias2-microvolt = <180>;
+qcom,micbias3-microvolt = <180>;
+qcom,micbias4-microvolt = <180>;
+qcom,mbhc-hphl-switch;
+qcom,mbhc-ground-switch;
+qcom,mbhc-button0-vthreshold-microvolt = <75000>;
+qcom,mbhc-button1-vthreshold-microvolt = <15>;
+qcom,mbhc-button2-vthreshold-microvolt = <237000>;
+qcom,mbhc-button3-vthreshold-microvolt = <50>;
+qcom,mbhc-button5-vthreshold-microvolt = <50>;
+qcom,mbhc-button6-vthreshold-microvolt = <50>;
+qcom,mbhc-button7-vthreshold-microvolt = <50>;
+};
+
+/* ... */
+
+soundwire@323 {
+#address-cells = <2>;
+#size-cells = <0>;
+reg = <0x0323 0x2000>;
+wcd938x_tx: codec@0,3 {
+compatible = "sdw20217010d00";
+reg = <0 3>;
+qcom,direction = "tx";
+qcom,port-mapping = <2 3 4 5>;
+};
+
+wcd938x_rx: codec@0,4 {
+compatible = "sdw20217010d00";
+reg = <0 4>;
+qcom,direction = "rx";
+qcom,port-mapping = <1 2 3 4 5>;
+};
This is a single device, right? We shouldn't need 3 nodes to describe
it. I think this should all be a single node like this:
No, WCD938x is a Audio Codec which has two SoundWire Slave device (TX
and RX). WCD938X reset lines and supplies are common for both TX and RX
SoundWire devices.
However TX SoundWire device only has register access to codec
CSR(Control Status registers).
So there are two SoundWire devices and a WCD938X common parts. Now
making the common Codec part as a separate device made more sense here.
So we ended with total 3 devices.
1 . WCD938x Codec which deals with all the codec side including Common
parts.
2. TX SoundWire device to configure TX SoundWire ports/interface and
provide CSR access.
3. RX SoundWire device to configure RX Soundwire ports/interface
codec@0,3 {
reg = <0 3>, <0 4>;
We can't have this, as these two SoundWire devices hang on different
SoundWire bus instances.
compatible = "sdw20217010d00";
reset-gpios = < 32 0>;
#sound-dai-cells = <1>;
qcom,micbias1-microvolt = <180>;
qcom,micbias2-microvolt = <180>;
qcom,micbias3-microvolt = <180>;
qcom,micbias4-microvolt = <180>;
qcom,mbhc-hphl-switch;
qcom,mbhc-ground-switch;
qcom,mbhc-button0-vthreshold-microvolt = <75000>;
qcom,mbhc-button1-vthreshold-microvolt = <15>;
qcom,mbhc-button2-vthreshold-microvolt = <237000>;
qcom,mbhc-button3-vthreshold-microvolt = <50>;
qcom,mbhc-button5-vthreshold-microvolt = <50>;
qcom,mbhc-button6-vthreshold-microvolt = <50>;
qcom,mbhc-button7-vthreshold-microvolt = <50>;
};
You'll have to figure out the qcom,direction and qcom,port-mapping parts
though.
That is the reason why we ended up with 3 devices here.
--srini
Rob
Re: [PATCH v4 1/9] ASoC: dt-bindings: wcd938x: add bindings for wcd938x
On Wed, Apr 14, 2021 at 04:48:37PM +0100, Srinivas Kandagatla wrote:
> Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC
> connected over SoundWire. This device has two SoundWire device RX and
> TX respectively, supporting 4 x ADCs, ClassH, Ear, Aux PA, 2xHPH,
> 7 x TX diff inputs, 8 DMICs, MBHC.
>
> Signed-off-by: Srinivas Kandagatla
> ---
> .../bindings/sound/qcom,wcd938x.yaml | 176 ++
> 1 file changed, 176 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
> b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
> new file mode 100644
> index ..4c8fa8290af0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
> @@ -0,0 +1,176 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/qcom,wcd938x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Bindings for Qualcomm WCD9380/WCD9385 Audio Codec
> +
> +maintainers:
> + - Srinivas Kandagatla
> +
> +description: |
> + Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC.
> + It has RX and TX Soundwire slave devices.
> +
> +properties:
> + compatible:
> +enum:
> + - qcom,wcd9380-codec
> + - qcom,wcd9385-codec
> +
> + reset-gpios:
> +description: GPIO spec for reset line to use
> +maxItems: 1
> +
> + vdd-buck-supply:
> +description: A reference to the 1.8V buck supply
> +
> + vdd-rxtx-supply:
> +description: A reference to the 1.8V rx supply
> +
> + vdd-io-supply:
> +description: A reference to the 1.8V I/O supply
> +
> + qcom,tx-device:
> +$ref: /schemas/types.yaml#/definitions/phandle-array
> +maxItems: 1
> +description: A reference to Soundwire tx device phandle
> +
> + qcom,rx-device:
> +$ref: /schemas/types.yaml#/definitions/phandle-array
> +maxItems: 1
> +description: A reference to Soundwire rx device phandle
> +
> + qcom,micbias1-microvolt:
> +description: micbias1 voltage
> +minimum: 180
> +maximum: 285
> +
> + qcom,micbias2-microvolt:
> +description: micbias2 voltage
> +minimum: 180
> +maximum: 285
> +
> + qcom,micbias3-microvolt:
> +description: micbias3 voltage
> +minimum: 180
> +maximum: 285
> +
> + qcom,micbias4-microvolt:
> +description: micbias4 voltage
> +minimum: 180
> +maximum: 285
> +
> + qcom,mbhc-hphl-switch:
> +description: Indicates that HPHL switch type is normally closed
> +type: boolean
> +
> + qcom,mbhc-ground-switch:
> +description: Indicates that Headset Ground switch type is normally closed
> +type: boolean
> +
> + qcom,mbhc-button0-vthreshold-microvolt:
> +description: Voltage threshold value headset button0
> +minimum: 0
> +maximum: 50
> +
> + qcom,mbhc-button1-vthreshold-microvolt:
> +description: Voltage threshold value headset button1
> +minimum: 0
> +maximum: 50
> +
> + qcom,mbhc-button2-vthreshold-microvolt:
> +description: Voltage threshold value headset button2
> +minimum: 0
> +maximum: 50
> +
> + qcom,mbhc-button3-vthreshold-microvolt:
> +description: Voltage threshold value headset button3
> +minimum: 0
> +maximum: 50
> +
> + qcom,mbhc-button4-vthreshold-microvolt:
> +description: Voltage threshold value headset button4
> +minimum: 0
> +maximum: 50
> +
> + qcom,mbhc-button5-vthreshold-microvolt:
> +description: Voltage threshold value headset button5
> +minimum: 0
> +maximum: 50
> +
> + qcom,mbhc-button6-vthreshold-microvolt:
> +description: Voltage threshold value headset button6
> +minimum: 0
> +maximum: 50
> +
> + qcom,mbhc-button7-vthreshold-microvolt:
> +description: Voltage threshold value headset button7
> +minimum: 0
> +maximum: 50
> +
> + '#sound-dai-cells':
> +const: 1
> +
> +required:
> + - compatible
> + - reset-gpios
> + - qcom,tx-device
> + - qcom,rx-device
> + - qcom,micbias1-microvolt
> + - qcom,micbias2-microvolt
> + - qcom,micbias3-microvolt
> + - qcom,micbias4-microvolt
> + - qcom,mbhc-hphl-switch
> + - qcom,mbhc-ground-switch
> + - "#sound-dai-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> +codec {
> +compatible = "qcom,wcd9380-codec";
> +reset-gpios = < 32 0>;
> +#sound-dai-cells = <1>;
> +qcom,tx-device = <_tx>;
> +qcom,rx-device = <_rx>;
> +qcom,micbias1-microvolt = <180>;
> +qcom,micbias2-microvolt = <180>;
> +qcom,micbias3-microvolt = <180>;
> +qcom,micbias4-microvolt = <180>;
> +qcom,mbhc-hphl-switch;
> +qcom,mbhc-ground-switch;
> +qcom,mbhc-button0-vthreshold-microvolt = <75000>;
> +
[PATCH v4 1/9] ASoC: dt-bindings: wcd938x: add bindings for wcd938x
Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC
connected over SoundWire. This device has two SoundWire device RX and
TX respectively, supporting 4 x ADCs, ClassH, Ear, Aux PA, 2xHPH,
7 x TX diff inputs, 8 DMICs, MBHC.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/sound/qcom,wcd938x.yaml | 176 ++
1 file changed, 176 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
new file mode 100644
index ..4c8fa8290af0
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
@@ -0,0 +1,176 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/qcom,wcd938x.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Bindings for Qualcomm WCD9380/WCD9385 Audio Codec
+
+maintainers:
+ - Srinivas Kandagatla
+
+description: |
+ Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC.
+ It has RX and TX Soundwire slave devices.
+
+properties:
+ compatible:
+enum:
+ - qcom,wcd9380-codec
+ - qcom,wcd9385-codec
+
+ reset-gpios:
+description: GPIO spec for reset line to use
+maxItems: 1
+
+ vdd-buck-supply:
+description: A reference to the 1.8V buck supply
+
+ vdd-rxtx-supply:
+description: A reference to the 1.8V rx supply
+
+ vdd-io-supply:
+description: A reference to the 1.8V I/O supply
+
+ qcom,tx-device:
+$ref: /schemas/types.yaml#/definitions/phandle-array
+maxItems: 1
+description: A reference to Soundwire tx device phandle
+
+ qcom,rx-device:
+$ref: /schemas/types.yaml#/definitions/phandle-array
+maxItems: 1
+description: A reference to Soundwire rx device phandle
+
+ qcom,micbias1-microvolt:
+description: micbias1 voltage
+minimum: 180
+maximum: 285
+
+ qcom,micbias2-microvolt:
+description: micbias2 voltage
+minimum: 180
+maximum: 285
+
+ qcom,micbias3-microvolt:
+description: micbias3 voltage
+minimum: 180
+maximum: 285
+
+ qcom,micbias4-microvolt:
+description: micbias4 voltage
+minimum: 180
+maximum: 285
+
+ qcom,mbhc-hphl-switch:
+description: Indicates that HPHL switch type is normally closed
+type: boolean
+
+ qcom,mbhc-ground-switch:
+description: Indicates that Headset Ground switch type is normally closed
+type: boolean
+
+ qcom,mbhc-button0-vthreshold-microvolt:
+description: Voltage threshold value headset button0
+minimum: 0
+maximum: 50
+
+ qcom,mbhc-button1-vthreshold-microvolt:
+description: Voltage threshold value headset button1
+minimum: 0
+maximum: 50
+
+ qcom,mbhc-button2-vthreshold-microvolt:
+description: Voltage threshold value headset button2
+minimum: 0
+maximum: 50
+
+ qcom,mbhc-button3-vthreshold-microvolt:
+description: Voltage threshold value headset button3
+minimum: 0
+maximum: 50
+
+ qcom,mbhc-button4-vthreshold-microvolt:
+description: Voltage threshold value headset button4
+minimum: 0
+maximum: 50
+
+ qcom,mbhc-button5-vthreshold-microvolt:
+description: Voltage threshold value headset button5
+minimum: 0
+maximum: 50
+
+ qcom,mbhc-button6-vthreshold-microvolt:
+description: Voltage threshold value headset button6
+minimum: 0
+maximum: 50
+
+ qcom,mbhc-button7-vthreshold-microvolt:
+description: Voltage threshold value headset button7
+minimum: 0
+maximum: 50
+
+ '#sound-dai-cells':
+const: 1
+
+required:
+ - compatible
+ - reset-gpios
+ - qcom,tx-device
+ - qcom,rx-device
+ - qcom,micbias1-microvolt
+ - qcom,micbias2-microvolt
+ - qcom,micbias3-microvolt
+ - qcom,micbias4-microvolt
+ - qcom,mbhc-hphl-switch
+ - qcom,mbhc-ground-switch
+ - "#sound-dai-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+codec {
+compatible = "qcom,wcd9380-codec";
+reset-gpios = < 32 0>;
+#sound-dai-cells = <1>;
+qcom,tx-device = <_tx>;
+qcom,rx-device = <_rx>;
+qcom,micbias1-microvolt = <180>;
+qcom,micbias2-microvolt = <180>;
+qcom,micbias3-microvolt = <180>;
+qcom,micbias4-microvolt = <180>;
+qcom,mbhc-hphl-switch;
+qcom,mbhc-ground-switch;
+qcom,mbhc-button0-vthreshold-microvolt = <75000>;
+qcom,mbhc-button1-vthreshold-microvolt = <15>;
+qcom,mbhc-button2-vthreshold-microvolt = <237000>;
+qcom,mbhc-button3-vthreshold-microvolt = <50>;
+qcom,mbhc-button5-vthreshold-microvolt = <50>;
+qcom,mbhc-button6-vthreshold-microvolt = <50>;
+qcom,mbhc-button7-vthreshold-microvolt = <50>;
+};
+
+/* ... */
+
+soundwire@323 {
+
