Re: [PATCH v4 1/9] Makefile: Prepare for using macros for inline asm

2018-06-19 Thread Nadav Amit
at 5:40 PM, Masahiro Yamada wrote: > In the meanwhile, CFLAGS_REMOVE_ will do > as a workaround. Thanks! I appreciate your help. I will submit tomorrow an updated version. Regards, Nadav

Re: [PATCH v4 1/9] Makefile: Prepare for using macros for inline asm

2018-06-16 Thread Masahiro Yamada
2018-06-14 5:36 GMT+09:00 Sam Ravnborg : >> >> > +macros: $(obj)/macros.s >> > + @: >> >> If you add a phony target, it should be added to 'PHONY'. > > Or this part: >> +archmacros: >> + $(Q)$(MAKE) $(build)=arch/x86/kernel macros > > could be modified to specify the exact filename so t

Re: [PATCH v4 1/9] Makefile: Prepare for using macros for inline asm

2018-06-16 Thread Masahiro Yamada
Hi. 2018-06-14 7:19 GMT+09:00 Nadav Amit : >> >> >> I have not fully understood this series yet. >> >> I do not have enough skill in x86 architecture, >> but just some comments from the build system point of view. >> >> >> >> I guess this will probably break the parallel building. >> >> Kbuild can

Re: [PATCH v4 1/9] Makefile: Prepare for using macros for inline asm

2018-06-13 Thread Nadav Amit
Thanks for your comment! I am certainly Makefile-challenged, so your help is highly appreciated. Please see my responses/questions inline. at 10:43 AM, Masahiro Yamada wrote: > 2018-06-12 20:50 GMT+09:00 Nadav Amit : >> Using macros for inline assembly improves both readability and >> compilati

Re: [PATCH v4 1/9] Makefile: Prepare for using macros for inline asm

2018-06-13 Thread Sam Ravnborg
> > > +macros: $(obj)/macros.s > > + @: > > If you add a phony target, it should be added to 'PHONY'. Or this part: > +archmacros: > + $(Q)$(MAKE) $(build)=arch/x86/kernel macros could be modified to specify the exact filename so this indirection is not needed. PS. Only one file p

Re: [PATCH v4 1/9] Makefile: Prepare for using macros for inline asm

2018-06-13 Thread Masahiro Yamada
Hi. 2018-06-12 20:50 GMT+09:00 Nadav Amit : > Using macros for inline assembly improves both readability and > compilation decisions that are distorted by big assembly blocks that use > alternative sections. Compile macros.S and use it to assemble all C > files. Currently, only x86 will use it. >

[PATCH v4 1/9] Makefile: Prepare for using macros for inline asm

2018-06-12 Thread Nadav Amit
Using macros for inline assembly improves both readability and compilation decisions that are distorted by big assembly blocks that use alternative sections. Compile macros.S and use it to assemble all C files. Currently, only x86 will use it. Cc: Masahiro Yamada Cc: Michal Marek Cc: Thomas Glei