Re: [PATCH v4 10/10] cpufreq: intel_pstate: Use CPPC to get max performance

On Thu, 2016-09-22 at 22:58 +0200, Rafael J. Wysocki wrote: >  > > > so what if there are two CPU packages > > > and there are highest_perf differences in both, and we first enumerate > > > the first package entirely before getting to the second one? > > > > > > In that case we'll schedule the

Re: [PATCH v4 10/10] cpufreq: intel_pstate: Use CPPC to get max performance

On Thu, 2016-09-22 at 22:58 +0200, Rafael J. Wysocki wrote: >  > > > so what if there are two CPU packages > > > and there are highest_perf differences in both, and we first enumerate > > > the first package entirely before getting to the second one? > > > > > > In that case we'll schedule the

Re: [PATCH v4 10/10] cpufreq: intel_pstate: Use CPPC to get max performance

On Thu, Sep 22, 2016 at 8:50 PM, Tim Chen wrote: > On Wed, 2016-09-21 at 22:30 +0200, Rafael J. Wysocki wrote: >> On Wed, Sep 21, 2016 at 9:19 PM, Srinivas Pandruvada >> wrote: >> > >> > >> > + >> > +static void

Re: [PATCH v4 10/10] cpufreq: intel_pstate: Use CPPC to get max performance

On Thu, Sep 22, 2016 at 8:50 PM, Tim Chen wrote: > On Wed, 2016-09-21 at 22:30 +0200, Rafael J. Wysocki wrote: >> On Wed, Sep 21, 2016 at 9:19 PM, Srinivas Pandruvada >> wrote: >> > >> > >> > + >> > +static void intel_pstate_check_and_enable_itmt(int cpu) >> > +{ >> > + /* >> > +*

Re: [PATCH v4 10/10] cpufreq: intel_pstate: Use CPPC to get max performance

On Thu, 2016-09-22 at 20:56 +0200, Thomas Gleixner wrote: > On Thu, 22 Sep 2016, Tim Chen wrote: > > > > On Wed, 2016-09-21 at 22:30 +0200, Rafael J. Wysocki wrote: > > > > > > My current understanding is that we need to rebuild sched domains > > > after setting the priorities,  > > No, that's

Re: [PATCH v4 10/10] cpufreq: intel_pstate: Use CPPC to get max performance

On Thu, 2016-09-22 at 20:56 +0200, Thomas Gleixner wrote: > On Thu, 22 Sep 2016, Tim Chen wrote: > > > > On Wed, 2016-09-21 at 22:30 +0200, Rafael J. Wysocki wrote: > > > > > > My current understanding is that we need to rebuild sched domains > > > after setting the priorities,  > > No, that's

Re: [PATCH v4 10/10] cpufreq: intel_pstate: Use CPPC to get max performance

On Thu, 22 Sep 2016, Tim Chen wrote: > On Wed, 2016-09-21 at 22:30 +0200, Rafael J. Wysocki wrote: > > My current understanding is that we need to rebuild sched domains > > after setting the priorities, > > No, that's not true.  We need to rebuild the sched domains only > when the sched domain

Re: [PATCH v4 10/10] cpufreq: intel_pstate: Use CPPC to get max performance

On Thu, 22 Sep 2016, Tim Chen wrote: > On Wed, 2016-09-21 at 22:30 +0200, Rafael J. Wysocki wrote: > > My current understanding is that we need to rebuild sched domains > > after setting the priorities, > > No, that's not true.  We need to rebuild the sched domains only > when the sched domain

Re: [PATCH v4 10/10] cpufreq: intel_pstate: Use CPPC to get max performance

On Wed, 2016-09-21 at 22:30 +0200, Rafael J. Wysocki wrote: > On Wed, Sep 21, 2016 at 9:19 PM, Srinivas Pandruvada > wrote: > > > >  > > + > > +static void intel_pstate_check_and_enable_itmt(int cpu) > > +{ > > +   /* > > +* For checking whether

Re: [PATCH v4 10/10] cpufreq: intel_pstate: Use CPPC to get max performance

On Wed, 2016-09-21 at 22:30 +0200, Rafael J. Wysocki wrote: > On Wed, Sep 21, 2016 at 9:19 PM, Srinivas Pandruvada > wrote: > > > >  > > + > > +static void intel_pstate_check_and_enable_itmt(int cpu) > > +{ > > +   /* > > +* For checking whether there is any difference in the maximum

Re: [PATCH v4 10/10] cpufreq: intel_pstate: Use CPPC to get max performance

On Wed, Sep 21, 2016 at 9:19 PM, Srinivas Pandruvada wrote: > This change uses acpi cppc_lib interface to get CPPC performance limits. > Once CPPC limits of all online cores are read, first check if there is > difference in max performance. If there is a

Re: [PATCH v4 10/10] cpufreq: intel_pstate: Use CPPC to get max performance

On Wed, Sep 21, 2016 at 9:19 PM, Srinivas Pandruvada wrote: > This change uses acpi cppc_lib interface to get CPPC performance limits. > Once CPPC limits of all online cores are read, first check if there is > difference in max performance. If there is a difference, then the > scheduler interface

[PATCH v4 10/10] cpufreq: intel_pstate: Use CPPC to get max performance

This change uses acpi cppc_lib interface to get CPPC performance limits. Once CPPC limits of all online cores are read, first check if there is difference in max performance. If there is a difference, then the scheduler interface is called to update per cpu priority and enable ITMT feature. Here

[PATCH v4 10/10] cpufreq: intel_pstate: Use CPPC to get max performance

This change uses acpi cppc_lib interface to get CPPC performance limits. Once CPPC limits of all online cores are read, first check if there is difference in max performance. If there is a difference, then the scheduler interface is called to update per cpu priority and enable ITMT feature. Here