Re: [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK

2018-07-18 Thread Ard Biesheuvel
On 19 July 2018 at 00:33, Arnd Bergmann wrote: > On Wed, Jul 18, 2018 at 5:19 PM, Ard Biesheuvel > wrote: >> On 18 July 2018 at 23:50, Ard Biesheuvel wrote: >>> On 18 July 2018 at 05:59, Arnd Bergmann wrote: On Sun, Jul 15, 2018 at 6:28 AM, Kees Cook wrote: > > After my ahash to

Re: [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK

2018-07-18 Thread Ard Biesheuvel
On 19 July 2018 at 00:33, Arnd Bergmann wrote: > On Wed, Jul 18, 2018 at 5:19 PM, Ard Biesheuvel > wrote: >> On 18 July 2018 at 23:50, Ard Biesheuvel wrote: >>> On 18 July 2018 at 05:59, Arnd Bergmann wrote: On Sun, Jul 15, 2018 at 6:28 AM, Kees Cook wrote: > > After my ahash to

Re: [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK

2018-07-18 Thread Ard Biesheuvel
On 18 July 2018 at 05:59, Arnd Bergmann wrote: > On Sun, Jul 15, 2018 at 6:28 AM, Kees Cook wrote: >> >> After my ahash to shash conversions, only ccm is left as an ahash >> user, since it actually uses sg. But with the hard-coded value reduced >> to 376, this doesn't trip the frame warnings any

Re: [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK

2018-07-18 Thread Ard Biesheuvel
On 18 July 2018 at 05:59, Arnd Bergmann wrote: > On Sun, Jul 15, 2018 at 6:28 AM, Kees Cook wrote: >> >> After my ahash to shash conversions, only ccm is left as an ahash >> user, since it actually uses sg. But with the hard-coded value reduced >> to 376, this doesn't trip the frame warnings any

Re: [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK

2018-07-15 Thread Herbert Xu
On Sat, Jul 14, 2018 at 07:59:09PM -0700, Kees Cook wrote: > On Sat, Jul 14, 2018 at 7:44 PM, Herbert Xu > wrote: > > On Fri, Jul 13, 2018 at 08:07:10PM -0700, Kees Cook wrote: > >> > >> On a plane today I started converting all these to shash. IIUC, it > >> just looks like this (apologies for

Re: [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK

2018-07-15 Thread Herbert Xu
On Sat, Jul 14, 2018 at 07:59:09PM -0700, Kees Cook wrote: > On Sat, Jul 14, 2018 at 7:44 PM, Herbert Xu > wrote: > > On Fri, Jul 13, 2018 at 08:07:10PM -0700, Kees Cook wrote: > >> > >> On a plane today I started converting all these to shash. IIUC, it > >> just looks like this (apologies for

Re: [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK

2018-07-12 Thread Kees Cook
On Thu, Jul 12, 2018 at 9:02 AM, Arnd Bergmann wrote: > On Wed, Jul 11, 2018 at 10:36 PM, Kees Cook wrote: >> Several uses of AHASH_REQUEST_ON_STACK() will trigger FRAME_WARN warnings >> (when less than 2048) once the VLA is no longer hidden from the check: >> >>

Re: [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK

2018-07-12 Thread Kees Cook
On Thu, Jul 12, 2018 at 9:02 AM, Arnd Bergmann wrote: > On Wed, Jul 11, 2018 at 10:36 PM, Kees Cook wrote: >> Several uses of AHASH_REQUEST_ON_STACK() will trigger FRAME_WARN warnings >> (when less than 2048) once the VLA is no longer hidden from the check: >> >>