Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-09-16 Thread Lee Jones
On Wed, 16 Sep 2015, Viresh Kumar wrote: > On 10-09-15, 09:31, Lee Jones wrote: > > I think you answered your own question. > > > > No users == !ABI == Strip it out. > > Okay, as I have delayed things enough for you, didn't wanted to do > that anymore. And so worked on it despite very tight

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-09-15 Thread Viresh Kumar
On 10-09-15, 09:31, Lee Jones wrote: > I think you answered your own question. > > No users == !ABI == Strip it out. Okay, as I have delayed things enough for you, didn't wanted to do that anymore. And so worked on it despite very tight schedule :) Below is the refreshed binding changes (I have

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-09-10 Thread Lee Jones
On Thu, 10 Sep 2015, Viresh Kumar wrote: > On 09-09-15, 17:57, Stephen Boyd wrote: > > I think it will work for qcom use cases. > > Thanks for the Rant Rob, it finally got me moving :) > > > We can collapse the > > tables down to one node and have speed bin and version as the > >

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-09-09 Thread Viresh Kumar
On 02-09-15, 13:58, Rob Herring wrote: > What do you expect here? It is your job to close it. Ultimately, this > will be your problem to deal with. If you have 10 different vendors > doing selection of OPPs in 10 different ways you will not be able to > change that easily later. Maybe if you can't

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-09-09 Thread Lee Jones
On Wed, 09 Sep 2015, Viresh Kumar wrote: > On 02-09-15, 13:58, Rob Herring wrote: > > What do you expect here? It is your job to close it. Ultimately, this > > will be your problem to deal with. If you have 10 different vendors > > doing selection of OPPs in 10 different ways you will not be able

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-09-09 Thread Viresh Kumar
On 09-09-15, 08:59, Lee Jones wrote: > Thanks for doing this Viresh. I appreciate your efforts. I wanted to get this sorted out, before we meet face to face :) > > -8<- > > From: Viresh Kumar > > Date: Wed, 9 Sep 2015

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-09-09 Thread Lee Jones
On Wed, 09 Sep 2015, Viresh Kumar wrote: > On 09-09-15, 08:59, Lee Jones wrote: > > Thanks for doing this Viresh. I appreciate your efforts. > > I wanted to get this sorted out, before we meet face to face :) > > > > -8<- > > > From: Viresh Kumar

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-09-09 Thread Viresh Kumar
On 09-09-15, 14:39, Lee Jones wrote: > Okay, I see what you mean. Sound fine, although only allows up to 31 > versions. Not an issue for us I don't think, but could be for other > vendors. Taking a recent example, the kernel recently went up to > v2.6.39 and some of the stable releases have

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-09-09 Thread Rob Herring
On 09/09/2015 11:36 AM, Lee Jones wrote: >>> Or have I got the wrong end of the stick? >>> >>> NB: Note the suggested new property names. >> >> Yeah, all looks fine to me. > > I think these names are better: > > opp-supply-range-name => opp-microvolt-names > opp-cuts =>

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-09-09 Thread Viresh Kumar
On 09-09-15, 17:57, Stephen Boyd wrote: > I think it will work for qcom use cases. Thanks for the Rant Rob, it finally got me moving :) > We can collapse the > tables down to one node and have speed bin and version as the > opp-supported-hw property. The opp-microvolt-names property would I am

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-09-09 Thread Stephen Boyd
On 09/09, Rob Herring wrote: > On 09/09/2015 11:36 AM, Lee Jones wrote: > >>> Or have I got the wrong end of the stick? > >>> > >>> NB: Note the suggested new property names. > >> > >> Yeah, all looks fine to me. > > > > I think these names are better: > > > > opp-supply-range-name =>

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-09-09 Thread Lee Jones
> > Or have I got the wrong end of the stick? > > > > NB: Note the suggested new property names. > > Yeah, all looks fine to me. I think these names are better: opp-supply-range-name => opp-microvolt-names opp-cuts => opp-supported-hw Apart from that, the binding is starting

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-09-02 Thread Viresh Kumar
On 26-08-15, 13:06, Lee Jones wrote: > On Wed, 12 Aug 2015, Viresh Kumar wrote: > > > On 11-08-15, 16:17, Lee Jones wrote: > > > This would work if we only had a single variable to contend with, but > > > what I showed you in my previous example is that we have 3 variables > > > to consider; cut

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-09-02 Thread Rob Herring
On Wed, Sep 2, 2015 at 3:06 AM, Viresh Kumar wrote: > On 26-08-15, 13:06, Lee Jones wrote: >> On Wed, 12 Aug 2015, Viresh Kumar wrote: >> >> > On 11-08-15, 16:17, Lee Jones wrote: >> > > This would work if we only had a single variable to contend with, but >> > > what I

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-08-26 Thread Lee Jones
On Wed, 12 Aug 2015, Viresh Kumar wrote: On 11-08-15, 16:17, Lee Jones wrote: This would work if we only had a single variable to contend with, but what I showed you in my previous example is that we have 3 variables to consider; cut (version), pcode and substrate. Using the two

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-08-12 Thread Viresh Kumar
On 11-08-15, 16:17, Lee Jones wrote: This would work if we only had a single variable to contend with, but what I showed you in my previous example is that we have 3 variables to consider; cut (version), pcode and substrate. Using the two (simple) examples I provided, how would your

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-08-11 Thread Viresh Kumar
On 10-08-15, 14:22, Lee Jones wrote: Optional properties: +- opp-cuts: One or more strings, describing the versions of hardware the OPPs + can support. This isn't very generic. I'm guessing some vendors my have quite a few ways to differentiate between board

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-08-11 Thread Viresh Kumar
On 11-08-15, 10:30, Lee Jones wrote: On Tue, 11 Aug 2015, Viresh Kumar wrote: On 10-08-15, 14:22, Lee Jones wrote: Optional properties: +- opp-cuts: One or more strings, describing the versions of hardware the OPPs + can support. This isn't very generic. I'm

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-08-11 Thread Lee Jones
On Tue, 11 Aug 2015, Viresh Kumar wrote: On 10-08-15, 14:22, Lee Jones wrote: Optional properties: +- opp-cuts: One or more strings, describing the versions of hardware the OPPs + can support. This isn't very generic. I'm guessing some vendors my have quite a few ways to

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-08-11 Thread Lee Jones
On Tue, 11 Aug 2015, Viresh Kumar wrote: On 11-08-15, 10:30, Lee Jones wrote: On Tue, 11 Aug 2015, Viresh Kumar wrote: On 10-08-15, 14:22, Lee Jones wrote: Optional properties: +- opp-cuts: One or more strings, describing the versions of hardware the OPPs + can

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-08-11 Thread Viresh Kumar
On 11-08-15, 12:54, Lee Jones wrote: The framework does not need to parse this information. It is used solely by the platform driver, whose job it is to decide which OPPs are appropriate for the running platform. The OPP layer needs to parse OPP nodes in DT. But for doing that it needs to

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-08-11 Thread Lee Jones
On Tue, 11 Aug 2015, Viresh Kumar wrote: On 11-08-15, 12:54, Lee Jones wrote: The framework does not need to parse this information. It is used solely by the platform driver, whose job it is to decide which OPPs are appropriate for the running platform. The OPP layer needs to parse OPP

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-08-11 Thread Viresh Kumar
On 11-08-15, 14:27, Lee Jones wrote: Okay, so what you're saying is that you've already made the decision to create a separate node for every OPP permutation, Absolutely not. despite the fact that I've told you this could lead to more nodes than anyone would care to successfully write or

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-08-11 Thread Lee Jones
On Tue, 11 Aug 2015, Viresh Kumar wrote: On 11-08-15, 14:27, Lee Jones wrote: Okay, so what you're saying is that you've already made the decision to create a separate node for every OPP permutation, Absolutely not. despite the fact that I've told you this could lead to more nodes

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-08-10 Thread Lee Jones
On Mon, 03 Aug 2015, Viresh Kumar wrote: On 31-07-15, 09:37, Stephen Boyd wrote: For qcom platforms, the frequency is almost always constant. There may be some tables where we have a couple higher frequencies than others because the speed bin is different. Otherwise the voltage/current

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-08-02 Thread Viresh Kumar
On 31-07-15, 09:37, Stephen Boyd wrote: For qcom platforms, the frequency is almost always constant. There may be some tables where we have a couple higher frequencies than others because the speed bin is different. Otherwise the voltage/current is changing based on the silicon

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-08-01 Thread Viresh Kumar
On 31-07-15, 09:37, Stephen Boyd wrote: Do we need vendor specific properties for that though? Sorry Lee :), but this is exactly why I wanted this thread to exist. We must and should do this in a generic enough way. -- viresh -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-07-31 Thread Stephen Boyd
On 07/30, Rob Herring wrote: On Thu, Jul 30, 2015 at 3:46 AM, Lee Jones lee.jo...@linaro.org wrote: There is nothing stopping us from representing the data in this way. On the plus side, it would mean that we wouldn't need any vendor specific properties. However, far outweighing the

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-07-30 Thread Lee Jones
On Wed, 29 Jul 2015, Stephen Boyd wrote: On 07/29, Lee Jones wrote: On Tue, 28 Jul 2015, Stephen Boyd wrote: On 07/28, Viresh Kumar wrote: Cc'ing few people (whom I cc'd last time as well :)). On 27-07-15, 16:20, Lee Jones wrote: + - opp-hz: CPU frequency

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-07-30 Thread Rob Herring
On Thu, Jul 30, 2015 at 3:46 AM, Lee Jones lee.jo...@linaro.org wrote: On Wed, 29 Jul 2015, Stephen Boyd wrote: On 07/29, Lee Jones wrote: On Tue, 28 Jul 2015, Stephen Boyd wrote: On 07/28, Viresh Kumar wrote: Cc'ing few people (whom I cc'd last time as well :)). On 27-07-15,

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-07-29 Thread Stephen Boyd
On 07/29, Lee Jones wrote: On Tue, 28 Jul 2015, Stephen Boyd wrote: On 07/28, Viresh Kumar wrote: Cc'ing few people (whom I cc'd last time as well :)). On 27-07-15, 16:20, Lee Jones wrote: + - opp-hz : CPU frequency [Hz] for this OPP [See: ./opp.txt] + -

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-07-29 Thread Lee Jones
On Tue, 28 Jul 2015, Stephen Boyd wrote: On 07/28, Viresh Kumar wrote: Cc'ing few people (whom I cc'd last time as well :)). On 27-07-15, 16:20, Lee Jones wrote: These OPPs are used in ST's CPUFreq implementation. Signed-off-by: Lee Jones lee.jo...@linaro.org ---

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-07-28 Thread Lee Jones
On Tue, 28 Jul 2015, Viresh Kumar wrote: Cc'ing few people (whom I cc'd last time as well :)). On 27-07-15, 16:20, Lee Jones wrote: These OPPs are used in ST's CPUFreq implementation. Signed-off-by: Lee Jones lee.jo...@linaro.org --- Changelog: - None, new patch

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-07-28 Thread Lee Jones
On Tue, 28 Jul 2015, Viresh Kumar wrote: On 28-07-15, 08:34, Lee Jones wrote: I disagree. For one, only 'opp-hz' is defined in ./opp.tx. Secondly There are other properties in op.txt like turbo, opp-suspend, latency, etc.. which can be useful for your platform to. Its not used for now

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-07-28 Thread Viresh Kumar
On 28-07-15, 08:34, Lee Jones wrote: I disagree. For one, only 'opp-hz' is defined in ./opp.tx. Secondly There are other properties in op.txt like turbo, opp-suspend, latency, etc.. which can be useful for your platform to. Its not used for now is a different thing. it would be annoying to

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-07-28 Thread Lee Jones
On Tue, 28 Jul 2015, Rob Herring wrote: On Mon, Jul 27, 2015 at 10:20 AM, Lee Jones lee.jo...@linaro.org wrote: These OPPs are used in ST's CPUFreq implementation. Signed-off-by: Lee Jones lee.jo...@linaro.org --- Changelog: - None, new patch

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-07-28 Thread Rob Herring
On Mon, Jul 27, 2015 at 10:20 AM, Lee Jones lee.jo...@linaro.org wrote: These OPPs are used in ST's CPUFreq implementation. Signed-off-by: Lee Jones lee.jo...@linaro.org --- Changelog: - None, new patch Documentation/devicetree/bindings/power/opp-st.txt | 76 ++ 1

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-07-28 Thread Lee Jones
On Tue, 28 Jul 2015, Rob Herring wrote: On Tue, Jul 28, 2015 at 9:39 AM, Lee Jones lee.jo...@linaro.org wrote: On Tue, 28 Jul 2015, Rob Herring wrote: On Mon, Jul 27, 2015 at 10:20 AM, Lee Jones lee.jo...@linaro.org wrote: These OPPs are used in ST's CPUFreq implementation.

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-07-28 Thread Rob Herring
On Tue, Jul 28, 2015 at 9:39 AM, Lee Jones lee.jo...@linaro.org wrote: On Tue, 28 Jul 2015, Rob Herring wrote: On Mon, Jul 27, 2015 at 10:20 AM, Lee Jones lee.jo...@linaro.org wrote: These OPPs are used in ST's CPUFreq implementation. Signed-off-by: Lee Jones lee.jo...@linaro.org ---

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-07-28 Thread Stephen Boyd
On 07/28, Viresh Kumar wrote: Cc'ing few people (whom I cc'd last time as well :)). On 27-07-15, 16:20, Lee Jones wrote: These OPPs are used in ST's CPUFreq implementation. Signed-off-by: Lee Jones lee.jo...@linaro.org --- Changelog: - None, new patch

[PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-07-27 Thread Lee Jones
These OPPs are used in ST's CPUFreq implementation. Signed-off-by: Lee Jones lee.jo...@linaro.org --- Changelog: - None, new patch Documentation/devicetree/bindings/power/opp-st.txt | 76 ++ 1 file changed, 76 insertions(+) create mode 100644

Re: [PATCH v4 2/2] dt: power: st: Provide bindings for ST's OPPs

2015-07-27 Thread Viresh Kumar
Cc'ing few people (whom I cc'd last time as well :)). On 27-07-15, 16:20, Lee Jones wrote: These OPPs are used in ST's CPUFreq implementation. Signed-off-by: Lee Jones lee.jo...@linaro.org --- Changelog: - None, new patch Documentation/devicetree/bindings/power/opp-st.txt | 76