Re: [PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs

2016-10-31 Thread Rob Herring
On Mon, Oct 31, 2016 at 11:58 AM, Joel Holdsworth wrote: > Hi Rob, > > Thanks for taking the time review the patches. > >>> .../bindings/fpga/lattice-ice40-fpga-mgr.txt | 23 +++ >> >> >> It's preferred that bindings are a separate patch. > > > Can you just clarify a little? I'm happy to sp

Re: [PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs

2016-10-31 Thread Moritz Fischer
On Mon, Oct 31, 2016 at 9:58 AM, Joel Holdsworth wrote: > Hi Rob, > > Thanks for taking the time review the patches. > >>> .../bindings/fpga/lattice-ice40-fpga-mgr.txt | 23 +++ >> >> >> It's preferred that bindings are a separate patch. > > > Can you just clarify a little? I'm happy to spl

Re: [PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs

2016-10-31 Thread Joel Holdsworth
Hi Rob, Thanks for taking the time review the patches. .../bindings/fpga/lattice-ice40-fpga-mgr.txt | 23 +++ It's preferred that bindings are a separate patch. Can you just clarify a little? I'm happy to split the patch up, but I don't understand how it could work without the bindi

Re: [PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs

2016-10-30 Thread Rob Herring
On Sat, Oct 29, 2016 at 03:32:26PM -0600, Joel Holdsworth wrote: > The Lattice iCE40 is a family of FPGAs with a minimalistic architecture > and very regular structure, designed for low-cost, high-volume consumer > and system applications. > > This patch adds support to the FPGA manager for config

Re: [PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs

2016-10-30 Thread Joel Holdsworth
Plural, please, like in the previous version, cfr. Hmm ok - it used to be plural, but I received advice to make it singular. I'll change it back. Joel

Re: [PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs

2016-10-30 Thread Geert Uytterhoeven
On Sat, Oct 29, 2016 at 11:32 PM, Joel Holdsworth wrote: > --- /dev/null > +++ b/Documentation/devicetree/bindings/fpga/lattice-ice40-fpga-mgr.txt > @@ -0,0 +1,23 @@ > +- cdone-gpio: GPIO connected to CDONE pin > +- creset_b-gpio: GPIO connected to CRESET_B pin. Note that CRESET_B

Re: [PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs

2016-10-29 Thread kbuild test robot
Hi Joel, [auto build test ERROR on linus/master] [also build test ERROR on v4.9-rc3 next-20161028] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to record what

Re: [PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs

2016-10-29 Thread kbuild test robot
Hi Joel, [auto build test ERROR on linus/master] [also build test ERROR on v4.9-rc3 next-20161028] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to record what

Re: [PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs

2016-10-29 Thread kbuild test robot
Hi Joel, [auto build test ERROR on linus/master] [also build test ERROR on v4.9-rc3 next-20161028] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to record what

[PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs

2016-10-29 Thread Joel Holdsworth
The Lattice iCE40 is a family of FPGAs with a minimalistic architecture and very regular structure, designed for low-cost, high-volume consumer and system applications. This patch adds support to the FPGA manager for configuring the SRAM of iCE40LM, iCE40LP, iCE40HX, iCE40 Ultra, iCE40 UltraLite a