Re: [PATCH v4 3/3] arm64: allwinner: a64: bananapi-m64: add usb otg

2018-01-19 Thread Chen-Yu Tsai 
On Fri, Jan 12, 2018 at 2:30 PM, Jagan Teki  wrote:
> Add usb otg support for bananapi-m64 board,
> - USB-ID connected with PH9
> - USB-DRVVBUS controlled by N_VBUSEN pin from PMIC
>
> Signed-off-by: Jagan Teki 
> ---
> Changes for v4:
> - rebase on master
> - tested otg host mode.
> Changes for v3:
> - Move the position of reg_drivevbus as per binding documentation.
> Changes for v2:
> - add drvvbus regulator
> - add N_VBUSEN pin
>
>  .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts  | 21 
> +
>  1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts 
> b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> index a697567..26e8534 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> @@ -86,6 +86,10 @@
> };
>  };
>
> + {
> +   status = "okay";
> +};
> +
>   {
> status = "okay";
>  };
> @@ -156,6 +160,10 @@
> status = "okay";
>  };
>
> + {
> +   status = "okay";
> +};
> +
>   {
> status = "okay";
>  };
> @@ -168,6 +176,7 @@
> reg = <0x3a3>;
> interrupt-parent = <_intc>;
> interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +   x-powers,drive-vbus-en; /* set N_VBUSEN as output pin */
> };
>  };
>
> @@ -283,6 +292,11 @@
> regulator-name = "vcc-rtc";
>  };
>
> +_drivevbus {

Please keep the nodes in alphabetical order. Otherwise,

Reviewed-by: Chen-Yu Tsai 

> +   regulator-name = "usb0-vbus";
> +   status = "okay";
> +};
> +
>   {
> pinctrl-names = "default";
> pinctrl-0 = <_pins_a>;
> @@ -295,6 +309,13 @@
> status = "okay";
>  };
>
> +_otg {
> +   dr_mode = "otg";
> +   status = "okay";
> +};
> +
>   {
> +   usb0_id_det-gpios = < 7 9 GPIO_ACTIVE_HIGH>; /* PH9 */
> +   usb0_vbus-supply = <_drivevbus>;
> status = "okay";
>  };
> --
> 2.7.4
>

Re: [PATCH v4 3/3] arm64: allwinner: a64: bananapi-m64: add usb otg

2018-01-19 Thread Chen-Yu Tsai 
On Fri, Jan 12, 2018 at 2:30 PM, Jagan Teki  wrote:
> Add usb otg support for bananapi-m64 board,
> - USB-ID connected with PH9
> - USB-DRVVBUS controlled by N_VBUSEN pin from PMIC
>
> Signed-off-by: Jagan Teki 
> ---
> Changes for v4:
> - rebase on master
> - tested otg host mode.
> Changes for v3:
> - Move the position of reg_drivevbus as per binding documentation.
> Changes for v2:
> - add drvvbus regulator
> - add N_VBUSEN pin
>
>  .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts  | 21 
> +
>  1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts 
> b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> index a697567..26e8534 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> @@ -86,6 +86,10 @@
> };
>  };
>
> + {
> +   status = "okay";
> +};
> +
>   {
> status = "okay";
>  };
> @@ -156,6 +160,10 @@
> status = "okay";
>  };
>
> + {
> +   status = "okay";
> +};
> +
>   {
> status = "okay";
>  };
> @@ -168,6 +176,7 @@
> reg = <0x3a3>;
> interrupt-parent = <_intc>;
> interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +   x-powers,drive-vbus-en; /* set N_VBUSEN as output pin */
> };
>  };
>
> @@ -283,6 +292,11 @@
> regulator-name = "vcc-rtc";
>  };
>
> +_drivevbus {

Please keep the nodes in alphabetical order. Otherwise,

Reviewed-by: Chen-Yu Tsai 

> +   regulator-name = "usb0-vbus";
> +   status = "okay";
> +};
> +
>   {
> pinctrl-names = "default";
> pinctrl-0 = <_pins_a>;
> @@ -295,6 +309,13 @@
> status = "okay";
>  };
>
> +_otg {
> +   dr_mode = "otg";
> +   status = "okay";
> +};
> +
>   {
> +   usb0_id_det-gpios = < 7 9 GPIO_ACTIVE_HIGH>; /* PH9 */
> +   usb0_vbus-supply = <_drivevbus>;
> status = "okay";
>  };
> --
> 2.7.4
>

[PATCH v4 3/3] arm64: allwinner: a64: bananapi-m64: add usb otg

2018-01-11 Thread Jagan Teki 
Add usb otg support for bananapi-m64 board,
- USB-ID connected with PH9
- USB-DRVVBUS controlled by N_VBUSEN pin from PMIC

Signed-off-by: Jagan Teki 
---
Changes for v4:
- rebase on master
- tested otg host mode.
Changes for v3:
- Move the position of reg_drivevbus as per binding documentation.
Changes for v2:
- add drvvbus regulator
- add N_VBUSEN pin

 .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts  | 21 +
 1 file changed, 21 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts 
b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
index a697567..26e8534 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
@@ -86,6 +86,10 @@
};
 };
 
+ {
+   status = "okay";
+};
+
  {
status = "okay";
 };
@@ -156,6 +160,10 @@
status = "okay";
 };
 
+ {
+   status = "okay";
+};
+
  {
status = "okay";
 };
@@ -168,6 +176,7 @@
reg = <0x3a3>;
interrupt-parent = <_intc>;
interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+   x-powers,drive-vbus-en; /* set N_VBUSEN as output pin */
};
 };
 
@@ -283,6 +292,11 @@
regulator-name = "vcc-rtc";
 };
 
+_drivevbus {
+   regulator-name = "usb0-vbus";
+   status = "okay";
+};
+
  {
pinctrl-names = "default";
pinctrl-0 = <_pins_a>;
@@ -295,6 +309,13 @@
status = "okay";
 };
 
+_otg {
+   dr_mode = "otg";
+   status = "okay";
+};
+
  {
+   usb0_id_det-gpios = < 7 9 GPIO_ACTIVE_HIGH>; /* PH9 */
+   usb0_vbus-supply = <_drivevbus>;
status = "okay";
 };
-- 
2.7.4

[PATCH v4 3/3] arm64: allwinner: a64: bananapi-m64: add usb otg

2018-01-11 Thread Jagan Teki 
Add usb otg support for bananapi-m64 board,
- USB-ID connected with PH9
- USB-DRVVBUS controlled by N_VBUSEN pin from PMIC

Signed-off-by: Jagan Teki 
---
Changes for v4:
- rebase on master
- tested otg host mode.
Changes for v3:
- Move the position of reg_drivevbus as per binding documentation.
Changes for v2:
- add drvvbus regulator
- add N_VBUSEN pin

 .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts  | 21 +
 1 file changed, 21 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts 
b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
index a697567..26e8534 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
@@ -86,6 +86,10 @@
};
 };
 
+ {
+   status = "okay";
+};
+
  {
status = "okay";
 };
@@ -156,6 +160,10 @@
status = "okay";
 };
 
+ {
+   status = "okay";
+};
+
  {
status = "okay";
 };
@@ -168,6 +176,7 @@
reg = <0x3a3>;
interrupt-parent = <_intc>;
interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+   x-powers,drive-vbus-en; /* set N_VBUSEN as output pin */
};
 };
 
@@ -283,6 +292,11 @@
regulator-name = "vcc-rtc";
 };
 
+_drivevbus {
+   regulator-name = "usb0-vbus";
+   status = "okay";
+};
+
  {
pinctrl-names = "default";
pinctrl-0 = <_pins_a>;
@@ -295,6 +309,13 @@
status = "okay";
 };
 
+_otg {
+   dr_mode = "otg";
+   status = "okay";
+};
+
  {
+   usb0_id_det-gpios = < 7 9 GPIO_ACTIVE_HIGH>; /* PH9 */
+   usb0_vbus-supply = <_drivevbus>;
status = "okay";
 };
-- 
2.7.4