Re: [PATCH v4 3/4] staging: unisys: use local variable instead of global

2015-03-24 Thread Dan Carpenter
I don't like how these are broken up at all. It's random grab bag of renaming and deleting. Do it like this, perhaps: [patch 1] delete registered Leave the if (MAJOR(majordev) >= 0) for now, because it just confuses issues to mix it in. Delete all references to registered. [patch 1] use local

[PATCH v4 3/4] staging: unisys: use local variable instead of global

2015-03-24 Thread Sudip Mukherjee
dev_t was passed as an argument to visorchipset_file_init() which was storing that value in a global variable so that it can be used while cleanup. now we are no longer using the global variable in the cleanup so we donot need to keep the global variable anymore. Signed-off-by: Sudip Mukherjee --