Re: [PATCH v4 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-02 Thread Vivek Gautam
On Fri, May 2, 2014 at 2:55 PM, Vivek Gautam wrote: > Hi Tomasz, > > > On Thu, May 1, 2014 at 10:46 PM, Tomasz Figa wrote: >> Hi Vivek, >> >> Please see my comments inline. > > Thanks for the review, please find my answers inline. > >> >> >> On 30.04.2014 07:19, Vivek Gautam wrote: >>> >>> Add

Re: [PATCH v4 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-02 Thread Vivek Gautam
Hi Tomasz, On Thu, May 1, 2014 at 10:46 PM, Tomasz Figa wrote: > Hi Vivek, > > Please see my comments inline. Thanks for the review, please find my answers inline. > > > On 30.04.2014 07:19, Vivek Gautam wrote: >> >> Add support to consume phy provided by Generic phy framework. >> Keeping the

Re: [PATCH v4 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-02 Thread Vivek Gautam
Hi Tomasz, On Thu, May 1, 2014 at 10:46 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Vivek, Please see my comments inline. Thanks for the review, please find my answers inline. On 30.04.2014 07:19, Vivek Gautam wrote: Add support to consume phy provided by Generic phy framework.

Re: [PATCH v4 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-02 Thread Vivek Gautam
On Fri, May 2, 2014 at 2:55 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Hi Tomasz, On Thu, May 1, 2014 at 10:46 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Vivek, Please see my comments inline. Thanks for the review, please find my answers inline. On 30.04.2014 07:19, Vivek

Re: [PATCH v4 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-01 Thread Tomasz Figa
Hi Vivek, Please see my comments inline. On 30.04.2014 07:19, Vivek Gautam wrote: Add support to consume phy provided by Generic phy framework. Keeping the support for older usb-phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for

Re: [PATCH v4 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-05-01 Thread Tomasz Figa
Hi Vivek, Please see my comments inline. On 30.04.2014 07:19, Vivek Gautam wrote: Add support to consume phy provided by Generic phy framework. Keeping the support for older usb-phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for

[PATCH v4 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-04-29 Thread Vivek Gautam
Add support to consume phy provided by Generic phy framework. Keeping the support for older usb-phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for ohci-exynos. Once we move to new phy in the device nodes for ohci, we can remove the

[PATCH v4 3/4] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-04-29 Thread Vivek Gautam
Add support to consume phy provided by Generic phy framework. Keeping the support for older usb-phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for ohci-exynos. Once we move to new phy in the device nodes for ohci, we can remove the