Re: [PATCH v4 3/6] regmap: Add regmap_noinc_read API [UNSCANNED]

2018-08-08 Thread Charles Keepax
On Mon, Aug 06, 2018 at 05:04:02PM +0100, Mark Brown wrote: > On Mon, Aug 06, 2018 at 03:39:53PM +, Popa, Stefan Serban wrote: > > On Lu, 2018-08-06 at 15:39 +0100, Mark Brown wrote: > > > > I suggested having an explicit operation to check if a register supports > > > this mode of operation

Re: [PATCH v4 3/6] regmap: Add regmap_noinc_read API [UNSCANNED]

2018-08-08 Thread Charles Keepax
On Mon, Aug 06, 2018 at 05:04:02PM +0100, Mark Brown wrote: > On Mon, Aug 06, 2018 at 03:39:53PM +, Popa, Stefan Serban wrote: > > On Lu, 2018-08-06 at 15:39 +0100, Mark Brown wrote: > > > > I suggested having an explicit operation to check if a register supports > > > this mode of operation

Re: [PATCH v4 3/6] regmap: Add regmap_noinc_read API

2018-08-06 Thread Mark Brown
On Mon, Aug 06, 2018 at 03:39:53PM +, Popa, Stefan Serban wrote: > On Lu, 2018-08-06 at 15:39 +0100, Mark Brown wrote: > > I suggested having an explicit operation to check if a register supports > > this mode of operation when I reviewed an earlier version, I didn't > > notice a reply on

Re: [PATCH v4 3/6] regmap: Add regmap_noinc_read API

2018-08-06 Thread Mark Brown
On Mon, Aug 06, 2018 at 03:39:53PM +, Popa, Stefan Serban wrote: > On Lu, 2018-08-06 at 15:39 +0100, Mark Brown wrote: > > I suggested having an explicit operation to check if a register supports > > this mode of operation when I reviewed an earlier version, I didn't > > notice a reply on

Re: [PATCH v4 3/6] regmap: Add regmap_noinc_read API

2018-08-06 Thread Popa, Stefan Serban
On Lu, 2018-08-06 at 15:39 +0100, Mark Brown wrote: > On Mon, Aug 06, 2018 at 03:04:44PM +0300, Stefan Popa wrote: > > > > > + if (!regmap_volatile(map, reg) || !regmap_readable(map, reg)) > > { > > + ret = -EINVAL; > > + goto out_unlock; > > + } > I suggested having an

Re: [PATCH v4 3/6] regmap: Add regmap_noinc_read API

2018-08-06 Thread Popa, Stefan Serban
On Lu, 2018-08-06 at 15:39 +0100, Mark Brown wrote: > On Mon, Aug 06, 2018 at 03:04:44PM +0300, Stefan Popa wrote: > > > > > + if (!regmap_volatile(map, reg) || !regmap_readable(map, reg)) > > { > > + ret = -EINVAL; > > + goto out_unlock; > > + } > I suggested having an

Re: [PATCH v4 3/6] regmap: Add regmap_noinc_read API

2018-08-06 Thread Mark Brown
On Mon, Aug 06, 2018 at 03:04:44PM +0300, Stefan Popa wrote: > + if (!regmap_volatile(map, reg) || !regmap_readable(map, reg)) { > + ret = -EINVAL; > + goto out_unlock; > + } I suggested having an explicit operation to check if a register supports this mode of

Re: [PATCH v4 3/6] regmap: Add regmap_noinc_read API

2018-08-06 Thread Mark Brown
On Mon, Aug 06, 2018 at 03:04:44PM +0300, Stefan Popa wrote: > + if (!regmap_volatile(map, reg) || !regmap_readable(map, reg)) { > + ret = -EINVAL; > + goto out_unlock; > + } I suggested having an explicit operation to check if a register supports this mode of

[PATCH v4 3/6] regmap: Add regmap_noinc_read API

2018-08-06 Thread Stefan Popa
From: Crestez Dan Leonard The regmap API usually assumes that bulk read operations will read a range of registers but some I2C/SPI devices have certain registers for which a such a read operation will return data from an internal FIFO instead. Add an explicit API to support bulk read without

[PATCH v4 3/6] regmap: Add regmap_noinc_read API

2018-08-06 Thread Stefan Popa
From: Crestez Dan Leonard The regmap API usually assumes that bulk read operations will read a range of registers but some I2C/SPI devices have certain registers for which a such a read operation will return data from an internal FIFO instead. Add an explicit API to support bulk read without