Re: [PATCH v4 3/7] blk-mq: Fix use after of free q->mq_map

On Tue, Oct 06, 2015 at 08:50:47AM +0900, Akinobu Mita wrote: > 2015-09-29 15:52 GMT+09:00 Christoph Hellwig : > > Looks good, > > > > Reviewed-by: Christoph Hellwig > > > > Can you also add a patch that renames blk_mq_free_queue to > > blk_mq_cleaup_queue and adds a comment that we should not

Re: [PATCH v4 3/7] blk-mq: Fix use after of free q->mq_map

On Tue, Oct 06, 2015 at 08:50:47AM +0900, Akinobu Mita wrote: > 2015-09-29 15:52 GMT+09:00 Christoph Hellwig : > > Looks good, > > > > Reviewed-by: Christoph Hellwig > > > > Can you also add a patch that renames blk_mq_free_queue to > > blk_mq_cleaup_queue and adds a

Re: [PATCH v4 3/7] blk-mq: Fix use after of free q->mq_map

2015-09-29 15:52 GMT+09:00 Christoph Hellwig : > Looks good, > > Reviewed-by: Christoph Hellwig > > Can you also add a patch that renames blk_mq_free_queue to > blk_mq_cleaup_queue and adds a comment that we should not free any memory > here? We had way too many bugs of this kinds

Re: [PATCH v4 3/7] blk-mq: Fix use after of free q->mq_map

2015-09-29 15:52 GMT+09:00 Christoph Hellwig : > Looks good, > > Reviewed-by: Christoph Hellwig > > Can you also add a patch that renames blk_mq_free_queue to > blk_mq_cleaup_queue and adds a comment that we should not free any memory > here? We had way too many bugs

Re: [PATCH v4 3/7] blk-mq: Fix use after of free q->mq_map

Looks good, Reviewed-by: Christoph Hellwig Can you also add a patch that renames blk_mq_free_queue to blk_mq_cleaup_queue and adds a comment that we should not free any memory here? We had way too many bugs of this kinds unfortunately. -- To unsubscribe from this list: send the line

Re: [PATCH v4 3/7] blk-mq: Fix use after of free q->mq_map

Looks good, Reviewed-by: Christoph Hellwig Can you also add a patch that renames blk_mq_free_queue to blk_mq_cleaup_queue and adds a comment that we should not free any memory here? We had way too many bugs of this kinds unfortunately. -- To unsubscribe from this list: send the

[PATCH v4 3/7] blk-mq: Fix use after of free q->mq_map

CPU hotplug handling for blk-mq (blk_mq_queue_reinit) updates q->mq_map by blk_mq_update_queue_map() for all request queues in all_q_list. On the other hand, q->mq_map is released before deleting the queue from all_q_list. So if CPU hotplug event occurs in the window, invalid memory access can

[PATCH v4 3/7] blk-mq: Fix use after of free q->mq_map

CPU hotplug handling for blk-mq (blk_mq_queue_reinit) updates q->mq_map by blk_mq_update_queue_map() for all request queues in all_q_list. On the other hand, q->mq_map is released before deleting the queue from all_q_list. So if CPU hotplug event occurs in the window, invalid memory access can