Re: [PATCH v4 3/7] scsi: dpt_i2o: eliminate duplicate barriers on weakly-ordered archs

2018-03-20 Thread okaya
On 2018-03-20 06:23, Christoph Hellwig wrote: This is a basically unmaintained driver for historic hardware, and not the right place for micro-optimizations. Sure, I can drop this on the next version.

Re: [PATCH v4 3/7] scsi: dpt_i2o: eliminate duplicate barriers on weakly-ordered archs

2018-03-20 Thread Christoph Hellwig
This is a basically unmaintained driver for historic hardware, and not the right place for micro-optimizations.

[PATCH v4 3/7] scsi: dpt_i2o: eliminate duplicate barriers on weakly-ordered archs

2018-03-19 Thread Sinan Kaya
Code includes barrier() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-