Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-31 Thread Ingo Molnar
* Russell King - ARM Linux wrote: > On Mon, Jan 23, 2017 at 05:52:45PM +0100, Borislav Petkov wrote: > > On Mon, Jan 23, 2017 at 03:58:37PM +0100, Nicolas Dichtel wrote: > > > This header file is exported, thus move it to uapi. > > > > Why? Why is this damn thing

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-31 Thread Ingo Molnar
* Russell King - ARM Linux wrote: > On Mon, Jan 23, 2017 at 05:52:45PM +0100, Borislav Petkov wrote: > > On Mon, Jan 23, 2017 at 03:58:37PM +0100, Nicolas Dichtel wrote: > > > This header file is exported, thus move it to uapi. > > > > Why? Why is this damn thing exported in the first place? >

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-31 Thread Nicolas Dichtel
Le 30/01/2017 à 15:51, Russell King - ARM Linux a écrit : > On Mon, Jan 23, 2017 at 05:52:45PM +0100, Borislav Petkov wrote: >> On Mon, Jan 23, 2017 at 03:58:37PM +0100, Nicolas Dichtel wrote: >>> This header file is exported, thus move it to uapi. >> >> Why? Why is this damn thing exported in the

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-31 Thread Nicolas Dichtel
Le 30/01/2017 à 15:51, Russell King - ARM Linux a écrit : > On Mon, Jan 23, 2017 at 05:52:45PM +0100, Borislav Petkov wrote: >> On Mon, Jan 23, 2017 at 03:58:37PM +0100, Nicolas Dichtel wrote: >>> This header file is exported, thus move it to uapi. >> >> Why? Why is this damn thing exported in the

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-30 Thread Borislav Petkov
On Mon, Jan 30, 2017 at 02:51:51PM +, Russell King - ARM Linux wrote: > Like it or not, it is _already_ exported to userspace, so it forms Well, I did try to stop it then too: b72e7464e4cf ("x86/uapi: Do not export as part of the user API headers") And yet this wankery trickled out to

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-30 Thread Borislav Petkov
On Mon, Jan 30, 2017 at 02:51:51PM +, Russell King - ARM Linux wrote: > Like it or not, it is _already_ exported to userspace, so it forms Well, I did try to stop it then too: b72e7464e4cf ("x86/uapi: Do not export as part of the user API headers") And yet this wankery trickled out to

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-30 Thread Russell King - ARM Linux
On Mon, Jan 23, 2017 at 05:52:45PM +0100, Borislav Petkov wrote: > On Mon, Jan 23, 2017 at 03:58:37PM +0100, Nicolas Dichtel wrote: > > This header file is exported, thus move it to uapi. > > Why? Why is this damn thing exported in the first place? > > The moment we decide to change an MSR name

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-30 Thread Russell King - ARM Linux
On Mon, Jan 23, 2017 at 05:52:45PM +0100, Borislav Petkov wrote: > On Mon, Jan 23, 2017 at 03:58:37PM +0100, Nicolas Dichtel wrote: > > This header file is exported, thus move it to uapi. > > Why? Why is this damn thing exported in the first place? > > The moment we decide to change an MSR name

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-26 Thread Borislav Petkov
On Thu, Jan 26, 2017 at 08:04:52PM +0100, Ingo Molnar wrote: > Please remove this patch from linux-next as well, until you get an > Acked-by from an x86 maintainer. ... and the header export from arch/x86/include/uapi/asm/Kbuild too pls. -- Regards/Gruss, Boris. Good mailing practices for

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-26 Thread Borislav Petkov
On Thu, Jan 26, 2017 at 08:04:52PM +0100, Ingo Molnar wrote: > Please remove this patch from linux-next as well, until you get an > Acked-by from an x86 maintainer. ... and the header export from arch/x86/include/uapi/asm/Kbuild too pls. -- Regards/Gruss, Boris. Good mailing practices for

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-26 Thread Ingo Molnar
* Nicolas Dichtel wrote: > This header file is exported, thus move it to uapi. > > Signed-off-by: Nicolas Dichtel > --- > arch/x86/include/asm/msr-index.h | 698 > -- >

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-26 Thread Ingo Molnar
* Nicolas Dichtel wrote: > This header file is exported, thus move it to uapi. > > Signed-off-by: Nicolas Dichtel > --- > arch/x86/include/asm/msr-index.h | 698 > -- > arch/x86/include/uapi/asm/msr-index.h | 698 > ++

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-26 Thread Nicolas Dichtel
Le 23/01/2017 à 18:26, Borislav Petkov a écrit : > On Mon, Jan 23, 2017 at 09:21:03AM -0800, Christoph Hellwig wrote: >> Or keep the exported version as-is and never changed it, and use >> a different copy for the kernel itself. > > Yeah, that's a good idea, thanks Christoph. > > I guess we'll

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-26 Thread Nicolas Dichtel
Le 23/01/2017 à 18:26, Borislav Petkov a écrit : > On Mon, Jan 23, 2017 at 09:21:03AM -0800, Christoph Hellwig wrote: >> Or keep the exported version as-is and never changed it, and use >> a different copy for the kernel itself. > > Yeah, that's a good idea, thanks Christoph. > > I guess we'll

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread Borislav Petkov
On Mon, Jan 23, 2017 at 11:24:02PM +0100, Jan Engelhardt wrote: > So if some userspace component depends on that particular msr header > (which, unlike ipt_SAME, was not intended for export), is it not > reasonable to expect them to make a copy if and when they need it? Yeah, either copy the

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread Borislav Petkov
On Mon, Jan 23, 2017 at 11:24:02PM +0100, Jan Engelhardt wrote: > So if some userspace component depends on that particular msr header > (which, unlike ipt_SAME, was not intended for export), is it not > reasonable to expect them to make a copy if and when they need it? Yeah, either copy the

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread Jan Engelhardt
On Monday 2017-01-23 18:26, Borislav Petkov wrote: >On Mon, Jan 23, 2017 at 09:21:03AM -0800, Christoph Hellwig wrote: >> Or keep the exported version as-is and never changed it, and use >> a different copy for the kernel itself. > >I guess we'll have to do that if something in userspace has put

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread Jan Engelhardt
On Monday 2017-01-23 18:26, Borislav Petkov wrote: >On Mon, Jan 23, 2017 at 09:21:03AM -0800, Christoph Hellwig wrote: >> Or keep the exported version as-is and never changed it, and use >> a different copy for the kernel itself. > >I guess we'll have to do that if something in userspace has put

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread kbuild test robot
Hi Nicolas, [auto build test ERROR on linus/master] [also build test ERROR on v4.10-rc5 next-20170123] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread kbuild test robot
Hi Nicolas, [auto build test ERROR on linus/master] [also build test ERROR on v4.10-rc5 next-20170123] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread kbuild test robot
Hi Nicolas, [auto build test ERROR on linus/master] [also build test ERROR on v4.10-rc5 next-20170123] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread kbuild test robot
Hi Nicolas, [auto build test ERROR on linus/master] [also build test ERROR on v4.10-rc5 next-20170123] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread Borislav Petkov
On Mon, Jan 23, 2017 at 09:21:03AM -0800, Christoph Hellwig wrote: > Or keep the exported version as-is and never changed it, and use > a different copy for the kernel itself. Yeah, that's a good idea, thanks Christoph. I guess we'll have to do that if something in userspace has put its sticky

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread Borislav Petkov
On Mon, Jan 23, 2017 at 09:21:03AM -0800, Christoph Hellwig wrote: > Or keep the exported version as-is and never changed it, and use > a different copy for the kernel itself. Yeah, that's a good idea, thanks Christoph. I guess we'll have to do that if something in userspace has put its sticky

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread Christoph Hellwig
On Mon, Jan 23, 2017 at 06:17:32PM +0100, Borislav Petkov wrote: > I know, we should not ever break userspace but if it were me, I'd remove > that export and see what breaks. If at all. Or keep the exported version as-is and never changed it, and use a different copy for the kernel itself.

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread Christoph Hellwig
On Mon, Jan 23, 2017 at 06:17:32PM +0100, Borislav Petkov wrote: > I know, we should not ever break userspace but if it were me, I'd remove > that export and see what breaks. If at all. Or keep the exported version as-is and never changed it, and use a different copy for the kernel itself.

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread Borislav Petkov
On Mon, Jan 23, 2017 at 06:06:52PM +0100, Nicolas Dichtel wrote: > After digging a bit, it seems you have already tried to remove it in commit > b72e7464e4cf ("x86/uapi: Do not export as part of the user > API > headers"), but because this file is still listed in the Kbuild file, it is > still

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread Borislav Petkov
On Mon, Jan 23, 2017 at 06:06:52PM +0100, Nicolas Dichtel wrote: > After digging a bit, it seems you have already tried to remove it in commit > b72e7464e4cf ("x86/uapi: Do not export as part of the user > API > headers"), but because this file is still listed in the Kbuild file, it is > still

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread Nicolas Dichtel
+ Peter Anvin and Ingo Molnar Le 23/01/2017 à 17:52, Borislav Petkov a écrit : > On Mon, Jan 23, 2017 at 03:58:37PM +0100, Nicolas Dichtel wrote: >> This header file is exported, thus move it to uapi. > > Why? Why is this damn thing exported in the first place? It is exported because it is

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread Nicolas Dichtel
+ Peter Anvin and Ingo Molnar Le 23/01/2017 à 17:52, Borislav Petkov a écrit : > On Mon, Jan 23, 2017 at 03:58:37PM +0100, Nicolas Dichtel wrote: >> This header file is exported, thus move it to uapi. > > Why? Why is this damn thing exported in the first place? It is exported because it is

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread Borislav Petkov
On Mon, Jan 23, 2017 at 03:58:37PM +0100, Nicolas Dichtel wrote: > This header file is exported, thus move it to uapi. Why? Why is this damn thing exported in the first place? The moment we decide to change an MSR name or even remove it from that file, we break userspace. And what for, because

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread Borislav Petkov
On Mon, Jan 23, 2017 at 03:58:37PM +0100, Nicolas Dichtel wrote: > This header file is exported, thus move it to uapi. Why? Why is this damn thing exported in the first place? The moment we decide to change an MSR name or even remove it from that file, we break userspace. And what for, because

[PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread Nicolas Dichtel
This header file is exported, thus move it to uapi. Signed-off-by: Nicolas Dichtel --- arch/x86/include/asm/msr-index.h | 698 -- arch/x86/include/uapi/asm/msr-index.h | 698 ++ 2 files changed, 698

[PATCH v4 3/7] x86: put msr-index.h in uapi

2017-01-23 Thread Nicolas Dichtel
This header file is exported, thus move it to uapi. Signed-off-by: Nicolas Dichtel --- arch/x86/include/asm/msr-index.h | 698 -- arch/x86/include/uapi/asm/msr-index.h | 698 ++ 2 files changed, 698 insertions(+), 698