RE: [PATCH v4 4/5] net: macb: add support for high speed interface

2019-06-25 Thread Parshuram Raju Thombare
>The closed nature of the USXGMII spec makes it very hard for us to know >whether your implementation is correct or not. > >I have some documentation which suggests that USVGMII is a USXGMII link >running at "5GR" rate as opposed to USXGMII running at "10GR" rate. > >So, I think 5G mode should be

Re: [PATCH v4 4/5] net: macb: add support for high speed interface

2019-06-25 Thread Russell King - ARM Linux admin
On Tue, Jun 25, 2019 at 08:26:29AM +, Parshuram Raju Thombare wrote: > Hi Andrew, > > >What i'm saying is that the USXGMII rate is fixed. So why do you need a > >device > >tree property for the SERDES rate? > This is based on Cisco USXGMII specification, it specify USXGMII 5G and > USXGMII

RE: [PATCH v4 4/5] net: macb: add support for high speed interface

2019-06-25 Thread Parshuram Raju Thombare
Hi Andrew, >What i'm saying is that the USXGMII rate is fixed. So why do you need a device >tree property for the SERDES rate? This is based on Cisco USXGMII specification, it specify USXGMII 5G and USXGMII 10G. Sorry I can't share that document here. Regards, Parshuram Thombare

Re: [PATCH v4 4/5] net: macb: add support for high speed interface

2019-06-24 Thread Andrew Lunn
On Mon, Jun 24, 2019 at 06:52:51AM +, Parshuram Raju Thombare wrote: > Hi Andrew, > > >> +enum { > >> + MACB_SERDES_RATE_5_PT_15625Gbps = 5, > >> + MACB_SERDES_RATE_10_PT_3125Gbps = 10, > >> +}; > >What do the units mean here? Why would you clock the SERDES at 15Tbps, > >or 3Tbps? 3.125Mbps

RE: [PATCH v4 4/5] net: macb: add support for high speed interface

2019-06-24 Thread Parshuram Raju Thombare
Hi Andrew, >> +enum { >> +MACB_SERDES_RATE_5_PT_15625Gbps = 5, >> +MACB_SERDES_RATE_10_PT_3125Gbps = 10, >> +}; >What do the units mean here? Why would you clock the SERDES at 15Tbps, >or 3Tbps? 3.125Mbps would give you 2.5Gbps when using 8b/10b encoding. > MACB_SERDES_RATE_5_PT_15625Gbps

Re: [PATCH v4 4/5] net: macb: add support for high speed interface

2019-06-23 Thread Andrew Lunn
> +enum { > + HS_MAC_SPEED_100M, > + HS_MAC_SPEED_1000M, > + HS_MAC_SPEED_2500M, > + HS_MAC_SPEED_5000M, > + HS_MAC_SPEED_1M, > + HS_MAC_SPEED_25000M, > +}; > + > +enum { > + MACB_SERDES_RATE_5_PT_15625Gbps = 5, > + MACB_SERDES_RATE_10_PT_3125Gbps = 10, > +};

[PATCH v4 4/5] net: macb: add support for high speed interface

2019-06-23 Thread Parshuram Thombare
This patch add support for high speed USXGMII PCS and 10G speed in Cadence ethernet controller driver. Signed-off-by: Parshuram Thombare --- drivers/net/ethernet/cadence/macb.h | 41 + drivers/net/ethernet/cadence/macb_main.c | 194 +++ 2 files changed, 207