Re: [PATCH v4 4/6] iio:adxl372: Add FIFO and interrupts support

2018-08-10 Thread Dan Carpenter
Hi Stefan, I love your patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Stefan-Popa/iio-accel-Add-adxl372-driver/20180807-050955 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg smatch warnings: drivers/iio/accel/adxl372.c:704

Re: [PATCH v4 4/6] iio:adxl372: Add FIFO and interrupts support

2018-08-10 Thread Dan Carpenter
Hi Stefan, I love your patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Stefan-Popa/iio-accel-Add-adxl372-driver/20180807-050955 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg smatch warnings: drivers/iio/accel/adxl372.c:704

[PATCH v4 4/6] iio:adxl372: Add FIFO and interrupts support

2018-08-06 Thread Stefan Popa
This patch adds support for the adxl372 FIFO. In order to accomplish this, triggered buffers were used. The number of FIFO samples which trigger the watermark interrupt can be configured by using the buffer watermark. The FIFO format is determined by configuring the scan elements for each axis.

[PATCH v4 4/6] iio:adxl372: Add FIFO and interrupts support

2018-08-06 Thread Stefan Popa
This patch adds support for the adxl372 FIFO. In order to accomplish this, triggered buffers were used. The number of FIFO samples which trigger the watermark interrupt can be configured by using the buffer watermark. The FIFO format is determined by configuring the scan elements for each axis.