Re: [PATCH v4 4/8] regulator: stpmic1: add stpmic1 regulator driver

2018-10-26 Thread Mark Brown
On Thu, Oct 25, 2018 at 01:23:08PM +, Pascal PAILLET-LME wrote: > I have reworked the code so that we don't touch any more to the init_data. > the new loop to register the regulators is below: > > for (i = 0; i < ARRAY_SIZE(stpmic1_regulator_cfgs); i++) { > ret =

Re: [PATCH v4 4/8] regulator: stpmic1: add stpmic1 regulator driver

2018-10-26 Thread Mark Brown
On Thu, Oct 25, 2018 at 01:23:08PM +, Pascal PAILLET-LME wrote: > I have reworked the code so that we don't touch any more to the init_data. > the new loop to register the regulators is below: > > for (i = 0; i < ARRAY_SIZE(stpmic1_regulator_cfgs); i++) { > ret =

Re: [PATCH v4 4/8] regulator: stpmic1: add stpmic1 regulator driver

2018-10-25 Thread Pascal PAILLET-LME
Hello Mark, Le 10/24/2018 03:17 PM, Mark Brown a écrit : > On Wed, Oct 24, 2018 at 12:54:46PM +, Pascal PAILLET-LME wrote: > >> I'm sorry, I'm not sure to understand. Would you prefer to not register >> regulators that >> are not described in the device-tree ? > No, I'm saying register all

Re: [PATCH v4 4/8] regulator: stpmic1: add stpmic1 regulator driver

2018-10-25 Thread Pascal PAILLET-LME
Hello Mark, Le 10/24/2018 03:17 PM, Mark Brown a écrit : > On Wed, Oct 24, 2018 at 12:54:46PM +, Pascal PAILLET-LME wrote: > >> I'm sorry, I'm not sure to understand. Would you prefer to not register >> regulators that >> are not described in the device-tree ? > No, I'm saying register all

Re: [PATCH v4 4/8] regulator: stpmic1: add stpmic1 regulator driver

2018-10-24 Thread Mark Brown
On Wed, Oct 24, 2018 at 12:54:46PM +, Pascal PAILLET-LME wrote: > I'm sorry, I'm not sure to understand. Would you prefer to not register > regulators that > are not described in the device-tree ? No, I'm saying register all regulators regardless of if they are in the device tree - you

Re: [PATCH v4 4/8] regulator: stpmic1: add stpmic1 regulator driver

2018-10-24 Thread Mark Brown
On Wed, Oct 24, 2018 at 12:54:46PM +, Pascal PAILLET-LME wrote: > I'm sorry, I'm not sure to understand. Would you prefer to not register > regulators that > are not described in the device-tree ? No, I'm saying register all regulators regardless of if they are in the device tree - you

Re: [PATCH v4 4/8] regulator: stpmic1: add stpmic1 regulator driver

2018-10-24 Thread Pascal PAILLET-LME
Hello Mark, Le 10/19/2018 01:50 PM, Mark Brown a écrit : > On Thu, Oct 18, 2018 at 09:02:12AM +, Pascal PAILLET-LME wrote: > >> +for (i = 0; i < ARRAY_SIZE(stpmic1_regulator_cfgs); i++) { >> +/* Parse DT & find regulators to register */ >> +init_data =

Re: [PATCH v4 4/8] regulator: stpmic1: add stpmic1 regulator driver

2018-10-24 Thread Pascal PAILLET-LME
Hello Mark, Le 10/19/2018 01:50 PM, Mark Brown a écrit : > On Thu, Oct 18, 2018 at 09:02:12AM +, Pascal PAILLET-LME wrote: > >> +for (i = 0; i < ARRAY_SIZE(stpmic1_regulator_cfgs); i++) { >> +/* Parse DT & find regulators to register */ >> +init_data =

Re: [PATCH v4 4/8] regulator: stpmic1: add stpmic1 regulator driver

2018-10-19 Thread Mark Brown
On Thu, Oct 18, 2018 at 09:02:12AM +, Pascal PAILLET-LME wrote: > + for (i = 0; i < ARRAY_SIZE(stpmic1_regulator_cfgs); i++) { > + /* Parse DT & find regulators to register */ > + init_data = stpmic1_regulators_matches[i].init_data; > + if (init_data) >

Re: [PATCH v4 4/8] regulator: stpmic1: add stpmic1 regulator driver

2018-10-19 Thread Mark Brown
On Thu, Oct 18, 2018 at 09:02:12AM +, Pascal PAILLET-LME wrote: > + for (i = 0; i < ARRAY_SIZE(stpmic1_regulator_cfgs); i++) { > + /* Parse DT & find regulators to register */ > + init_data = stpmic1_regulators_matches[i].init_data; > + if (init_data) >

[PATCH v4 4/8] regulator: stpmic1: add stpmic1 regulator driver

2018-10-18 Thread Pascal PAILLET-LME
From: pascal paillet The stpmic1 PMIC embeds several regulators and switches with different capabilities. Signed-off-by: pascal paillet --- changes in v4: nothing drivers/regulator/Kconfig | 12 + drivers/regulator/Makefile| 1 +

[PATCH v4 4/8] regulator: stpmic1: add stpmic1 regulator driver

2018-10-18 Thread Pascal PAILLET-LME
From: pascal paillet The stpmic1 PMIC embeds several regulators and switches with different capabilities. Signed-off-by: pascal paillet --- changes in v4: nothing drivers/regulator/Kconfig | 12 + drivers/regulator/Makefile| 1 +