Re: [PATCH v4 5/5] dma-buf/sync_file: only enable fence signalling on poll()

2016-08-04 Thread Chris Wilson
On Thu, Aug 04, 2016 at 06:18:53PM -0300, Gustavo Padovan wrote: > 2016-08-03 Chris Wilson : > > > On Tue, Jul 12, 2016 at 03:08:45PM -0300, Gustavo Padovan wrote: > > > From: Gustavo Padovan > > > > > > Signalling doesn't need to be

Re: [PATCH v4 5/5] dma-buf/sync_file: only enable fence signalling on poll()

2016-08-04 Thread Chris Wilson
On Thu, Aug 04, 2016 at 06:18:53PM -0300, Gustavo Padovan wrote: > 2016-08-03 Chris Wilson : > > > On Tue, Jul 12, 2016 at 03:08:45PM -0300, Gustavo Padovan wrote: > > > From: Gustavo Padovan > > > > > > Signalling doesn't need to be enabled at sync_file creation, it is only > > > required if

Re: [PATCH v4 5/5] dma-buf/sync_file: only enable fence signalling on poll()

2016-08-04 Thread Gustavo Padovan
2016-08-03 Chris Wilson : > On Tue, Jul 12, 2016 at 03:08:45PM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Signalling doesn't need to be enabled at sync_file creation, it is only > > required if userspace waiting the

Re: [PATCH v4 5/5] dma-buf/sync_file: only enable fence signalling on poll()

2016-08-04 Thread Gustavo Padovan
2016-08-03 Chris Wilson : > On Tue, Jul 12, 2016 at 03:08:45PM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Signalling doesn't need to be enabled at sync_file creation, it is only > > required if userspace waiting the fence to signal through poll(). > > > > Thus we delay

Re: [PATCH v4 5/5] dma-buf/sync_file: only enable fence signalling on poll()

2016-08-03 Thread Chris Wilson
On Tue, Jul 12, 2016 at 03:08:45PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Signalling doesn't need to be enabled at sync_file creation, it is only > required if userspace waiting the fence to signal through poll(). > > Thus we delay

Re: [PATCH v4 5/5] dma-buf/sync_file: only enable fence signalling on poll()

2016-08-03 Thread Chris Wilson
On Tue, Jul 12, 2016 at 03:08:45PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Signalling doesn't need to be enabled at sync_file creation, it is only > required if userspace waiting the fence to signal through poll(). > > Thus we delay fence_add_callback() until poll is called.

Re: [PATCH v4 5/5] dma-buf/sync_file: only enable fence signalling on poll()

2016-07-14 Thread John Harrison
On 12/07/2016 19:08, Gustavo Padovan wrote: ... +++ b/include/linux/sync_file.h @@ -28,6 +28,7 @@ * @name: name of sync_file. Useful for debugging * @sync_file_list: membership in global file list * @wq: wait queue for fence signaling + * @enabled:

Re: [PATCH v4 5/5] dma-buf/sync_file: only enable fence signalling on poll()

2016-07-14 Thread John Harrison
On 12/07/2016 19:08, Gustavo Padovan wrote: ... +++ b/include/linux/sync_file.h @@ -28,6 +28,7 @@ * @name: name of sync_file. Useful for debugging * @sync_file_list: membership in global file list * @wq: wait queue for fence signaling + * @enabled:

[PATCH v4 5/5] dma-buf/sync_file: only enable fence signalling on poll()

2016-07-12 Thread Gustavo Padovan
From: Gustavo Padovan Signalling doesn't need to be enabled at sync_file creation, it is only required if userspace waiting the fence to signal through poll(). Thus we delay fence_add_callback() until poll is called. It only adds the callback the first time

[PATCH v4 5/5] dma-buf/sync_file: only enable fence signalling on poll()

2016-07-12 Thread Gustavo Padovan
From: Gustavo Padovan Signalling doesn't need to be enabled at sync_file creation, it is only required if userspace waiting the fence to signal through poll(). Thus we delay fence_add_callback() until poll is called. It only adds the callback the first time poll() is called. This avoid