Re: [PATCH v4 5/5] x86: initialize secondary CPU only if master CPU will wait for it

2014-05-05 Thread Igor Mammedov
On Fri, 02 May 2014 08:52:22 -0600 Toshi Kani wrote: > On Fri, 2014-05-02 at 10:21 +0200, Igor Mammedov wrote: > > On Thu, 01 May 2014 17:11:56 -0600 > > Toshi Kani wrote: > : > > > When 10s passed, the master could set a new flag, ex. > > > cpu_callout_error_mask, which wait_for_master_cpu()

Re: [PATCH v4 5/5] x86: initialize secondary CPU only if master CPU will wait for it

2014-05-05 Thread Igor Mammedov
On Fri, 02 May 2014 08:52:22 -0600 Toshi Kani toshi.k...@hp.com wrote: On Fri, 2014-05-02 at 10:21 +0200, Igor Mammedov wrote: On Thu, 01 May 2014 17:11:56 -0600 Toshi Kani toshi.k...@hp.com wrote: : When 10s passed, the master could set a new flag, ex. cpu_callout_error_mask, which

Re: [PATCH v4 5/5] x86: initialize secondary CPU only if master CPU will wait for it

2014-05-02 Thread Toshi Kani
On Fri, 2014-05-02 at 10:21 +0200, Igor Mammedov wrote: > On Thu, 01 May 2014 17:11:56 -0600 > Toshi Kani wrote: : > > When 10s passed, the master could set a new flag, ex. > > cpu_callout_error_mask, which wait_for_master_cpu() checks and call > > play_dead() when it is set. This avoids AP to

Re: [PATCH v4 5/5] x86: initialize secondary CPU only if master CPU will wait for it

2014-05-02 Thread Igor Mammedov
On Thu, 01 May 2014 17:11:56 -0600 Toshi Kani wrote: > On Mon, 2014-04-14 at 17:11 +0200, Igor Mammedov wrote: > > Hang is observed on virtual machines during CPU hotplug, > > especially in big guests with many CPUs. (It reproducible > > more often if host is over-committed). > > > > It happens

Re: [PATCH v4 5/5] x86: initialize secondary CPU only if master CPU will wait for it

2014-05-02 Thread Igor Mammedov
On Thu, 01 May 2014 17:11:56 -0600 Toshi Kani toshi.k...@hp.com wrote: On Mon, 2014-04-14 at 17:11 +0200, Igor Mammedov wrote: Hang is observed on virtual machines during CPU hotplug, especially in big guests with many CPUs. (It reproducible more often if host is over-committed). It

Re: [PATCH v4 5/5] x86: initialize secondary CPU only if master CPU will wait for it

2014-05-02 Thread Toshi Kani
On Fri, 2014-05-02 at 10:21 +0200, Igor Mammedov wrote: On Thu, 01 May 2014 17:11:56 -0600 Toshi Kani toshi.k...@hp.com wrote: : When 10s passed, the master could set a new flag, ex. cpu_callout_error_mask, which wait_for_master_cpu() checks and call play_dead() when it is set. This

Re: [PATCH v4 5/5] x86: initialize secondary CPU only if master CPU will wait for it

2014-05-01 Thread Toshi Kani
On Mon, 2014-04-14 at 17:11 +0200, Igor Mammedov wrote: > Hang is observed on virtual machines during CPU hotplug, > especially in big guests with many CPUs. (It reproducible > more often if host is over-committed). > > It happens because master CPU gives up waiting on > secondary CPU and allows

Re: [PATCH v4 5/5] x86: initialize secondary CPU only if master CPU will wait for it

2014-05-01 Thread Toshi Kani
On Mon, 2014-04-14 at 17:11 +0200, Igor Mammedov wrote: Hang is observed on virtual machines during CPU hotplug, especially in big guests with many CPUs. (It reproducible more often if host is over-committed). It happens because master CPU gives up waiting on secondary CPU and allows it to

[PATCH v4 5/5] x86: initialize secondary CPU only if master CPU will wait for it

2014-04-14 Thread Igor Mammedov
Hang is observed on virtual machines during CPU hotplug, especially in big guests with many CPUs. (It reproducible more often if host is over-committed). It happens because master CPU gives up waiting on secondary CPU and allows it to run wild. As result AP causes locking or crashing system. For

[PATCH v4 5/5] x86: initialize secondary CPU only if master CPU will wait for it

2014-04-14 Thread Igor Mammedov
Hang is observed on virtual machines during CPU hotplug, especially in big guests with many CPUs. (It reproducible more often if host is over-committed). It happens because master CPU gives up waiting on secondary CPU and allows it to run wild. As result AP causes locking or crashing system. For