Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-05-21 Thread Lee Jones
> >> >> > + soc { > >> >> > + sbc_serial0: serial@953 { > >> >> > + status = "okay"; > >> >> > + }; > >> >> > >> >> You might want to consider reference-based syntax here instead, so you > >> >> don't have to mimic the hierarchy. That'd

Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-05-21 Thread Lee Jones
+ soc { + sbc_serial0: serial@953 { + status = okay; + }; You might want to consider reference-based syntax here instead, so you don't have to mimic the hierarchy. That'd be (at the root level of the file,

Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-05-20 Thread Olof Johansson
On Tue, May 20, 2014 at 12:43 AM, Lee Jones wrote: >> >> > + soc { >> >> > + sbc_serial0: serial@953 { >> >> > + status = "okay"; >> >> > + }; >> >> >> >> You might want to consider reference-based syntax here instead, so you >> >> don't

Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-05-20 Thread Maxime Coquelin
Hi Olof, On 05/20/2014 08:18 AM, Olof Johansson wrote: Hi, Just a quick drive-by review since I was looking at these patches in the pull request you sent. Thanks for the review. I will send a new series taking your comments into account, except the one about reference-based syntax.

Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-05-20 Thread Maxime Coquelin
On 05/20/2014 09:43 AM, Lee Jones wrote: + soc { + sbc_serial0: serial@953 { + status = "okay"; + }; You might want to consider reference-based syntax here instead, so you don't have to mimic the hierarchy. That'd be (at the root

Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-05-20 Thread Lee Jones
> >> > + soc { > >> > + sbc_serial0: serial@953 { > >> > + status = "okay"; > >> > + }; > >> > >> You might want to consider reference-based syntax here instead, so you > >> don't have to mimic the hierarchy. That'd be (at the root level

Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-05-20 Thread Olof Johansson
On Tue, May 20, 2014 at 12:20 AM, Lee Jones wrote: >> > B2120 HDK is the reference board for STiH407 SoC. >> > It has the following characteristics: >> > - 1GB DDR3 >> > - 8GB eMMC / SD-Card slot >> > - 32MB NOR Flash >> > - 1 x Gbit Ethernet >> > - 1 x USB 3.0 port >> > - 1 x Mini-PCIe >>

Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-05-20 Thread Lee Jones
> > B2120 HDK is the reference board for STiH407 SoC. > > It has the following characteristics: > > - 1GB DDR3 > > - 8GB eMMC / SD-Card slot > > - 32MB NOR Flash > > - 1 x Gbit Ethernet > > - 1 x USB 3.0 port > > - 1 x Mini-PCIe > > - 1 x SATA > > - 1 x HDMI output > > - 1 x HDMI input >

Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-05-20 Thread Olof Johansson
Hi, Just a quick drive-by review since I was looking at these patches in the pull request you sent. On Wed, Mar 12, 2014 at 1:50 AM, Maxime COQUELIN wrote: > B2120 HDK is the reference board for STiH407 SoC. > It has the following characteristics: > - 1GB DDR3 > - 8GB eMMC / SD-Card slot >

Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-05-20 Thread Olof Johansson
Hi, Just a quick drive-by review since I was looking at these patches in the pull request you sent. On Wed, Mar 12, 2014 at 1:50 AM, Maxime COQUELIN maxime.coque...@st.com wrote: B2120 HDK is the reference board for STiH407 SoC. It has the following characteristics: - 1GB DDR3 - 8GB eMMC

Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-05-20 Thread Lee Jones
B2120 HDK is the reference board for STiH407 SoC. It has the following characteristics: - 1GB DDR3 - 8GB eMMC / SD-Card slot - 32MB NOR Flash - 1 x Gbit Ethernet - 1 x USB 3.0 port - 1 x Mini-PCIe - 1 x SATA - 1 x HDMI output - 1 x HDMI input - 1 x SPDIF This

Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-05-20 Thread Olof Johansson
On Tue, May 20, 2014 at 12:20 AM, Lee Jones lee.jo...@linaro.org wrote: B2120 HDK is the reference board for STiH407 SoC. It has the following characteristics: - 1GB DDR3 - 8GB eMMC / SD-Card slot - 32MB NOR Flash - 1 x Gbit Ethernet - 1 x USB 3.0 port - 1 x Mini-PCIe - 1

Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-05-20 Thread Lee Jones
+ soc { + sbc_serial0: serial@953 { + status = okay; + }; You might want to consider reference-based syntax here instead, so you don't have to mimic the hierarchy. That'd be (at the root level of the file, below this

Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-05-20 Thread Maxime Coquelin
On 05/20/2014 09:43 AM, Lee Jones wrote: + soc { + sbc_serial0: serial@953 { + status = okay; + }; You might want to consider reference-based syntax here instead, so you don't have to mimic the hierarchy. That'd be (at the root

Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-05-20 Thread Maxime Coquelin
Hi Olof, On 05/20/2014 08:18 AM, Olof Johansson wrote: Hi, Just a quick drive-by review since I was looking at these patches in the pull request you sent. Thanks for the review. I will send a new series taking your comments into account, except the one about reference-based syntax.

Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-05-20 Thread Olof Johansson
On Tue, May 20, 2014 at 12:43 AM, Lee Jones lee.jo...@linaro.org wrote: + soc { + sbc_serial0: serial@953 { + status = okay; + }; You might want to consider reference-based syntax here instead, so you don't have to mimic

Re: [STLinux Kernel] [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-05-13 Thread Patrice Chotard
On 03/12/2014 09:50 AM, Maxime COQUELIN wrote: B2120 HDK is the reference board for STiH407 SoC. It has the following characteristics: - 1GB DDR3 - 8GB eMMC / SD-Card slot - 32MB NOR Flash - 1 x Gbit Ethernet - 1 x USB 3.0 port - 1 x Mini-PCIe - 1 x SATA - 1 x HDMI output - 1

Re: [STLinux Kernel] [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-05-13 Thread Patrice Chotard
On 03/12/2014 09:50 AM, Maxime COQUELIN wrote: B2120 HDK is the reference board for STiH407 SoC. It has the following characteristics: - 1GB DDR3 - 8GB eMMC / SD-Card slot - 32MB NOR Flash - 1 x Gbit Ethernet - 1 x USB 3.0 port - 1 x Mini-PCIe - 1 x SATA - 1 x HDMI output - 1

[PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-03-12 Thread Maxime COQUELIN
B2120 HDK is the reference board for STiH407 SoC. It has the following characteristics: - 1GB DDR3 - 8GB eMMC / SD-Card slot - 32MB NOR Flash - 1 x Gbit Ethernet - 1 x USB 3.0 port - 1 x Mini-PCIe - 1 x SATA - 1 x HDMI output - 1 x HDMI input - 1 x SPDIF This patch only introduces basic

[PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

2014-03-12 Thread Maxime COQUELIN
B2120 HDK is the reference board for STiH407 SoC. It has the following characteristics: - 1GB DDR3 - 8GB eMMC / SD-Card slot - 32MB NOR Flash - 1 x Gbit Ethernet - 1 x USB 3.0 port - 1 x Mini-PCIe - 1 x SATA - 1 x HDMI output - 1 x HDMI input - 1 x SPDIF This patch only introduces basic