Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

On Thu, 2018-03-01 at 16:22 +0200, Or Idgar wrote: > + > +static const struct acpi_device_id vmgenid_ids[] = { > + {"QEMUVGID", 0}, > + {"", 0}, > +}; > + This is wrong. You're supposed to match on the _CID "VM_Gen_Counter". smime.p7s Description: S/MIME cryptographic signature

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

On Thu, 2018-03-01 at 16:22 +0200, Or Idgar wrote: > + > +static const struct acpi_device_id vmgenid_ids[] = { > + {"QEMUVGID", 0}, > + {"", 0}, > +}; > + This is wrong. You're supposed to match on the _CID "VM_Gen_Counter". smime.p7s Description: S/MIME cryptographic signature

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

On Thu, Mar 15, 2018 at 02:19:59PM +0100, Greg KH wrote: > On Wed, Mar 14, 2018 at 09:25:17PM +0200, Michael S. Tsirkin wrote: > > On Wed, Mar 14, 2018 at 07:25:36PM +0100, Greg KH wrote: > > > On Tue, Mar 13, 2018 at 07:40:51PM +0200, Michael S. Tsirkin wrote: > > > > I think it's a good idea to

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

On Thu, Mar 15, 2018 at 02:19:59PM +0100, Greg KH wrote: > On Wed, Mar 14, 2018 at 09:25:17PM +0200, Michael S. Tsirkin wrote: > > On Wed, Mar 14, 2018 at 07:25:36PM +0100, Greg KH wrote: > > > On Tue, Mar 13, 2018 at 07:40:51PM +0200, Michael S. Tsirkin wrote: > > > > I think it's a good idea to

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

On Thu, Mar 15, 2018 at 10:00:30AM +0200, Gal Hammer wrote: > On Tue, Mar 13, 2018 at 7:40 PM, Michael S. Tsirkin wrote: > > Thanks for the patch! Yet something to improve (see below): > > Thanks for the review. > > > On Thu, Mar 01, 2018 at 04:22:15PM +0200, Or Idgar wrote: >

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

On Thu, Mar 15, 2018 at 10:00:30AM +0200, Gal Hammer wrote: > On Tue, Mar 13, 2018 at 7:40 PM, Michael S. Tsirkin wrote: > > Thanks for the patch! Yet something to improve (see below): > > Thanks for the review. > > > On Thu, Mar 01, 2018 at 04:22:15PM +0200, Or Idgar wrote: > >> From: Or Idgar

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

On Wed, Mar 14, 2018 at 09:25:17PM +0200, Michael S. Tsirkin wrote: > On Wed, Mar 14, 2018 at 07:25:36PM +0100, Greg KH wrote: > > On Tue, Mar 13, 2018 at 07:40:51PM +0200, Michael S. Tsirkin wrote: > > > I think it's a good idea to use sysfs for this. However, > > > there are a couple of missing

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

On Wed, Mar 14, 2018 at 09:25:17PM +0200, Michael S. Tsirkin wrote: > On Wed, Mar 14, 2018 at 07:25:36PM +0100, Greg KH wrote: > > On Tue, Mar 13, 2018 at 07:40:51PM +0200, Michael S. Tsirkin wrote: > > > I think it's a good idea to use sysfs for this. However, > > > there are a couple of missing

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

On Thu, Mar 15, 2018 at 08:57:05AM +0200, Gal Hammer wrote: > On Wed, Mar 14, 2018 at 9:25 PM, Michael S. Tsirkin wrote: > > On Wed, Mar 14, 2018 at 07:25:36PM +0100, Greg KH wrote: > >> On Tue, Mar 13, 2018 at 07:40:51PM +0200, Michael S. Tsirkin wrote: > >> > I think it's a

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

On Thu, Mar 15, 2018 at 08:57:05AM +0200, Gal Hammer wrote: > On Wed, Mar 14, 2018 at 9:25 PM, Michael S. Tsirkin wrote: > > On Wed, Mar 14, 2018 at 07:25:36PM +0100, Greg KH wrote: > >> On Tue, Mar 13, 2018 at 07:40:51PM +0200, Michael S. Tsirkin wrote: > >> > I think it's a good idea to use

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

On Tue, Mar 13, 2018 at 7:40 PM, Michael S. Tsirkin wrote: > Thanks for the patch! Yet something to improve (see below): Thanks for the review. > On Thu, Mar 01, 2018 at 04:22:15PM +0200, Or Idgar wrote: >> From: Or Idgar > > I see addresses at gmail,

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

On Tue, Mar 13, 2018 at 7:40 PM, Michael S. Tsirkin wrote: > Thanks for the patch! Yet something to improve (see below): Thanks for the review. > On Thu, Mar 01, 2018 at 04:22:15PM +0200, Or Idgar wrote: >> From: Or Idgar > > I see addresses at gmail, virtualoco and redhat.com At this point I

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

On Wed, Mar 14, 2018 at 9:25 PM, Michael S. Tsirkin wrote: > On Wed, Mar 14, 2018 at 07:25:36PM +0100, Greg KH wrote: >> On Tue, Mar 13, 2018 at 07:40:51PM +0200, Michael S. Tsirkin wrote: >> > I think it's a good idea to use sysfs for this. However, >> > there are a couple of

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

On Wed, Mar 14, 2018 at 9:25 PM, Michael S. Tsirkin wrote: > On Wed, Mar 14, 2018 at 07:25:36PM +0100, Greg KH wrote: >> On Tue, Mar 13, 2018 at 07:40:51PM +0200, Michael S. Tsirkin wrote: >> > I think it's a good idea to use sysfs for this. However, >> > there are a couple of missing interfaces

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

On Wed, Mar 14, 2018 at 07:25:36PM +0100, Greg KH wrote: > On Tue, Mar 13, 2018 at 07:40:51PM +0200, Michael S. Tsirkin wrote: > > I think it's a good idea to use sysfs for this. However, > > there are a couple of missing interfaces here: > > > > 1. Userspace needs a way to know when this value

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

On Wed, Mar 14, 2018 at 07:25:36PM +0100, Greg KH wrote: > On Tue, Mar 13, 2018 at 07:40:51PM +0200, Michael S. Tsirkin wrote: > > I think it's a good idea to use sysfs for this. However, > > there are a couple of missing interfaces here: > > > > 1. Userspace needs a way to know when this value

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

On Tue, Mar 13, 2018 at 07:40:51PM +0200, Michael S. Tsirkin wrote: > I think it's a good idea to use sysfs for this. However, > there are a couple of missing interfaces here: > > 1. Userspace needs a way to know when this value changes. >I see no change notifications here and that does not

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

On Tue, Mar 13, 2018 at 07:40:51PM +0200, Michael S. Tsirkin wrote: > I think it's a good idea to use sysfs for this. However, > there are a couple of missing interfaces here: > > 1. Userspace needs a way to know when this value changes. >I see no change notifications here and that does not

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

Thanks for the patch! Yet something to improve (see below): On Thu, Mar 01, 2018 at 04:22:15PM +0200, Or Idgar wrote: > From: Or Idgar I see addresses at gmail, virtualoco and redhat.com At this point I don't really know which address to use to contact you :) All of them?

Re: [PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

Thanks for the patch! Yet something to improve (see below): On Thu, Mar 01, 2018 at 04:22:15PM +0200, Or Idgar wrote: > From: Or Idgar I see addresses at gmail, virtualoco and redhat.com At this point I don't really know which address to use to contact you :) All of them? Also, I think it's a

[PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

From: Or Idgar This patch is a driver which expose the Virtual Machine Generation ID via sysfs. The ID is a UUID value used to differentiate between virtual machines. The VM-Generation ID is a feature defined by Microsoft (paper: http://go.microsoft.com/fwlink/?LinkId=260709)

[PATCH v5] drivers/misc: vm_gen_counter: initial driver implementation

From: Or Idgar This patch is a driver which expose the Virtual Machine Generation ID via sysfs. The ID is a UUID value used to differentiate between virtual machines. The VM-Generation ID is a feature defined by Microsoft (paper: http://go.microsoft.com/fwlink/?LinkId=260709) and supported by