Re: [PATCH v5] mm: cma: support sysfs

2021-03-23 Thread Minchan Kim
On Wed, Mar 24, 2021 at 04:34:34AM +, Matthew Wilcox wrote: > On Tue, Mar 23, 2021 at 08:31:31PM -0700, Minchan Kim wrote: > > On Wed, Mar 24, 2021 at 03:02:24AM +, Matthew Wilcox wrote: > > > On Tue, Mar 23, 2021 at 12:50:50PM -0700, Minchan Kim wrote: > > > > + /* the number of CMA

Re: [PATCH v5] mm: cma: support sysfs

2021-03-23 Thread Matthew Wilcox
On Tue, Mar 23, 2021 at 08:31:31PM -0700, Minchan Kim wrote: > On Wed, Mar 24, 2021 at 03:02:24AM +, Matthew Wilcox wrote: > > On Tue, Mar 23, 2021 at 12:50:50PM -0700, Minchan Kim wrote: > > > + /* the number of CMA page successful allocations */ > > > + atomic64_t nr_pages_succeeded; > > >

Re: [PATCH v5] mm: cma: support sysfs

2021-03-23 Thread Minchan Kim
On Wed, Mar 24, 2021 at 03:02:24AM +, Matthew Wilcox wrote: > On Tue, Mar 23, 2021 at 12:50:50PM -0700, Minchan Kim wrote: > > + /* the number of CMA page successful allocations */ > > + atomic64_t nr_pages_succeeded; > > > +void cma_sysfs_alloc_pages_count(struct cma *cma, size_t count)

Re: [PATCH v5] mm: cma: support sysfs

2021-03-23 Thread Matthew Wilcox
On Tue, Mar 23, 2021 at 12:50:50PM -0700, Minchan Kim wrote: > + /* the number of CMA page successful allocations */ > + atomic64_t nr_pages_succeeded; > +void cma_sysfs_alloc_pages_count(struct cma *cma, size_t count) > +{ > + atomic64_add(count, >nr_pages_succeeded); > +} I don't

Re: [PATCH v5] mm: cma: support sysfs

2021-03-23 Thread Minchan Kim
On Wed, Mar 24, 2021 at 12:44:06AM +0300, Dmitry Osipenko wrote: > 23.03.2021 22:50, Minchan Kim пишет: > > +#ifdef CONFIG_CMA_SYSFS > > +void cma_sysfs_alloc_pages_count(struct cma *cma, size_t count); > > +void cma_sysfs_fail_pages_count(struct cma *cma, size_t count); > > I'd also rename

Re: [PATCH v5] mm: cma: support sysfs

2021-03-23 Thread Dmitry Osipenko
23.03.2021 22:50, Minchan Kim пишет: > +#ifdef CONFIG_CMA_SYSFS > +void cma_sysfs_alloc_pages_count(struct cma *cma, size_t count); > +void cma_sysfs_fail_pages_count(struct cma *cma, size_t count); I'd also rename cma_sysfs_alloc_pages_count to cma_sysfs_account_success_pages and

Re: [PATCH v5] mm: cma: support sysfs

2021-03-23 Thread Dmitry Osipenko
24.03.2021 00:19, Dmitry Osipenko пишет: >> +if (!kobj) >> +goto out; >> + >> +kobj->cma = cma; >> +cma->kobj = kobj; >> +if (kobject_init_and_add(>kobj->kobj, _ktype, >> + cma_kobj_root, "%s",

Re: [PATCH v5] mm: cma: support sysfs

2021-03-23 Thread Dmitry Osipenko
23.03.2021 22:50, Minchan Kim пишет: > Since CMA is getting used more widely, it's more important to > keep monitoring CMA statistics for system health since it's > directly related to user experience. > > This patch introduces sysfs statistics for CMA, in order to provide > some basic monitoring

[PATCH v5] mm: cma: support sysfs

2021-03-23 Thread Minchan Kim
Since CMA is getting used more widely, it's more important to keep monitoring CMA statistics for system health since it's directly related to user experience. This patch introduces sysfs statistics for CMA, in order to provide some basic monitoring of the CMA allocator. * the number of CMA page