Re: [PATCH v5] perf annotate: Fix sample events lost in stdio mode

2021-03-17 Thread Yang Jihong
Hello, On 2021/3/16 21:07, Arnaldo Carvalho de Melo wrote: Em Tue, Mar 16, 2021 at 10:17:59AM +0800, Yang Jihong escreveu: In hist__find_annotations function, since different hist_entry may point to same symbol, we free notes->src to signal already processed this symbol in stdio mode; when

Re: [PATCH v5] perf annotate: Fix sample events lost in stdio mode

2021-03-16 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 16, 2021 at 10:17:59AM +0800, Yang Jihong escreveu: > In hist__find_annotations function, since different hist_entry may point to > same > symbol, we free notes->src to signal already processed this symbol in stdio > mode; > when annotate, entry will skipped if notes->src is NULL to

[PATCH v5] perf annotate: Fix sample events lost in stdio mode

2021-03-15 Thread Yang Jihong
In hist__find_annotations function, since different hist_entry may point to same symbol, we free notes->src to signal already processed this symbol in stdio mode; when annotate, entry will skipped if notes->src is NULL to avoid repeated output. However, there is a problem, for example, run the