Re: [PATCH v5] sched/deadline: fix earliest_dl.next logic

2015-12-03 Thread Wanpeng Li
2015-12-03 16:37 GMT+08:00 Luca Abeni : > Hi, > > On 12/03/2015 03:25 AM, Wanpeng Li wrote: > [...] >>> >>> @@ -202,16 +197,18 @@ static void dequeue_pushable_dl_task(struct rq *rq, >>> struct task_struct *p) >>> >>> next_node = rb_next(>pushable_dl_tasks);

Re: [PATCH v5] sched/deadline: fix earliest_dl.next logic

2015-12-03 Thread Juri Lelli
Hi, On 03/12/15 16:59, Wanpeng Li wrote: > 2015-12-03 16:37 GMT+08:00 Luca Abeni : > > Hi, > > > > On 12/03/2015 03:25 AM, Wanpeng Li wrote: > > [...] > >>> > >>> @@ -202,16 +197,18 @@ static void dequeue_pushable_dl_task(struct rq *rq, > >>> struct task_struct *p) > >>> >

Re: [PATCH v5] sched/deadline: fix earliest_dl.next logic

2015-12-03 Thread Luca Abeni
Hi, On 12/03/2015 03:25 AM, Wanpeng Li wrote: [...] @@ -202,16 +197,18 @@ static void dequeue_pushable_dl_task(struct rq *rq, struct task_struct *p) next_node = rb_next(>pushable_dl_tasks); dl_rq->pushable_dl_tasks_leftmost = next_node; + if

[PATCH v5] sched/deadline: fix earliest_dl.next logic

2015-12-02 Thread Wanpeng Li
earliest_dl.next should cache deadline of the earliest ready task that is also enqueued in the pushable rbtree, as pull algorithm uses this information to find candidates for migration: if the earliest_dl.next deadline of source rq is earlier than the earliest_dl.curr deadline of destination rq,

Re: [PATCH v5] sched/deadline: fix earliest_dl.next logic

2015-12-02 Thread Juri Lelli
Hi, On 02/12/15 19:47, Wanpeng Li wrote: > earliest_dl.next should cache deadline of the earliest ready task that > is also enqueued in the pushable rbtree, as pull algorithm uses this > information to find candidates for migration: if the earliest_dl.next > deadline of source rq is earlier than

Re: [PATCH v5] sched/deadline: fix earliest_dl.next logic

2015-12-02 Thread Luca Abeni
Hi, On 12/02/2015 02:33 PM, Wanpeng Li wrote: [...] We updated leftmost above, can't we simply use that path for this thing below? Do you mean something like below? @@ -195,6 +195,9 @@ static void dequeue_pushable_dl_task(struct rq *rq, struct task_struct *p) next_node =

Re: [PATCH v5] sched/deadline: fix earliest_dl.next logic

2015-12-02 Thread Wanpeng Li
2015-12-02 22:08 GMT+08:00 Luca Abeni : > Hi, > > On 12/02/2015 02:33 PM, Wanpeng Li wrote: > [...] >>> >>> We updated leftmost above, can't we simply use that path for this thing >>> below? >> >> >> Do you mean something like below? >> >> @@ -195,6 +195,9 @@ static void