RE: [PATCH v5] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-13 Thread Phil Edworthy
Hi Laurent, On 09 July 2015 02:03, Laurent wrote: > Hi Phil, > > On Wednesday 08 July 2015 08:08:27 Phil Edworthy wrote: > > On 08 July 2015 00:08, Laurent wrote: > > > On Tuesday 07 July 2015 12:52:43 Phil Edworthy wrote: > > > > These changes allow a PHY driver to trigger a VBUS interrupt and

RE: [PATCH v5] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-13 Thread Phil Edworthy
Hi Laurent, On 09 July 2015 02:03, Laurent wrote: Hi Phil, On Wednesday 08 July 2015 08:08:27 Phil Edworthy wrote: On 08 July 2015 00:08, Laurent wrote: On Tuesday 07 July 2015 12:52:43 Phil Edworthy wrote: These changes allow a PHY driver to trigger a VBUS interrupt and to

Re: [PATCH v5] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-08 Thread Laurent Pinchart
Hi Phil, On Wednesday 08 July 2015 08:08:27 Phil Edworthy wrote: > On 08 July 2015 00:08, Laurent wrote: > > On Tuesday 07 July 2015 12:52:43 Phil Edworthy wrote: > > > These changes allow a PHY driver to trigger a VBUS interrupt and > > > to provide the value of VBUS. > > > > > > Signed-off-by:

RE: [PATCH v5] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-08 Thread Phil Edworthy
Hi Laurent, On 08 July 2015 00:08, Laurent wrote: > Hi Phil, > > Thank you for the patch. > > On Tuesday 07 July 2015 12:52:43 Phil Edworthy wrote: > > These changes allow a PHY driver to trigger a VBUS interrupt and > > to provide the value of VBUS. > > > > Signed-off-by: Phil Edworthy > >

RE: [PATCH v5] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-08 Thread Phil Edworthy
Hi Laurent, On 08 July 2015 00:08, Laurent wrote: Hi Phil, Thank you for the patch. On Tuesday 07 July 2015 12:52:43 Phil Edworthy wrote: These changes allow a PHY driver to trigger a VBUS interrupt and to provide the value of VBUS. Signed-off-by: Phil Edworthy

Re: [PATCH v5] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-08 Thread Laurent Pinchart
Hi Phil, On Wednesday 08 July 2015 08:08:27 Phil Edworthy wrote: On 08 July 2015 00:08, Laurent wrote: On Tuesday 07 July 2015 12:52:43 Phil Edworthy wrote: These changes allow a PHY driver to trigger a VBUS interrupt and to provide the value of VBUS. Signed-off-by: Phil Edworthy

Re: [PATCH v5] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-07 Thread Laurent Pinchart
Hi Phil, Thank you for the patch. On Tuesday 07 July 2015 12:52:43 Phil Edworthy wrote: > These changes allow a PHY driver to trigger a VBUS interrupt and > to provide the value of VBUS. > > Signed-off-by: Phil Edworthy This looks much better to me. I just have two comments, please see below.

[PATCH v5] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-07 Thread Phil Edworthy
These changes allow a PHY driver to trigger a VBUS interrupt and to provide the value of VBUS. Signed-off-by: Phil Edworthy --- v5: - Avoid race when vbus_is_indirect may or may not be read before the phy has called vbus_session. In doing so, the changes have also been isolated to

Re: [PATCH v5] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-07 Thread Laurent Pinchart
Hi Phil, Thank you for the patch. On Tuesday 07 July 2015 12:52:43 Phil Edworthy wrote: These changes allow a PHY driver to trigger a VBUS interrupt and to provide the value of VBUS. Signed-off-by: Phil Edworthy phil.edwor...@renesas.com This looks much better to me. I just have two

[PATCH v5] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-07 Thread Phil Edworthy
These changes allow a PHY driver to trigger a VBUS interrupt and to provide the value of VBUS. Signed-off-by: Phil Edworthy phil.edwor...@renesas.com --- v5: - Avoid race when vbus_is_indirect may or may not be read before the phy has called vbus_session. In doing so, the changes have