Re: [PATCH v5 0/4] iio: Add support for rotation from north

2014-07-15 Thread Reyad Attiyat
Hey Srinivas Thanks for looking into this for me! I'll fix it up and resubmit soon. On Tue, Jul 15, 2014 at 4:39 PM, Srinivas Pandruvada wrote: > Hi, > > Since you have only one attribute, it is working for you. > There is a dereference error in *channels. > > Check the attached diff, which

Re: [PATCH v5 0/4] iio: Add support for rotation from north

2014-07-15 Thread Srinivas Pandruvada
Hi, Since you have only one attribute, it is working for you. There is a dereference error in *channels. Check the attached diff, which will fix this. Thanks, Srinivas On 07/09/2014 03:12 PM, Reyad Attiyat wrote: Hey Srinivas, I did look into the panic you sent. I wasn't sure exactly what

Re: [PATCH v5 0/4] iio: Add support for rotation from north

2014-07-15 Thread Jonathan Cameron
On 09/07/14 23:12, Reyad Attiyat wrote: Hey Srinivas, I did look into the panic you sent. I wasn't sure exactly what caused the NULL pointer. I tested it with out applying the last rotation from north patch, so no hid usages are found, my device only has rotation_from_north, and

Re: [PATCH v5 0/4] iio: Add support for rotation from north

2014-07-15 Thread Jonathan Cameron
On 09/07/14 23:12, Reyad Attiyat wrote: Hey Srinivas, I did look into the panic you sent. I wasn't sure exactly what caused the NULL pointer. I tested it with out applying the last rotation from north patch, so no hid usages are found, my device only has rotation_from_north, and

Re: [PATCH v5 0/4] iio: Add support for rotation from north

2014-07-15 Thread Srinivas Pandruvada
Hi, Since you have only one attribute, it is working for you. There is a dereference error in *channels. Check the attached diff, which will fix this. Thanks, Srinivas On 07/09/2014 03:12 PM, Reyad Attiyat wrote: Hey Srinivas, I did look into the panic you sent. I wasn't sure exactly what

Re: [PATCH v5 0/4] iio: Add support for rotation from north

2014-07-15 Thread Reyad Attiyat
Hey Srinivas Thanks for looking into this for me! I'll fix it up and resubmit soon. On Tue, Jul 15, 2014 at 4:39 PM, Srinivas Pandruvada srinivas.pandruv...@linux.intel.com wrote: Hi, Since you have only one attribute, it is working for you. There is a dereference error in *channels. Check

Re: [PATCH v5 0/4] iio: Add support for rotation from north

2014-07-09 Thread Reyad Attiyat
Hey Srinivas, I did look into the panic you sent. I wasn't sure exactly what caused the NULL pointer. I tested it with out applying the last rotation from north patch, so no hid usages are found, my device only has rotation_from_north, and hid_parse_report() would return -EINVAL. I added another

Re: [PATCH v5 0/4] iio: Add support for rotation from north

2014-07-09 Thread Srinivas Pandruvada
On 07/09/2014 12:30 PM, Reyad Attiyat wrote: This series of patches modifies magn-3d driver to handle the rotation from north usage. This is done by scanning the report and then building the iio arrays (vals and channels) dynamically. Changes from V4 I use the address field of struct

[PATCH v5 0/4] iio: Add support for rotation from north

2014-07-09 Thread Reyad Attiyat
This series of patches modifies magn-3d driver to handle the rotation from north usage. This is done by scanning the report and then building the iio arrays (vals and channels) dynamically. Changes from V4 I use the address field of struct iio_chan_spec to hold the array index of the usage

[PATCH v5 0/4] iio: Add support for rotation from north

2014-07-09 Thread Reyad Attiyat
This series of patches modifies magn-3d driver to handle the rotation from north usage. This is done by scanning the report and then building the iio arrays (vals and channels) dynamically. Changes from V4 I use the address field of struct iio_chan_spec to hold the array index of the usage

Re: [PATCH v5 0/4] iio: Add support for rotation from north

2014-07-09 Thread Srinivas Pandruvada
On 07/09/2014 12:30 PM, Reyad Attiyat wrote: This series of patches modifies magn-3d driver to handle the rotation from north usage. This is done by scanning the report and then building the iio arrays (vals and channels) dynamically. Changes from V4 I use the address field of struct

Re: [PATCH v5 0/4] iio: Add support for rotation from north

2014-07-09 Thread Reyad Attiyat
Hey Srinivas, I did look into the panic you sent. I wasn't sure exactly what caused the NULL pointer. I tested it with out applying the last rotation from north patch, so no hid usages are found, my device only has rotation_from_north, and hid_parse_report() would return -EINVAL. I added another