Re: [PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288
Hi Guillaume,
Am Mittwoch, 3. Mai 2017, 10:56:24 CEST schrieb Guillaume Tucker:
> The ARM Mali Midgard GPU kernel driver is only available
> out-of-tree and is not going to be merged in its current form.
> However, it would be useful to have its device tree bindings
> merged. In particular, this would enable distributions to create
> working driver packages (dkms...) without having to patch the
> kernel.
>
> The bindings for the earlier Mali Utgard GPU family have already
> been merged, so this is essentially the same scenario but for
> newer GPUs (Mali-T604 ~ Mali-T880).
>
> This series of patches first imports the bindings from the latest
> driver release with some clean-up then adds a gpu node for the
> rk3288 SoC. This was successfully tested on Radxa Rock2 Square,
> Firefly, Veyron Minnie and Jerry boards using Mali kernel driver
> r16p0 and r12p0 user-space binary.
as nobody complained anymore, I've applied all patches for 4.13
with the following small changes:
- patch2: node name to
gpu_opp_table: gpu-opp-table
from the original
gpu_opp_table: opp_table0
- patches3-5: moved {} to its alphabetical correct position
(below and above )
Heiko
Re: [PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288
Hi Guillaume,
Am Mittwoch, 3. Mai 2017, 10:56:24 CEST schrieb Guillaume Tucker:
> The ARM Mali Midgard GPU kernel driver is only available
> out-of-tree and is not going to be merged in its current form.
> However, it would be useful to have its device tree bindings
> merged. In particular, this would enable distributions to create
> working driver packages (dkms...) without having to patch the
> kernel.
>
> The bindings for the earlier Mali Utgard GPU family have already
> been merged, so this is essentially the same scenario but for
> newer GPUs (Mali-T604 ~ Mali-T880).
>
> This series of patches first imports the bindings from the latest
> driver release with some clean-up then adds a gpu node for the
> rk3288 SoC. This was successfully tested on Radxa Rock2 Square,
> Firefly, Veyron Minnie and Jerry boards using Mali kernel driver
> r16p0 and r12p0 user-space binary.
as nobody complained anymore, I've applied all patches for 4.13
with the following small changes:
- patch2: node name to
gpu_opp_table: gpu-opp-table
from the original
gpu_opp_table: opp_table0
- patches3-5: moved {} to its alphabetical correct position
(below and above )
Heiko
Re: [PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288
On 2017-05-10 11:10 +0100, Guillaume Tucker wrote: > > On a side note, it would be fantastic to get all this available > in Debian packages :) There are prototype debian packages here: https://git.linaro.org/people/wookey/mali/mali-dkms.git/ https://git.linaro.org/people/wookey/mali/mali-drivers.git/ Which I'm very happy to get feedback on if people try them with guillaume's DTB patches. Quite hacky at the moment, but I want to prove they work at all before tarting up the packaging. Wookey -- Principal hats: Linaro, Debian, Wookware, ARM http://wookware.org/ signature.asc Description: Digital signature
Re: [PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288
On 2017-05-10 11:10 +0100, Guillaume Tucker wrote: > > On a side note, it would be fantastic to get all this available > in Debian packages :) There are prototype debian packages here: https://git.linaro.org/people/wookey/mali/mali-dkms.git/ https://git.linaro.org/people/wookey/mali/mali-drivers.git/ Which I'm very happy to get feedback on if people try them with guillaume's DTB patches. Quite hacky at the moment, but I want to prove they work at all before tarting up the packaging. Wookey -- Principal hats: Linaro, Debian, Wookware, ARM http://wookware.org/ signature.asc Description: Digital signature
Re: [PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288
Am Mittwoch, 10. Mai 2017, 11:10:55 CEST schrieb Guillaume Tucker: > Hi Randi, > > On 09/05/17 08:45, Randy Li wrote: > > On 05/09/2017 03:40 PM, Guillaume Tucker wrote: > >> On 09/05/17 02:16, Randy Li wrote: > >>> On 05/09/2017 12:27 AM, Heiko Stübner wrote: > Am Mittwoch, 3. Mai 2017, 10:56:24 CEST schrieb Guillaume Tucker: > > The ARM Mali Midgard GPU kernel driver is only available > > out-of-tree and is not going to be merged in its current form. > > However, it would be useful to have its device tree bindings > > merged. In particular, this would enable distributions to create > > working driver packages (dkms...) without having to patch the > > kernel. > > > > The bindings for the earlier Mali Utgard GPU family have already > > been merged, so this is essentially the same scenario but for > > newer GPUs (Mali-T604 ~ Mali-T880). > > > > This series of patches first imports the bindings from the latest > > driver release with some clean-up then adds a gpu node for the > > rk3288 SoC. This was successfully tested on Radxa Rock2 Square, > > Firefly, Veyron Minnie and Jerry boards using Mali kernel driver > > r16p0 and r12p0 user-space binary. > >>> > >>> I won't suggest such combine. We meet some problems at mali 400 serial. > >>> I would suggest the kernel version would match the user library. > >> > >> Well, I can test it again with r12p0 kernel driver (out-of-tree) > >> if you want. The user-space driver checks the version of the > >> kernel driver and gives up if it's not compatible. With Midgard, > >> there's a range of versions that maintain kernel/userspace > >> compatibility unlike Utgard and older Midgard releases where they > >> had to exactly match. Again, if there was a mismatch then the > >> user-space would fail to initialise and report an error. > > > > Anyway, could you verify the mali userspace library r13p0? > > The latest user-space binary available from developer.arm.com for > rk3288 is 12p0. Maybe Rockchip could make some new binaries > available to the public? > > > Rockchip would use this version to offer the support of X11, wayland and > > gbm. > Sounds great, although windowing systems are quite far away from > GPU device tree bindings so I don't think this is too relevant > for this current patch series. > > On a side note, it would be fantastic to get all this available > in Debian packages :) > > >>> Also please notice there is rk3288w, the hardware version becomes r1p0. > >> > >> Sounds like a new SoC? Does rk3288w affect rk3288 in any way? > > > > It is not a new SoC, just a new version of rk3288. It fixes a various of > > the chip bug of the rk3288. > I see. I don't have access to any rk3288w platform but if you do > then I guess it would be nice if you could test these patches on > it :) Also I'm not sure if all rk3288 device trees changes must > be tested on rk3288w, and this SoC is not mentioned anywhere in > the kernel (as far as I can tell). > > Is there anything you think should block these current patches > which only claim to support rk3288 from being merged? >From what I've read on #linux-rockchip: rk3288w have some differences: USB HOST : add ohci, fix ehci bug GPU : update rev VOP, video codec, rga : some bug fix hdmi : HDCP2.2 So from, yes a new gpu-revision, but that shouldn't affect this series. >From the above I guess the hooks into the rest of the soc haven't changed so rk3288-mali should still be enough and the driver normally can detect and handle revision differences. And if there are really severe changes appearing later on _and_ we actually get special support for the rk3288w in the kernel (googling for rk3288w mentions it in conjunction with windows 10) there is nothing speaking against having a rk3288w-mali compatible at that time. Heiko > > >> Unless it's a special case, it seems to me that any new SoC with > >> a Midgard GPU would need an extra vendor compatible string in the > >> binding documentation and maybe a separate gpu dt node. > >> > The actual devicetree parts are all Rockchip-specific, so I guess I'll > just > pick up the whole series, including the binding doc, after the merge > window if nobody complains before that :-) > >> > >> Thanks! > > Guillaume > > > P.S. kernel branch with a Mali driver I used for testing: > https://git.collabora.com/cgit/user/gtucker/linux.git/log/?h=linux-4.11-mali > -dt-rk3288
Re: [PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288
Am Mittwoch, 10. Mai 2017, 11:10:55 CEST schrieb Guillaume Tucker: > Hi Randi, > > On 09/05/17 08:45, Randy Li wrote: > > On 05/09/2017 03:40 PM, Guillaume Tucker wrote: > >> On 09/05/17 02:16, Randy Li wrote: > >>> On 05/09/2017 12:27 AM, Heiko Stübner wrote: > Am Mittwoch, 3. Mai 2017, 10:56:24 CEST schrieb Guillaume Tucker: > > The ARM Mali Midgard GPU kernel driver is only available > > out-of-tree and is not going to be merged in its current form. > > However, it would be useful to have its device tree bindings > > merged. In particular, this would enable distributions to create > > working driver packages (dkms...) without having to patch the > > kernel. > > > > The bindings for the earlier Mali Utgard GPU family have already > > been merged, so this is essentially the same scenario but for > > newer GPUs (Mali-T604 ~ Mali-T880). > > > > This series of patches first imports the bindings from the latest > > driver release with some clean-up then adds a gpu node for the > > rk3288 SoC. This was successfully tested on Radxa Rock2 Square, > > Firefly, Veyron Minnie and Jerry boards using Mali kernel driver > > r16p0 and r12p0 user-space binary. > >>> > >>> I won't suggest such combine. We meet some problems at mali 400 serial. > >>> I would suggest the kernel version would match the user library. > >> > >> Well, I can test it again with r12p0 kernel driver (out-of-tree) > >> if you want. The user-space driver checks the version of the > >> kernel driver and gives up if it's not compatible. With Midgard, > >> there's a range of versions that maintain kernel/userspace > >> compatibility unlike Utgard and older Midgard releases where they > >> had to exactly match. Again, if there was a mismatch then the > >> user-space would fail to initialise and report an error. > > > > Anyway, could you verify the mali userspace library r13p0? > > The latest user-space binary available from developer.arm.com for > rk3288 is 12p0. Maybe Rockchip could make some new binaries > available to the public? > > > Rockchip would use this version to offer the support of X11, wayland and > > gbm. > Sounds great, although windowing systems are quite far away from > GPU device tree bindings so I don't think this is too relevant > for this current patch series. > > On a side note, it would be fantastic to get all this available > in Debian packages :) > > >>> Also please notice there is rk3288w, the hardware version becomes r1p0. > >> > >> Sounds like a new SoC? Does rk3288w affect rk3288 in any way? > > > > It is not a new SoC, just a new version of rk3288. It fixes a various of > > the chip bug of the rk3288. > I see. I don't have access to any rk3288w platform but if you do > then I guess it would be nice if you could test these patches on > it :) Also I'm not sure if all rk3288 device trees changes must > be tested on rk3288w, and this SoC is not mentioned anywhere in > the kernel (as far as I can tell). > > Is there anything you think should block these current patches > which only claim to support rk3288 from being merged? >From what I've read on #linux-rockchip: rk3288w have some differences: USB HOST : add ohci, fix ehci bug GPU : update rev VOP, video codec, rga : some bug fix hdmi : HDCP2.2 So from, yes a new gpu-revision, but that shouldn't affect this series. >From the above I guess the hooks into the rest of the soc haven't changed so rk3288-mali should still be enough and the driver normally can detect and handle revision differences. And if there are really severe changes appearing later on _and_ we actually get special support for the rk3288w in the kernel (googling for rk3288w mentions it in conjunction with windows 10) there is nothing speaking against having a rk3288w-mali compatible at that time. Heiko > > >> Unless it's a special case, it seems to me that any new SoC with > >> a Midgard GPU would need an extra vendor compatible string in the > >> binding documentation and maybe a separate gpu dt node. > >> > The actual devicetree parts are all Rockchip-specific, so I guess I'll > just > pick up the whole series, including the binding doc, after the merge > window if nobody complains before that :-) > >> > >> Thanks! > > Guillaume > > > P.S. kernel branch with a Mali driver I used for testing: > https://git.collabora.com/cgit/user/gtucker/linux.git/log/?h=linux-4.11-mali > -dt-rk3288
Re: [PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288
Hi Randi, On 09/05/17 08:45, Randy Li wrote: On 05/09/2017 03:40 PM, Guillaume Tucker wrote: On 09/05/17 02:16, Randy Li wrote: On 05/09/2017 12:27 AM, Heiko Stübner wrote: Am Mittwoch, 3. Mai 2017, 10:56:24 CEST schrieb Guillaume Tucker: The ARM Mali Midgard GPU kernel driver is only available out-of-tree and is not going to be merged in its current form. However, it would be useful to have its device tree bindings merged. In particular, this would enable distributions to create working driver packages (dkms...) without having to patch the kernel. The bindings for the earlier Mali Utgard GPU family have already been merged, so this is essentially the same scenario but for newer GPUs (Mali-T604 ~ Mali-T880). This series of patches first imports the bindings from the latest driver release with some clean-up then adds a gpu node for the rk3288 SoC. This was successfully tested on Radxa Rock2 Square, Firefly, Veyron Minnie and Jerry boards using Mali kernel driver r16p0 and r12p0 user-space binary. I won't suggest such combine. We meet some problems at mali 400 serial. I would suggest the kernel version would match the user library. Well, I can test it again with r12p0 kernel driver (out-of-tree) if you want. The user-space driver checks the version of the kernel driver and gives up if it's not compatible. With Midgard, there's a range of versions that maintain kernel/userspace compatibility unlike Utgard and older Midgard releases where they had to exactly match. Again, if there was a mismatch then the user-space would fail to initialise and report an error. Anyway, could you verify the mali userspace library r13p0? The latest user-space binary available from developer.arm.com for rk3288 is 12p0. Maybe Rockchip could make some new binaries available to the public? Rockchip would use this version to offer the support of X11, wayland and gbm. Sounds great, although windowing systems are quite far away from GPU device tree bindings so I don't think this is too relevant for this current patch series. On a side note, it would be fantastic to get all this available in Debian packages :) Also please notice there is rk3288w, the hardware version becomes r1p0. Sounds like a new SoC? Does rk3288w affect rk3288 in any way? It is not a new SoC, just a new version of rk3288. It fixes a various of the chip bug of the rk3288. I see. I don't have access to any rk3288w platform but if you do then I guess it would be nice if you could test these patches on it :) Also I'm not sure if all rk3288 device trees changes must be tested on rk3288w, and this SoC is not mentioned anywhere in the kernel (as far as I can tell). Is there anything you think should block these current patches which only claim to support rk3288 from being merged? Unless it's a special case, it seems to me that any new SoC with a Midgard GPU would need an extra vendor compatible string in the binding documentation and maybe a separate gpu dt node. The actual devicetree parts are all Rockchip-specific, so I guess I'll just pick up the whole series, including the binding doc, after the merge window if nobody complains before that :-) Thanks! Guillaume P.S. kernel branch with a Mali driver I used for testing: https://git.collabora.com/cgit/user/gtucker/linux.git/log/?h=linux-4.11-mali-dt-rk3288
Re: [PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288
Hi Randi, On 09/05/17 08:45, Randy Li wrote: On 05/09/2017 03:40 PM, Guillaume Tucker wrote: On 09/05/17 02:16, Randy Li wrote: On 05/09/2017 12:27 AM, Heiko Stübner wrote: Am Mittwoch, 3. Mai 2017, 10:56:24 CEST schrieb Guillaume Tucker: The ARM Mali Midgard GPU kernel driver is only available out-of-tree and is not going to be merged in its current form. However, it would be useful to have its device tree bindings merged. In particular, this would enable distributions to create working driver packages (dkms...) without having to patch the kernel. The bindings for the earlier Mali Utgard GPU family have already been merged, so this is essentially the same scenario but for newer GPUs (Mali-T604 ~ Mali-T880). This series of patches first imports the bindings from the latest driver release with some clean-up then adds a gpu node for the rk3288 SoC. This was successfully tested on Radxa Rock2 Square, Firefly, Veyron Minnie and Jerry boards using Mali kernel driver r16p0 and r12p0 user-space binary. I won't suggest such combine. We meet some problems at mali 400 serial. I would suggest the kernel version would match the user library. Well, I can test it again with r12p0 kernel driver (out-of-tree) if you want. The user-space driver checks the version of the kernel driver and gives up if it's not compatible. With Midgard, there's a range of versions that maintain kernel/userspace compatibility unlike Utgard and older Midgard releases where they had to exactly match. Again, if there was a mismatch then the user-space would fail to initialise and report an error. Anyway, could you verify the mali userspace library r13p0? The latest user-space binary available from developer.arm.com for rk3288 is 12p0. Maybe Rockchip could make some new binaries available to the public? Rockchip would use this version to offer the support of X11, wayland and gbm. Sounds great, although windowing systems are quite far away from GPU device tree bindings so I don't think this is too relevant for this current patch series. On a side note, it would be fantastic to get all this available in Debian packages :) Also please notice there is rk3288w, the hardware version becomes r1p0. Sounds like a new SoC? Does rk3288w affect rk3288 in any way? It is not a new SoC, just a new version of rk3288. It fixes a various of the chip bug of the rk3288. I see. I don't have access to any rk3288w platform but if you do then I guess it would be nice if you could test these patches on it :) Also I'm not sure if all rk3288 device trees changes must be tested on rk3288w, and this SoC is not mentioned anywhere in the kernel (as far as I can tell). Is there anything you think should block these current patches which only claim to support rk3288 from being merged? Unless it's a special case, it seems to me that any new SoC with a Midgard GPU would need an extra vendor compatible string in the binding documentation and maybe a separate gpu dt node. The actual devicetree parts are all Rockchip-specific, so I guess I'll just pick up the whole series, including the binding doc, after the merge window if nobody complains before that :-) Thanks! Guillaume P.S. kernel branch with a Mali driver I used for testing: https://git.collabora.com/cgit/user/gtucker/linux.git/log/?h=linux-4.11-mali-dt-rk3288
Re: [PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288
On 05/09/2017 03:40 PM, Guillaume Tucker wrote: On 09/05/17 02:16, Randy Li wrote: On 05/09/2017 12:27 AM, Heiko Stübner wrote: Am Mittwoch, 3. Mai 2017, 10:56:24 CEST schrieb Guillaume Tucker: The ARM Mali Midgard GPU kernel driver is only available out-of-tree and is not going to be merged in its current form. However, it would be useful to have its device tree bindings merged. In particular, this would enable distributions to create working driver packages (dkms...) without having to patch the kernel. The bindings for the earlier Mali Utgard GPU family have already been merged, so this is essentially the same scenario but for newer GPUs (Mali-T604 ~ Mali-T880). This series of patches first imports the bindings from the latest driver release with some clean-up then adds a gpu node for the rk3288 SoC. This was successfully tested on Radxa Rock2 Square, Firefly, Veyron Minnie and Jerry boards using Mali kernel driver r16p0 and r12p0 user-space binary. I won't suggest such combine. We meet some problems at mali 400 serial. I would suggest the kernel version would match the user library. Well, I can test it again with r12p0 kernel driver (out-of-tree) if you want. The user-space driver checks the version of the kernel driver and gives up if it's not compatible. With Midgard, there's a range of versions that maintain kernel/userspace compatibility unlike Utgard and older Midgard releases where they had to exactly match. Again, if there was a mismatch then the user-space would fail to initialise and report an error. Anyway, could you verify the mali userspace library r13p0? Rockchip would use this version to offer the support of X11, wayland and gbm. Also please notice there is rk3288w, the hardware version becomes r1p0. Sounds like a new SoC? Does rk3288w affect rk3288 in any way? It is not a new SoC, just a new version of rk3288. It fixes a various of the chip bug of the rk3288. Unless it's a special case, it seems to me that any new SoC with a Midgard GPU would need an extra vendor compatible string in the binding documentation and maybe a separate gpu dt node. The actual devicetree parts are all Rockchip-specific, so I guess I'll just pick up the whole series, including the binding doc, after the merge window if nobody complains before that :-) Thanks! Guillaume -- Randy Li
Re: [PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288
On 05/09/2017 03:40 PM, Guillaume Tucker wrote: On 09/05/17 02:16, Randy Li wrote: On 05/09/2017 12:27 AM, Heiko Stübner wrote: Am Mittwoch, 3. Mai 2017, 10:56:24 CEST schrieb Guillaume Tucker: The ARM Mali Midgard GPU kernel driver is only available out-of-tree and is not going to be merged in its current form. However, it would be useful to have its device tree bindings merged. In particular, this would enable distributions to create working driver packages (dkms...) without having to patch the kernel. The bindings for the earlier Mali Utgard GPU family have already been merged, so this is essentially the same scenario but for newer GPUs (Mali-T604 ~ Mali-T880). This series of patches first imports the bindings from the latest driver release with some clean-up then adds a gpu node for the rk3288 SoC. This was successfully tested on Radxa Rock2 Square, Firefly, Veyron Minnie and Jerry boards using Mali kernel driver r16p0 and r12p0 user-space binary. I won't suggest such combine. We meet some problems at mali 400 serial. I would suggest the kernel version would match the user library. Well, I can test it again with r12p0 kernel driver (out-of-tree) if you want. The user-space driver checks the version of the kernel driver and gives up if it's not compatible. With Midgard, there's a range of versions that maintain kernel/userspace compatibility unlike Utgard and older Midgard releases where they had to exactly match. Again, if there was a mismatch then the user-space would fail to initialise and report an error. Anyway, could you verify the mali userspace library r13p0? Rockchip would use this version to offer the support of X11, wayland and gbm. Also please notice there is rk3288w, the hardware version becomes r1p0. Sounds like a new SoC? Does rk3288w affect rk3288 in any way? It is not a new SoC, just a new version of rk3288. It fixes a various of the chip bug of the rk3288. Unless it's a special case, it seems to me that any new SoC with a Midgard GPU would need an extra vendor compatible string in the binding documentation and maybe a separate gpu dt node. The actual devicetree parts are all Rockchip-specific, so I guess I'll just pick up the whole series, including the binding doc, after the merge window if nobody complains before that :-) Thanks! Guillaume -- Randy Li
Re: [PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288
On 09/05/17 02:16, Randy Li wrote: On 05/09/2017 12:27 AM, Heiko Stübner wrote: Am Mittwoch, 3. Mai 2017, 10:56:24 CEST schrieb Guillaume Tucker: The ARM Mali Midgard GPU kernel driver is only available out-of-tree and is not going to be merged in its current form. However, it would be useful to have its device tree bindings merged. In particular, this would enable distributions to create working driver packages (dkms...) without having to patch the kernel. The bindings for the earlier Mali Utgard GPU family have already been merged, so this is essentially the same scenario but for newer GPUs (Mali-T604 ~ Mali-T880). This series of patches first imports the bindings from the latest driver release with some clean-up then adds a gpu node for the rk3288 SoC. This was successfully tested on Radxa Rock2 Square, Firefly, Veyron Minnie and Jerry boards using Mali kernel driver r16p0 and r12p0 user-space binary. I won't suggest such combine. We meet some problems at mali 400 serial. I would suggest the kernel version would match the user library. Well, I can test it again with r12p0 kernel driver (out-of-tree) if you want. The user-space driver checks the version of the kernel driver and gives up if it's not compatible. With Midgard, there's a range of versions that maintain kernel/userspace compatibility unlike Utgard and older Midgard releases where they had to exactly match. Again, if there was a mismatch then the user-space would fail to initialise and report an error. Also please notice there is rk3288w, the hardware version becomes r1p0. Sounds like a new SoC? Does rk3288w affect rk3288 in any way? Unless it's a special case, it seems to me that any new SoC with a Midgard GPU would need an extra vendor compatible string in the binding documentation and maybe a separate gpu dt node. The actual devicetree parts are all Rockchip-specific, so I guess I'll just pick up the whole series, including the binding doc, after the merge window if nobody complains before that :-) Thanks! Guillaume
Re: [PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288
On 09/05/17 02:16, Randy Li wrote: On 05/09/2017 12:27 AM, Heiko Stübner wrote: Am Mittwoch, 3. Mai 2017, 10:56:24 CEST schrieb Guillaume Tucker: The ARM Mali Midgard GPU kernel driver is only available out-of-tree and is not going to be merged in its current form. However, it would be useful to have its device tree bindings merged. In particular, this would enable distributions to create working driver packages (dkms...) without having to patch the kernel. The bindings for the earlier Mali Utgard GPU family have already been merged, so this is essentially the same scenario but for newer GPUs (Mali-T604 ~ Mali-T880). This series of patches first imports the bindings from the latest driver release with some clean-up then adds a gpu node for the rk3288 SoC. This was successfully tested on Radxa Rock2 Square, Firefly, Veyron Minnie and Jerry boards using Mali kernel driver r16p0 and r12p0 user-space binary. I won't suggest such combine. We meet some problems at mali 400 serial. I would suggest the kernel version would match the user library. Well, I can test it again with r12p0 kernel driver (out-of-tree) if you want. The user-space driver checks the version of the kernel driver and gives up if it's not compatible. With Midgard, there's a range of versions that maintain kernel/userspace compatibility unlike Utgard and older Midgard releases where they had to exactly match. Again, if there was a mismatch then the user-space would fail to initialise and report an error. Also please notice there is rk3288w, the hardware version becomes r1p0. Sounds like a new SoC? Does rk3288w affect rk3288 in any way? Unless it's a special case, it seems to me that any new SoC with a Midgard GPU would need an extra vendor compatible string in the binding documentation and maybe a separate gpu dt node. The actual devicetree parts are all Rockchip-specific, so I guess I'll just pick up the whole series, including the binding doc, after the merge window if nobody complains before that :-) Thanks! Guillaume
Re: [PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288
On 05/09/2017 12:27 AM, Heiko Stübner wrote: Am Mittwoch, 3. Mai 2017, 10:56:24 CEST schrieb Guillaume Tucker: The ARM Mali Midgard GPU kernel driver is only available out-of-tree and is not going to be merged in its current form. However, it would be useful to have its device tree bindings merged. In particular, this would enable distributions to create working driver packages (dkms...) without having to patch the kernel. The bindings for the earlier Mali Utgard GPU family have already been merged, so this is essentially the same scenario but for newer GPUs (Mali-T604 ~ Mali-T880). This series of patches first imports the bindings from the latest driver release with some clean-up then adds a gpu node for the rk3288 SoC. This was successfully tested on Radxa Rock2 Square, Firefly, Veyron Minnie and Jerry boards using Mali kernel driver r16p0 and r12p0 user-space binary. I won't suggest such combine. We meet some problems at mali 400 serial. I would suggest the kernel version would match the user library. Also please notice there is rk3288w, the hardware version becomes r1p0. The actual devicetree parts are all Rockchip-specific, so I guess I'll just pick up the whole series, including the binding doc, after the merge window if nobody complains before that :-) Heiko ___ Linux-rockchip mailing list linux-rockc...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip -- Randy Li
Re: [PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288
On 05/09/2017 12:27 AM, Heiko Stübner wrote: Am Mittwoch, 3. Mai 2017, 10:56:24 CEST schrieb Guillaume Tucker: The ARM Mali Midgard GPU kernel driver is only available out-of-tree and is not going to be merged in its current form. However, it would be useful to have its device tree bindings merged. In particular, this would enable distributions to create working driver packages (dkms...) without having to patch the kernel. The bindings for the earlier Mali Utgard GPU family have already been merged, so this is essentially the same scenario but for newer GPUs (Mali-T604 ~ Mali-T880). This series of patches first imports the bindings from the latest driver release with some clean-up then adds a gpu node for the rk3288 SoC. This was successfully tested on Radxa Rock2 Square, Firefly, Veyron Minnie and Jerry boards using Mali kernel driver r16p0 and r12p0 user-space binary. I won't suggest such combine. We meet some problems at mali 400 serial. I would suggest the kernel version would match the user library. Also please notice there is rk3288w, the hardware version becomes r1p0. The actual devicetree parts are all Rockchip-specific, so I guess I'll just pick up the whole series, including the binding doc, after the merge window if nobody complains before that :-) Heiko ___ Linux-rockchip mailing list linux-rockc...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip -- Randy Li
Re: [PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288
Am Mittwoch, 3. Mai 2017, 10:56:24 CEST schrieb Guillaume Tucker: > The ARM Mali Midgard GPU kernel driver is only available > out-of-tree and is not going to be merged in its current form. > However, it would be useful to have its device tree bindings > merged. In particular, this would enable distributions to create > working driver packages (dkms...) without having to patch the > kernel. > > The bindings for the earlier Mali Utgard GPU family have already > been merged, so this is essentially the same scenario but for > newer GPUs (Mali-T604 ~ Mali-T880). > > This series of patches first imports the bindings from the latest > driver release with some clean-up then adds a gpu node for the > rk3288 SoC. This was successfully tested on Radxa Rock2 Square, > Firefly, Veyron Minnie and Jerry boards using Mali kernel driver > r16p0 and r12p0 user-space binary. The actual devicetree parts are all Rockchip-specific, so I guess I'll just pick up the whole series, including the binding doc, after the merge window if nobody complains before that :-) Heiko
Re: [PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288
Am Mittwoch, 3. Mai 2017, 10:56:24 CEST schrieb Guillaume Tucker: > The ARM Mali Midgard GPU kernel driver is only available > out-of-tree and is not going to be merged in its current form. > However, it would be useful to have its device tree bindings > merged. In particular, this would enable distributions to create > working driver packages (dkms...) without having to patch the > kernel. > > The bindings for the earlier Mali Utgard GPU family have already > been merged, so this is essentially the same scenario but for > newer GPUs (Mali-T604 ~ Mali-T880). > > This series of patches first imports the bindings from the latest > driver release with some clean-up then adds a gpu node for the > rk3288 SoC. This was successfully tested on Radxa Rock2 Square, > Firefly, Veyron Minnie and Jerry boards using Mali kernel driver > r16p0 and r12p0 user-space binary. The actual devicetree parts are all Rockchip-specific, so I guess I'll just pick up the whole series, including the binding doc, after the merge window if nobody complains before that :-) Heiko
[PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288
The ARM Mali Midgard GPU kernel driver is only available out-of-tree and is not going to be merged in its current form. However, it would be useful to have its device tree bindings merged. In particular, this would enable distributions to create working driver packages (dkms...) without having to patch the kernel. The bindings for the earlier Mali Utgard GPU family have already been merged, so this is essentially the same scenario but for newer GPUs (Mali-T604 ~ Mali-T880). This series of patches first imports the bindings from the latest driver release with some clean-up then adds a gpu node for the rk3288 SoC. This was successfully tested on Radxa Rock2 Square, Firefly, Veyron Minnie and Jerry boards using Mali kernel driver r16p0 and r12p0 user-space binary. Changes since v1: - enabled gpu on rk3288-veyron boards Changes since v2: - removed "clk-names" property and "clk_mali" name - converted values of "interrupt-names" property to lower-case: "job", "mmu" and "gpu" - replaced dt compatible strings with list of all Midgard GPU variants and optional vendors - cleaned up gpu node example Changes since v3: - add "rockchip,rk3288-mali" vendor compatible string - move gpu node at the right location in rk3288.dtsi - use operating-points-v2 in documentation and rk3288.dtsi Changes since v4: - removed wildcards (mali-t60x, -t62x) - vendor compatible strings are not optional any more - example updated accordingly, based on rk3288 Enric Balletbo i Serra (1): ARM: dts: rockchip: enable ARM Mali GPU on rk3288-veyron Guillaume Tucker (4): dt-bindings: gpu: add bindings for the ARM Mali Midgard GPU ARM: dts: rockchip: add ARM Mali GPU node for rk3288 ARM: dts: rockchip: enable ARM Mali GPU on rk3288-rock2-som ARM: dts: rockchip: enable ARM Mali GPU on rk3288-firefly .../devicetree/bindings/gpu/arm,mali-midgard.txt | 86 ++ arch/arm/boot/dts/rk3288-firefly.dtsi | 5 ++ arch/arm/boot/dts/rk3288-rock2-som.dtsi| 5 ++ arch/arm/boot/dts/rk3288-veyron.dtsi | 5 ++ arch/arm/boot/dts/rk3288.dtsi | 43 +++ 5 files changed, 144 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt -- 2.11.0
[PATCH v5 0/5] Add ARM Mali Midgard device tree bindings and gpu node for rk3288
The ARM Mali Midgard GPU kernel driver is only available out-of-tree and is not going to be merged in its current form. However, it would be useful to have its device tree bindings merged. In particular, this would enable distributions to create working driver packages (dkms...) without having to patch the kernel. The bindings for the earlier Mali Utgard GPU family have already been merged, so this is essentially the same scenario but for newer GPUs (Mali-T604 ~ Mali-T880). This series of patches first imports the bindings from the latest driver release with some clean-up then adds a gpu node for the rk3288 SoC. This was successfully tested on Radxa Rock2 Square, Firefly, Veyron Minnie and Jerry boards using Mali kernel driver r16p0 and r12p0 user-space binary. Changes since v1: - enabled gpu on rk3288-veyron boards Changes since v2: - removed "clk-names" property and "clk_mali" name - converted values of "interrupt-names" property to lower-case: "job", "mmu" and "gpu" - replaced dt compatible strings with list of all Midgard GPU variants and optional vendors - cleaned up gpu node example Changes since v3: - add "rockchip,rk3288-mali" vendor compatible string - move gpu node at the right location in rk3288.dtsi - use operating-points-v2 in documentation and rk3288.dtsi Changes since v4: - removed wildcards (mali-t60x, -t62x) - vendor compatible strings are not optional any more - example updated accordingly, based on rk3288 Enric Balletbo i Serra (1): ARM: dts: rockchip: enable ARM Mali GPU on rk3288-veyron Guillaume Tucker (4): dt-bindings: gpu: add bindings for the ARM Mali Midgard GPU ARM: dts: rockchip: add ARM Mali GPU node for rk3288 ARM: dts: rockchip: enable ARM Mali GPU on rk3288-rock2-som ARM: dts: rockchip: enable ARM Mali GPU on rk3288-firefly .../devicetree/bindings/gpu/arm,mali-midgard.txt | 86 ++ arch/arm/boot/dts/rk3288-firefly.dtsi | 5 ++ arch/arm/boot/dts/rk3288-rock2-som.dtsi| 5 ++ arch/arm/boot/dts/rk3288-veyron.dtsi | 5 ++ arch/arm/boot/dts/rk3288.dtsi | 43 +++ 5 files changed, 144 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt -- 2.11.0
