Re: [PATCH v5 0/8] KVM/ARM: Some vgic fixes and init sequence KVM selftests
Hi Marc, On 4/5/21 12:12 PM, Marc Zyngier wrote: > Hi Eric, > > On Sun, 04 Apr 2021 18:22:35 +0100, > Eric Auger wrote: >> >> While writting vgic v3 init sequence KVM selftests I noticed some >> relatively minor issues. This was also the opportunity to try to >> fix the issue laterly reported by Zenghui, related to the RDIST_TYPER >> last bit emulation. The final patch is a first batch of VGIC init >> sequence selftests. Of course they can be augmented with a lot more >> register access tests, but let's try to move forward incrementally ... >> >> Best Regards >> >> Eric >> >> This series can be found at: >> https://github.com/eauger/linux/tree/vgic_kvmselftests_v5 >> >> History: >> v4 -> v5: >> - rewrite the last bit detection according to Marc's >> interpretation of the spec and modify the kvm selftests >> accordingly > > Have you dropped v4's patch #1? It did seem to fix an actual issue, > didn't it? Hum no that was not my intent :-( Resending ... Eric > > Thanks, > > M. >
Re: [PATCH v5 0/8] KVM/ARM: Some vgic fixes and init sequence KVM selftests
Hi Eric, On Sun, 04 Apr 2021 18:22:35 +0100, Eric Auger wrote: > > While writting vgic v3 init sequence KVM selftests I noticed some > relatively minor issues. This was also the opportunity to try to > fix the issue laterly reported by Zenghui, related to the RDIST_TYPER > last bit emulation. The final patch is a first batch of VGIC init > sequence selftests. Of course they can be augmented with a lot more > register access tests, but let's try to move forward incrementally ... > > Best Regards > > Eric > > This series can be found at: > https://github.com/eauger/linux/tree/vgic_kvmselftests_v5 > > History: > v4 -> v5: > - rewrite the last bit detection according to Marc's > interpretation of the spec and modify the kvm selftests > accordingly Have you dropped v4's patch #1? It did seem to fix an actual issue, didn't it? Thanks, M. -- Without deviation from the norm, progress is not possible.
[PATCH v5 0/8] KVM/ARM: Some vgic fixes and init sequence KVM selftests
While writting vgic v3 init sequence KVM selftests I noticed some relatively minor issues. This was also the opportunity to try to fix the issue laterly reported by Zenghui, related to the RDIST_TYPER last bit emulation. The final patch is a first batch of VGIC init sequence selftests. Of course they can be augmented with a lot more register access tests, but let's try to move forward incrementally ... Best Regards Eric This series can be found at: https://github.com/eauger/linux/tree/vgic_kvmselftests_v5 History: v4 -> v5: - rewrite the last bit detection according to Marc's interpretation of the spec and modify the kvm selftests accordingly v3 -> v4: - take into account Drew's comment on the kvm selftests. No change to the KVM related patches compared to v3 v2 ->v3: - reworked last bit read accessor to handle contiguous redist regions and rdist not registered in ascending order - removed [PATCH 5/9] KVM: arm: move has_run_once after the map_resources v1 -> v2: - Took into account all comments from Marc and Alexandru's except the has_run_once still after the map_resources (this would oblige me to revisit in depth the selftests) Eric Auger (8): KVM: arm64: Fix KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION read KVM: arm64: vgic-v3: Fix error handling in vgic_v3_set_redist_base() KVM: arm/arm64: vgic: Reset base address on kvm_vgic_dist_destroy() docs: kvm: devices/arm-vgic-v3: enhance KVM_DEV_ARM_VGIC_CTRL_INIT doc KVM: arm64: Simplify argument passing to vgic_uaccess_[read|write] kvm: arm64: vgic-v3: Introduce vgic_v3_free_redist_region() KVM: arm64: vgic-v3: Expose GICR_TYPER.Last for userspace KVM: selftests: aarch64/vgic-v3 init sequence tests .../virt/kvm/devices/arm-vgic-v3.rst | 2 +- arch/arm64/kvm/vgic/vgic-init.c | 12 +- arch/arm64/kvm/vgic/vgic-kvm-device.c | 3 + arch/arm64/kvm/vgic/vgic-mmio-v3.c| 79 ++- arch/arm64/kvm/vgic/vgic-mmio.c | 10 +- arch/arm64/kvm/vgic/vgic.h| 1 + include/kvm/arm_vgic.h| 1 + tools/testing/selftests/kvm/.gitignore| 1 + tools/testing/selftests/kvm/Makefile | 1 + .../testing/selftests/kvm/aarch64/vgic_init.c | 585 ++ .../testing/selftests/kvm/include/kvm_util.h | 9 + tools/testing/selftests/kvm/lib/kvm_util.c| 77 +++ 12 files changed, 739 insertions(+), 42 deletions(-) create mode 100644 tools/testing/selftests/kvm/aarch64/vgic_init.c -- 2.26.3