Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-31 Thread Dave Chinner
On Thu, Jan 30, 2014 at 10:45:26PM -0700, Ross Zwisler wrote: > On Fri, 31 Jan 2014, Dave Chinner wrote: > > The read/write path is broken, Willy. We can't map arbitrary byte > > ranges to the DIO subsystem. I'm now certain that the data > > corruptions I'm seeing are in sub-sector regions from

Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-31 Thread Dave Chinner
On Thu, Jan 30, 2014 at 10:45:26PM -0700, Ross Zwisler wrote: On Fri, 31 Jan 2014, Dave Chinner wrote: The read/write path is broken, Willy. We can't map arbitrary byte ranges to the DIO subsystem. I'm now certain that the data corruptions I'm seeing are in sub-sector regions from unaligned

Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-30 Thread Ross Zwisler
On Fri, 31 Jan 2014, Dave Chinner wrote: > The read/write path is broken, Willy. We can't map arbitrary byte > ranges to the DIO subsystem. I'm now certain that the data > corruptions I'm seeing are in sub-sector regions from unaligned IOs > from userspace. We still need to use the buffered IO

Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-30 Thread Dave Chinner
On Thu, Jan 30, 2014 at 08:25:37PM +1100, Dave Chinner wrote: > On Thu, Jan 30, 2014 at 05:42:30PM +1100, Dave Chinner wrote: > > On Wed, Jan 15, 2014 at 08:24:18PM -0500, Matthew Wilcox wrote: > > > This series of patches add support for XIP to ext4. Unfortunately, > > > it turns out to be

Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-30 Thread Dave Chinner
On Thu, Jan 30, 2014 at 05:42:30PM +1100, Dave Chinner wrote: > On Wed, Jan 15, 2014 at 08:24:18PM -0500, Matthew Wilcox wrote: > > This series of patches add support for XIP to ext4. Unfortunately, > > it turns out to be necessary to rewrite the existing XIP support code > > first due to races

Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-30 Thread Dave Chinner
On Thu, Jan 30, 2014 at 05:42:30PM +1100, Dave Chinner wrote: On Wed, Jan 15, 2014 at 08:24:18PM -0500, Matthew Wilcox wrote: This series of patches add support for XIP to ext4. Unfortunately, it turns out to be necessary to rewrite the existing XIP support code first due to races that are

Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-30 Thread Dave Chinner
On Thu, Jan 30, 2014 at 08:25:37PM +1100, Dave Chinner wrote: On Thu, Jan 30, 2014 at 05:42:30PM +1100, Dave Chinner wrote: On Wed, Jan 15, 2014 at 08:24:18PM -0500, Matthew Wilcox wrote: This series of patches add support for XIP to ext4. Unfortunately, it turns out to be necessary to

Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-30 Thread Ross Zwisler
On Fri, 31 Jan 2014, Dave Chinner wrote: The read/write path is broken, Willy. We can't map arbitrary byte ranges to the DIO subsystem. I'm now certain that the data corruptions I'm seeing are in sub-sector regions from unaligned IOs from userspace. We still need to use the buffered IO path

Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-29 Thread Dave Chinner
On Wed, Jan 15, 2014 at 08:24:18PM -0500, Matthew Wilcox wrote: > This series of patches add support for XIP to ext4. Unfortunately, > it turns out to be necessary to rewrite the existing XIP support code > first due to races that are unfixable in the current design. > > Since v4 of this

Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-29 Thread Dave Chinner
On Wed, Jan 15, 2014 at 08:24:18PM -0500, Matthew Wilcox wrote: This series of patches add support for XIP to ext4. Unfortunately, it turns out to be necessary to rewrite the existing XIP support code first due to races that are unfixable in the current design. Since v4 of this patchset,

Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-27 Thread Dave Chinner
On Thu, Jan 23, 2014 at 12:12:43PM +, Wilcox, Matthew R wrote: > Are you hitting the same problems with ext4 fsck that we did? Version 1.42.8 > reports spurious corruption. From the 1.42.9 changelog: > > * Fixed a regression introduced in 1.42.8 which would cause e2fsck to >

Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-27 Thread Dave Chinner
On Thu, Jan 23, 2014 at 12:12:43PM +, Wilcox, Matthew R wrote: Are you hitting the same problems with ext4 fsck that we did? Version 1.42.8 reports spurious corruption. From the 1.42.9 changelog: * Fixed a regression introduced in 1.42.8 which would cause e2fsck to erroneously

RE: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-23 Thread Wilcox, Matthew R
. From: Dave Chinner [da...@fromorbit.com] Sent: January 23, 2014 1:01 AM To: Wilcox, Matthew R Cc: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; linux...@kvack.org; linux-e...@vger.kernel.org Subject: Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support

Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-23 Thread Dave Chinner
On Wed, Jan 15, 2014 at 08:24:18PM -0500, Matthew Wilcox wrote: > This series of patches add support for XIP to ext4. Unfortunately, > it turns out to be necessary to rewrite the existing XIP support code > first due to races that are unfixable in the current design. > > Since v4 of this

Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-23 Thread Dave Chinner
On Wed, Jan 15, 2014 at 08:24:18PM -0500, Matthew Wilcox wrote: This series of patches add support for XIP to ext4. Unfortunately, it turns out to be necessary to rewrite the existing XIP support code first due to races that are unfixable in the current design. Since v4 of this patchset,

RE: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-23 Thread Wilcox, Matthew R
. From: Dave Chinner [da...@fromorbit.com] Sent: January 23, 2014 1:01 AM To: Wilcox, Matthew R Cc: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; linux...@kvack.org; linux-e...@vger.kernel.org Subject: Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support

Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-22 Thread Dave Chinner
On Thu, Jan 23, 2014 at 06:48:25PM +1100, Dave Chinner wrote: > On Wed, Jan 15, 2014 at 08:24:18PM -0500, Matthew Wilcox wrote: > > This series of patches add support for XIP to ext4. Unfortunately, > > it turns out to be necessary to rewrite the existing XIP support code > > first due to races

Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-22 Thread Dave Chinner
On Wed, Jan 15, 2014 at 08:24:18PM -0500, Matthew Wilcox wrote: > This series of patches add support for XIP to ext4. Unfortunately, > it turns out to be necessary to rewrite the existing XIP support code > first due to races that are unfixable in the current design. > > Since v4 of this

Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-22 Thread Dave Chinner
On Wed, Jan 15, 2014 at 08:24:18PM -0500, Matthew Wilcox wrote: This series of patches add support for XIP to ext4. Unfortunately, it turns out to be necessary to rewrite the existing XIP support code first due to races that are unfixable in the current design. Since v4 of this patchset,

Re: [PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-22 Thread Dave Chinner
On Thu, Jan 23, 2014 at 06:48:25PM +1100, Dave Chinner wrote: On Wed, Jan 15, 2014 at 08:24:18PM -0500, Matthew Wilcox wrote: This series of patches add support for XIP to ext4. Unfortunately, it turns out to be necessary to rewrite the existing XIP support code first due to races that are

[PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-15 Thread Matthew Wilcox
This series of patches add support for XIP to ext4. Unfortunately, it turns out to be necessary to rewrite the existing XIP support code first due to races that are unfixable in the current design. Since v4 of this patchset, I've improved the documentation, fixed a couple of warnings that a

[PATCH v5 00/22] Rewrite XIP code and add XIP support to ext4

2014-01-15 Thread Matthew Wilcox
This series of patches add support for XIP to ext4. Unfortunately, it turns out to be necessary to rewrite the existing XIP support code first due to races that are unfixable in the current design. Since v4 of this patchset, I've improved the documentation, fixed a couple of warnings that a