Re: [PATCH v5 01/18] cgroup/misc: Add per resource callbacks for CSS events

2023-10-17 Thread Michal Koutný
On Fri, Sep 22, 2023 at 08:06:40PM -0700, Haitao Huang wrote: > @@ -276,10 +276,13 @@ static ssize_t misc_cg_max_write(struct > kernfs_open_file *of, char *buf, > > cg = css_misc(of_css(of)); > > - if (READ_ONCE(misc_res_capacity[type])) > + if

Re: [PATCH v5 01/18] cgroup/misc: Add per resource callbacks for CSS events

2023-10-04 Thread Tejun Heo
Hello, On Wed, Oct 04, 2023 at 10:45:08AM -0500, Haitao Huang wrote: > So I will update to something like following. Let me know if that's correct > understanding. > @tj, I'd appreciate for your input on whether this is acceptable from > cgroups side. Yeah, that's fine by me and I can't tell

Re: [PATCH v5 01/18] cgroup/misc: Add per resource callbacks for CSS events

2023-10-04 Thread Haitao Huang
Hi Jarkko On Mon, 02 Oct 2023 17:55:14 -0500, Jarkko Sakkinen wrote: ... > >> I noticed this one later: > >> > >> It would better to create a separate ops struct and declare the instance > >> as const at minimum. > >> > >> Then there is no need for dynamic assigment of ops and all that

Re: [PATCH v5 01/18] cgroup/misc: Add per resource callbacks for CSS events

2023-10-03 Thread Haitao Huang
On Wed, 27 Sep 2023 04:20:55 -0500, Huang, Kai wrote: On Fri, 2023-09-22 at 20:06 -0700, Haitao Huang wrote: From: Kristen Carlson Accardi The misc cgroup controller (subsystem) currently does not perform resource type specific action for Cgroups Subsystem State (CSS) events: the

Re: [PATCH v5 01/18] cgroup/misc: Add per resource callbacks for CSS events

2023-10-02 Thread Jarkko Sakkinen
On Tue Oct 3, 2023 at 1:47 AM EEST, Jarkko Sakkinen wrote: > On Wed Sep 27, 2023 at 4:56 AM EEST, Haitao Huang wrote: > > On Tue, 26 Sep 2023 08:13:18 -0500, Jarkko Sakkinen > > wrote: > > > > ... > > >> > >> /** > > >> > >> @@ -410,7 +429,14 @@ misc_cg_alloc(struct cgroup_subsys_state > > >>

Re: [PATCH v5 01/18] cgroup/misc: Add per resource callbacks for CSS events

2023-10-02 Thread Jarkko Sakkinen
On Wed Sep 27, 2023 at 4:56 AM EEST, Haitao Huang wrote: > On Tue, 26 Sep 2023 08:13:18 -0500, Jarkko Sakkinen > wrote: > > ... > >> > >> /** > >> > >> @@ -410,7 +429,14 @@ misc_cg_alloc(struct cgroup_subsys_state > >> > >> *parent_css) > >> > >> */ > >> > >> static void misc_cg_free(struct

Re: [PATCH v5 01/18] cgroup/misc: Add per resource callbacks for CSS events

2023-09-27 Thread Huang, Kai
On Fri, 2023-09-22 at 20:06 -0700, Haitao Huang wrote: > From: Kristen Carlson Accardi > > The misc cgroup controller (subsystem) currently does not perform > resource type specific action for Cgroups Subsystem State (CSS) events: > the 'css_alloc' event when a cgroup is created and the

Re: [PATCH v5 01/18] cgroup/misc: Add per resource callbacks for CSS events

2023-09-26 Thread Haitao Huang
On Tue, 26 Sep 2023 08:13:18 -0500, Jarkko Sakkinen wrote: ... > >> /** > >> @@ -410,7 +429,14 @@ misc_cg_alloc(struct cgroup_subsys_state > >> *parent_css) > >> */ > >> static void misc_cg_free(struct cgroup_subsys_state *css) > >> { > >> - kfree(css_misc(css)); > >> + struct misc_cg

Re: [PATCH v5 01/18] cgroup/misc: Add per resource callbacks for CSS events

2023-09-26 Thread Jarkko Sakkinen
On Tue Sep 26, 2023 at 4:10 PM EEST, Jarkko Sakkinen wrote: > On Tue Sep 26, 2023 at 6:04 AM EEST, Haitao Huang wrote: > > Hi Jarkko > > > > On Mon, 25 Sep 2023 12:09:21 -0500, Jarkko Sakkinen > > wrote: > > > > > On Sat Sep 23, 2023 at 6:06 AM EEST, Haitao Huang wrote: > > >> From: Kristen

Re: [PATCH v5 01/18] cgroup/misc: Add per resource callbacks for CSS events

2023-09-26 Thread Jarkko Sakkinen
On Tue Sep 26, 2023 at 6:04 AM EEST, Haitao Huang wrote: > Hi Jarkko > > On Mon, 25 Sep 2023 12:09:21 -0500, Jarkko Sakkinen > wrote: > > > On Sat Sep 23, 2023 at 6:06 AM EEST, Haitao Huang wrote: > >> From: Kristen Carlson Accardi > >> > >> The misc cgroup controller (subsystem) currently

Re: [PATCH v5 01/18] cgroup/misc: Add per resource callbacks for CSS events

2023-09-25 Thread Haitao Huang
Hi Jarkko On Mon, 25 Sep 2023 12:09:21 -0500, Jarkko Sakkinen wrote: On Sat Sep 23, 2023 at 6:06 AM EEST, Haitao Huang wrote: From: Kristen Carlson Accardi The misc cgroup controller (subsystem) currently does not perform resource type specific action for Cgroups Subsystem State (CSS)

Re: [PATCH v5 01/18] cgroup/misc: Add per resource callbacks for CSS events

2023-09-25 Thread Jarkko Sakkinen
On Sat Sep 23, 2023 at 6:06 AM EEST, Haitao Huang wrote: > From: Kristen Carlson Accardi > > The misc cgroup controller (subsystem) currently does not perform > resource type specific action for Cgroups Subsystem State (CSS) events: > the 'css_alloc' event when a cgroup is created and the

[PATCH v5 01/18] cgroup/misc: Add per resource callbacks for CSS events

2023-09-22 Thread Haitao Huang
From: Kristen Carlson Accardi The misc cgroup controller (subsystem) currently does not perform resource type specific action for Cgroups Subsystem State (CSS) events: the 'css_alloc' event when a cgroup is created and the 'css_free' event when a cgroup is destroyed, or in event of user writing