Re: [PATCH v5 01/45] virtio: use u32, not bitmap for struct virtio_device's features

2014-11-27 Thread David Hildenbrand
> That's the whole reason for the patch. > > I guess you disagree with it, but it's much easier > to deal with simple integers. > Well, I can live with it :) clear_bit() and friends are just easier to understand when scanning the code (at least for me). -- To unsubscribe from this list: send t

Re: [PATCH v5 01/45] virtio: use u32, not bitmap for struct virtio_device's features

2014-11-27 Thread Michael S. Tsirkin
On Thu, Nov 27, 2014 at 05:15:42PM +0100, David Hildenbrand wrote: > > From: Rusty Russell > > > > It seemed like a good idea, but it's actually a pain when we get more > > than 32 feature bits. Just change it to a u32 for now. > > > > Cc: Brian Swetland > > Cc: Christian Borntraeger > > Sign

Re: [PATCH v5 01/45] virtio: use u32, not bitmap for struct virtio_device's features

2014-11-27 Thread David Hildenbrand
> From: Rusty Russell > > It seemed like a good idea, but it's actually a pain when we get more > than 32 feature bits. Just change it to a u32 for now. > > Cc: Brian Swetland > Cc: Christian Borntraeger > Signed-off-by: Rusty Russell > Signed-off-by: Cornelia Huck > Acked-by: Pawel Moll >

[PATCH v5 01/45] virtio: use u32, not bitmap for struct virtio_device's features

2014-11-27 Thread Michael S. Tsirkin
From: Rusty Russell It seemed like a good idea, but it's actually a pain when we get more than 32 feature bits. Just change it to a u32 for now. Cc: Brian Swetland Cc: Christian Borntraeger Signed-off-by: Rusty Russell Signed-off-by: Cornelia Huck Acked-by: Pawel Moll Acked-by: Ohad Ben-Co