Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On Saturday 13 January 2018 06:41 AM, David Lechner wrote: > On 01/12/2018 10:18 AM, Sekhar Nori wrote: >> On Friday 12 January 2018 08:55 PM, David Lechner wrote: PLL output on DA850 must never be below 300MHz or above 600MHz (see datasheet table "Allowed PLL Operating

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On Saturday 13 January 2018 06:41 AM, David Lechner wrote: > On 01/12/2018 10:18 AM, Sekhar Nori wrote: >> On Friday 12 January 2018 08:55 PM, David Lechner wrote: PLL output on DA850 must never be below 300MHz or above 600MHz (see datasheet table "Allowed PLL Operating

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On Saturday 13 January 2018 07:43 AM, David Lechner wrote: > On 01/12/2018 03:21 AM, Sekhar Nori wrote: >> On Monday 08 January 2018 07:47 AM, David Lechner wrote: >>> +static unsigned long davinci_pll_clk_recalc(struct clk_hw *hw, >>> +    unsigned long parent_rate) >>> +{ >>>

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On Saturday 13 January 2018 07:43 AM, David Lechner wrote: > On 01/12/2018 03:21 AM, Sekhar Nori wrote: >> On Monday 08 January 2018 07:47 AM, David Lechner wrote: >>> +static unsigned long davinci_pll_clk_recalc(struct clk_hw *hw, >>> +    unsigned long parent_rate) >>> +{ >>>

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On 01/12/2018 03:21 AM, Sekhar Nori wrote: On Monday 08 January 2018 07:47 AM, David Lechner wrote: +static unsigned long davinci_pll_clk_recalc(struct clk_hw *hw, + unsigned long parent_rate) +{ + struct davinci_pll_clk *pll =

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On 01/12/2018 03:21 AM, Sekhar Nori wrote: On Monday 08 January 2018 07:47 AM, David Lechner wrote: +static unsigned long davinci_pll_clk_recalc(struct clk_hw *hw, + unsigned long parent_rate) +{ + struct davinci_pll_clk *pll =

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On 01/12/2018 10:18 AM, Sekhar Nori wrote: On Friday 12 January 2018 08:55 PM, David Lechner wrote: PLL output on DA850 must never be below 300MHz or above 600MHz (see datasheet table "Allowed PLL Operating Conditions"). Does this take care of that? Thats one of the main reasons I recall I

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On 01/12/2018 10:18 AM, Sekhar Nori wrote: On Friday 12 January 2018 08:55 PM, David Lechner wrote: PLL output on DA850 must never be below 300MHz or above 600MHz (see datasheet table "Allowed PLL Operating Conditions"). Does this take care of that? Thats one of the main reasons I recall I

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On Friday 12 January 2018 08:55 PM, David Lechner wrote: >> >> PLL output on DA850 must never be below 300MHz or above 600MHz (see >> datasheet table "Allowed PLL Operating Conditions"). Does this take care >> of that? Thats one of the main reasons I recall I went with some >> specific values of

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On Friday 12 January 2018 08:55 PM, David Lechner wrote: >> >> PLL output on DA850 must never be below 300MHz or above 600MHz (see >> datasheet table "Allowed PLL Operating Conditions"). Does this take care >> of that? Thats one of the main reasons I recall I went with some >> specific values of

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On 01/12/2018 09:30 AM, Adam Ford wrote: On Fri, Jan 12, 2018 at 9:25 AM, David Lechner wrote: Yes, I noticed that I missed this after I submitted this series. And I will have to rework things to coordinate with the PLL as mentioned above. FYI, I do have cpufreq-dt

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On 01/12/2018 09:30 AM, Adam Ford wrote: On Fri, Jan 12, 2018 at 9:25 AM, David Lechner wrote: Yes, I noticed that I missed this after I submitted this series. And I will have to rework things to coordinate with the PLL as mentioned above. FYI, I do have cpufreq-dt working, although the LEGO

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On Fri, Jan 12, 2018 at 9:25 AM, David Lechner wrote: > On 01/12/2018 03:21 AM, Sekhar Nori wrote: >> >> On Monday 08 January 2018 07:47 AM, David Lechner wrote: >>> >>> This adds a new driver for mach-davinci PLL clocks. This is porting the >>> code from

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On Fri, Jan 12, 2018 at 9:25 AM, David Lechner wrote: > On 01/12/2018 03:21 AM, Sekhar Nori wrote: >> >> On Monday 08 January 2018 07:47 AM, David Lechner wrote: >>> >>> This adds a new driver for mach-davinci PLL clocks. This is porting the >>> code from arch/arm/mach-davinci/clock.c to the

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On 01/12/2018 03:21 AM, Sekhar Nori wrote: On Monday 08 January 2018 07:47 AM, David Lechner wrote: This adds a new driver for mach-davinci PLL clocks. This is porting the code from arch/arm/mach-davinci/clock.c to the common clock framework. Additionally, it adds device tree support for these

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On 01/12/2018 03:21 AM, Sekhar Nori wrote: On Monday 08 January 2018 07:47 AM, David Lechner wrote: This adds a new driver for mach-davinci PLL clocks. This is porting the code from arch/arm/mach-davinci/clock.c to the common clock framework. Additionally, it adds device tree support for these

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On Monday 08 January 2018 07:47 AM, David Lechner wrote: > This adds a new driver for mach-davinci PLL clocks. This is porting the > code from arch/arm/mach-davinci/clock.c to the common clock framework. > Additionally, it adds device tree support for these clocks. > > The ifeq

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On Monday 08 January 2018 07:47 AM, David Lechner wrote: > This adds a new driver for mach-davinci PLL clocks. This is porting the > code from arch/arm/mach-davinci/clock.c to the common clock framework. > Additionally, it adds device tree support for these clocks. > > The ifeq

[PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

This adds a new driver for mach-davinci PLL clocks. This is porting the code from arch/arm/mach-davinci/clock.c to the common clock framework. Additionally, it adds device tree support for these clocks. The ifeq ($(CONFIG_COMMON_CLK), y) in the Makefile is needed to prevent compile errors until

[PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

This adds a new driver for mach-davinci PLL clocks. This is porting the code from arch/arm/mach-davinci/clock.c to the common clock framework. Additionally, it adds device tree support for these clocks. The ifeq ($(CONFIG_COMMON_CLK), y) in the Makefile is needed to prevent compile errors until