Re: [PATCH v5 03/16] x86/mtrr: get MTRR number and support TOP_MEM2

2018-09-04 Thread Pu Wen
On 2018/9/4 16:02, Borislav Petkov wrote: shows only old mails so I'm going to assume this got fixed, finally! And you probably have received a *fixed* BIOS even, allegedly. So what's up? I tested the function on Hygon Dhyana platforms with the latest BIOS, found that this problem is indeed

Re: [PATCH v5 03/16] x86/mtrr: get MTRR number and support TOP_MEM2

2018-09-04 Thread Pu Wen
On 2018/9/4 16:02, Borislav Petkov wrote: shows only old mails so I'm going to assume this got fixed, finally! And you probably have received a *fixed* BIOS even, allegedly. So what's up? I tested the function on Hygon Dhyana platforms with the latest BIOS, found that this problem is indeed

Re: [PATCH v5 03/16] x86/mtrr: get MTRR number and support TOP_MEM2

2018-09-04 Thread Borislav Petkov
On Tue, Sep 04, 2018 at 11:02:41AM +0800, Pu Wen wrote: > > > - if (!((boot_cpu_data.x86_vendor == X86_VENDOR_AMD) && > > > - (boot_cpu_data.x86 >= 0x0f))) > > > + if (!((boot_cpu_data.x86_vendor == X86_VENDOR_AMD && > > > +boot_cpu_data.x86 >= 0x0f) || > > > +

Re: [PATCH v5 03/16] x86/mtrr: get MTRR number and support TOP_MEM2

2018-09-04 Thread Borislav Petkov
On Tue, Sep 04, 2018 at 11:02:41AM +0800, Pu Wen wrote: > > > - if (!((boot_cpu_data.x86_vendor == X86_VENDOR_AMD) && > > > - (boot_cpu_data.x86 >= 0x0f))) > > > + if (!((boot_cpu_data.x86_vendor == X86_VENDOR_AMD && > > > +boot_cpu_data.x86 >= 0x0f) || > > > +

Re: [PATCH v5 03/16] x86/mtrr: get MTRR number and support TOP_MEM2

2018-09-03 Thread Pu Wen
On 2018/9/4 3:04, Borislav Petkov wrote: It was "Hygon Dhyana" before now "Hygon" only. Can we agree on the naming nomenclature and stick with it. OK, agree on it. ... - if (!((boot_cpu_data.x86_vendor == X86_VENDOR_AMD) && - (boot_cpu_data.x86 >= 0x0f))) + if

Re: [PATCH v5 03/16] x86/mtrr: get MTRR number and support TOP_MEM2

2018-09-03 Thread Pu Wen
On 2018/9/4 3:04, Borislav Petkov wrote: It was "Hygon Dhyana" before now "Hygon" only. Can we agree on the naming nomenclature and stick with it. OK, agree on it. ... - if (!((boot_cpu_data.x86_vendor == X86_VENDOR_AMD) && - (boot_cpu_data.x86 >= 0x0f))) + if

Re: [PATCH v5 03/16] x86/mtrr: get MTRR number and support TOP_MEM2

2018-09-03 Thread Borislav Petkov
On Wed, Aug 29, 2018 at 08:43:23PM +0800, Pu Wen wrote: > Hygon CPU have a special magic MSR way to force WB for memory >4GB, It was "Hygon Dhyana" before now "Hygon" only. Can we agree on the naming nomenclature and stick with it. Also, it is "The ... CPU has a special..." > and also support

Re: [PATCH v5 03/16] x86/mtrr: get MTRR number and support TOP_MEM2

2018-09-03 Thread Borislav Petkov
On Wed, Aug 29, 2018 at 08:43:23PM +0800, Pu Wen wrote: > Hygon CPU have a special magic MSR way to force WB for memory >4GB, It was "Hygon Dhyana" before now "Hygon" only. Can we agree on the naming nomenclature and stick with it. Also, it is "The ... CPU has a special..." > and also support

[PATCH v5 03/16] x86/mtrr: get MTRR number and support TOP_MEM2

2018-08-29 Thread Pu Wen
Hygon CPU have a special magic MSR way to force WB for memory >4GB, and also support TOP_MEM2. Therefore, it is necessary to add Hygon support in amd_special_default_mtrr(). The MtrrFixDramModEn bit on Hygon platform should also be set to 1 during BIOS initialization of the fixed MTRRs, then

[PATCH v5 03/16] x86/mtrr: get MTRR number and support TOP_MEM2

2018-08-29 Thread Pu Wen
Hygon CPU have a special magic MSR way to force WB for memory >4GB, and also support TOP_MEM2. Therefore, it is necessary to add Hygon support in amd_special_default_mtrr(). The MtrrFixDramModEn bit on Hygon platform should also be set to 1 during BIOS initialization of the fixed MTRRs, then