Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 4 June 2018 at 12:12, Juri Lelli wrote: > On 04/06/18 09:14, Vincent Guittot wrote: >> On 4 June 2018 at 09:04, Juri Lelli wrote: >> > Hi Vincent, >> > >> > On 04/06/18 08:41, Vincent Guittot wrote: >> >> On 1 June 2018 at 19:45, Joel Fernandes wrote: >> >> > On Fri, Jun 01, 2018 at

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 4 June 2018 at 12:12, Juri Lelli wrote: > On 04/06/18 09:14, Vincent Guittot wrote: >> On 4 June 2018 at 09:04, Juri Lelli wrote: >> > Hi Vincent, >> > >> > On 04/06/18 08:41, Vincent Guittot wrote: >> >> On 1 June 2018 at 19:45, Joel Fernandes wrote: >> >> > On Fri, Jun 01, 2018 at

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 04/06/18 09:14, Vincent Guittot wrote: > On 4 June 2018 at 09:04, Juri Lelli wrote: > > Hi Vincent, > > > > On 04/06/18 08:41, Vincent Guittot wrote: > >> On 1 June 2018 at 19:45, Joel Fernandes wrote: > >> > On Fri, Jun 01, 2018 at 03:53:07PM +0200, Vincent Guittot wrote: > > > > [...] > > >

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 04/06/18 09:14, Vincent Guittot wrote: > On 4 June 2018 at 09:04, Juri Lelli wrote: > > Hi Vincent, > > > > On 04/06/18 08:41, Vincent Guittot wrote: > >> On 1 June 2018 at 19:45, Joel Fernandes wrote: > >> > On Fri, Jun 01, 2018 at 03:53:07PM +0200, Vincent Guittot wrote: > > > > [...] > > >

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 4 June 2018 at 09:04, Juri Lelli wrote: > Hi Vincent, > > On 04/06/18 08:41, Vincent Guittot wrote: >> On 1 June 2018 at 19:45, Joel Fernandes wrote: >> > On Fri, Jun 01, 2018 at 03:53:07PM +0200, Vincent Guittot wrote: > > [...] > >> > IMO I feel its overkill to account dl_avg when we

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 4 June 2018 at 09:04, Juri Lelli wrote: > Hi Vincent, > > On 04/06/18 08:41, Vincent Guittot wrote: >> On 1 June 2018 at 19:45, Joel Fernandes wrote: >> > On Fri, Jun 01, 2018 at 03:53:07PM +0200, Vincent Guittot wrote: > > [...] > >> > IMO I feel its overkill to account dl_avg when we

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

Hi Vincent, On 04/06/18 08:41, Vincent Guittot wrote: > On 1 June 2018 at 19:45, Joel Fernandes wrote: > > On Fri, Jun 01, 2018 at 03:53:07PM +0200, Vincent Guittot wrote: [...] > > IMO I feel its overkill to account dl_avg when we already have DL's running > > bandwidth we can use. I

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

Hi Vincent, On 04/06/18 08:41, Vincent Guittot wrote: > On 1 June 2018 at 19:45, Joel Fernandes wrote: > > On Fri, Jun 01, 2018 at 03:53:07PM +0200, Vincent Guittot wrote: [...] > > IMO I feel its overkill to account dl_avg when we already have DL's running > > bandwidth we can use. I

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 1 June 2018 at 19:45, Joel Fernandes wrote: > On Fri, Jun 01, 2018 at 03:53:07PM +0200, Vincent Guittot wrote: >> > >> >> The example with a RT task described in the cover letter can be >> > >> >> run with a DL task and will give similar results. >> > > >> > > In the cover letter you says: >>

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 1 June 2018 at 19:45, Joel Fernandes wrote: > On Fri, Jun 01, 2018 at 03:53:07PM +0200, Vincent Guittot wrote: >> > >> >> The example with a RT task described in the cover letter can be >> > >> >> run with a DL task and will give similar results. >> > > >> > > In the cover letter you says: >>

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On Fri, Jun 01, 2018 at 03:53:07PM +0200, Vincent Guittot wrote: > > >> >> The example with a RT task described in the cover letter can be > > >> >> run with a DL task and will give similar results. > > > > > > In the cover letter you says: > > > > > >A rt-app use case which creates an always

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On Fri, Jun 01, 2018 at 03:53:07PM +0200, Vincent Guittot wrote: > > >> >> The example with a RT task described in the cover letter can be > > >> >> run with a DL task and will give similar results. > > > > > > In the cover letter you says: > > > > > >A rt-app use case which creates an always

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

Le Thursday 31 May 2018 à 15:02:04 (+0200), Vincent Guittot a écrit : > On 31 May 2018 at 12:27, Patrick Bellasi wrote: > > > > Hi Vincent, Juri, > > > > On 28-May 18:34, Vincent Guittot wrote: > >> On 28 May 2018 at 17:22, Juri Lelli wrote: > >> > On 28/05/18 16:57, Vincent Guittot wrote: > >>

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

Le Thursday 31 May 2018 à 15:02:04 (+0200), Vincent Guittot a écrit : > On 31 May 2018 at 12:27, Patrick Bellasi wrote: > > > > Hi Vincent, Juri, > > > > On 28-May 18:34, Vincent Guittot wrote: > >> On 28 May 2018 at 17:22, Juri Lelli wrote: > >> > On 28/05/18 16:57, Vincent Guittot wrote: > >>

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 31 May 2018 at 12:27, Patrick Bellasi wrote: > > Hi Vincent, Juri, > > On 28-May 18:34, Vincent Guittot wrote: >> On 28 May 2018 at 17:22, Juri Lelli wrote: >> > On 28/05/18 16:57, Vincent Guittot wrote: >> >> Hi Juri, >> >> >> >> On 28 May 2018 at 12:12, Juri Lelli wrote: >> >> > Hi

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 31 May 2018 at 12:27, Patrick Bellasi wrote: > > Hi Vincent, Juri, > > On 28-May 18:34, Vincent Guittot wrote: >> On 28 May 2018 at 17:22, Juri Lelli wrote: >> > On 28/05/18 16:57, Vincent Guittot wrote: >> >> Hi Juri, >> >> >> >> On 28 May 2018 at 12:12, Juri Lelli wrote: >> >> > Hi

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

Hi Vincent, Juri, On 28-May 18:34, Vincent Guittot wrote: > On 28 May 2018 at 17:22, Juri Lelli wrote: > > On 28/05/18 16:57, Vincent Guittot wrote: > >> Hi Juri, > >> > >> On 28 May 2018 at 12:12, Juri Lelli wrote: > >> > Hi Vincent, > >> > > >> > On 25/05/18 15:12, Vincent Guittot wrote: >

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

Hi Vincent, Juri, On 28-May 18:34, Vincent Guittot wrote: > On 28 May 2018 at 17:22, Juri Lelli wrote: > > On 28/05/18 16:57, Vincent Guittot wrote: > >> Hi Juri, > >> > >> On 28 May 2018 at 12:12, Juri Lelli wrote: > >> > Hi Vincent, > >> > > >> > On 25/05/18 15:12, Vincent Guittot wrote: >

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 30/05/18 09:37, Quentin Perret wrote: > On Tuesday 29 May 2018 at 11:52:03 (+0200), Juri Lelli wrote: > > On 29/05/18 09:40, Quentin Perret wrote: > > > Hi Vincent, > > > > > > On Friday 25 May 2018 at 15:12:26 (+0200), Vincent Guittot wrote: > > > > Now that we have both the dl class

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 30/05/18 09:37, Quentin Perret wrote: > On Tuesday 29 May 2018 at 11:52:03 (+0200), Juri Lelli wrote: > > On 29/05/18 09:40, Quentin Perret wrote: > > > Hi Vincent, > > > > > > On Friday 25 May 2018 at 15:12:26 (+0200), Vincent Guittot wrote: > > > > Now that we have both the dl class

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On Tuesday 29 May 2018 at 11:52:03 (+0200), Juri Lelli wrote: > On 29/05/18 09:40, Quentin Perret wrote: > > Hi Vincent, > > > > On Friday 25 May 2018 at 15:12:26 (+0200), Vincent Guittot wrote: > > > Now that we have both the dl class bandwidth requirement and the dl class > > > utilization, we

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On Tuesday 29 May 2018 at 11:52:03 (+0200), Juri Lelli wrote: > On 29/05/18 09:40, Quentin Perret wrote: > > Hi Vincent, > > > > On Friday 25 May 2018 at 15:12:26 (+0200), Vincent Guittot wrote: > > > Now that we have both the dl class bandwidth requirement and the dl class > > > utilization, we

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 29/05/18 09:40, Quentin Perret wrote: > Hi Vincent, > > On Friday 25 May 2018 at 15:12:26 (+0200), Vincent Guittot wrote: > > Now that we have both the dl class bandwidth requirement and the dl class > > utilization, we can use the max of the 2 values when agregating the > > utilization of the

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 29/05/18 09:40, Quentin Perret wrote: > Hi Vincent, > > On Friday 25 May 2018 at 15:12:26 (+0200), Vincent Guittot wrote: > > Now that we have both the dl class bandwidth requirement and the dl class > > utilization, we can use the max of the 2 values when agregating the > > utilization of the

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 29/05/18 08:48, Vincent Guittot wrote: > On 29 May 2018 at 08:31, Juri Lelli wrote: > > On 28/05/18 22:08, Joel Fernandes wrote: > >> On Mon, May 28, 2018 at 12:12:34PM +0200, Juri Lelli wrote: > >> [..] > >> > > + > >> > > + util = max_t(unsigned long, util, READ_ONCE(rq->avg_dl.util_avg)); >

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 29/05/18 08:48, Vincent Guittot wrote: > On 29 May 2018 at 08:31, Juri Lelli wrote: > > On 28/05/18 22:08, Joel Fernandes wrote: > >> On Mon, May 28, 2018 at 12:12:34PM +0200, Juri Lelli wrote: > >> [..] > >> > > + > >> > > + util = max_t(unsigned long, util, READ_ONCE(rq->avg_dl.util_avg)); >

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

Hi Vincent, On Friday 25 May 2018 at 15:12:26 (+0200), Vincent Guittot wrote: > Now that we have both the dl class bandwidth requirement and the dl class > utilization, we can use the max of the 2 values when agregating the > utilization of the CPU. > > Signed-off-by: Vincent Guittot > --- >

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

Hi Vincent, On Friday 25 May 2018 at 15:12:26 (+0200), Vincent Guittot wrote: > Now that we have both the dl class bandwidth requirement and the dl class > utilization, we can use the max of the 2 values when agregating the > utilization of the CPU. > > Signed-off-by: Vincent Guittot > --- >

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 29 May 2018 at 08:31, Juri Lelli wrote: > On 28/05/18 22:08, Joel Fernandes wrote: >> On Mon, May 28, 2018 at 12:12:34PM +0200, Juri Lelli wrote: >> [..] >> > > + >> > > + util = max_t(unsigned long, util, READ_ONCE(rq->avg_dl.util_avg)); >> > > + >> > > + return util; >> > >> > Anyway, just a

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 29 May 2018 at 08:31, Juri Lelli wrote: > On 28/05/18 22:08, Joel Fernandes wrote: >> On Mon, May 28, 2018 at 12:12:34PM +0200, Juri Lelli wrote: >> [..] >> > > + >> > > + util = max_t(unsigned long, util, READ_ONCE(rq->avg_dl.util_avg)); >> > > + >> > > + return util; >> > >> > Anyway, just a

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 28/05/18 22:08, Joel Fernandes wrote: > On Mon, May 28, 2018 at 12:12:34PM +0200, Juri Lelli wrote: > [..] > > > + > > > + util = max_t(unsigned long, util, READ_ONCE(rq->avg_dl.util_avg)); > > > + > > > + return util; > > > > Anyway, just a quick thought. I guess we should experiment with

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 28/05/18 22:08, Joel Fernandes wrote: > On Mon, May 28, 2018 at 12:12:34PM +0200, Juri Lelli wrote: > [..] > > > + > > > + util = max_t(unsigned long, util, READ_ONCE(rq->avg_dl.util_avg)); > > > + > > > + return util; > > > > Anyway, just a quick thought. I guess we should experiment with

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On Mon, May 28, 2018 at 12:12:34PM +0200, Juri Lelli wrote: [..] > > + > > + util = max_t(unsigned long, util, READ_ONCE(rq->avg_dl.util_avg)); > > + > > + return util; > > Anyway, just a quick thought. I guess we should experiment with this a > bit. Now, I don't unfortunately have a Arm

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On Mon, May 28, 2018 at 12:12:34PM +0200, Juri Lelli wrote: [..] > > + > > + util = max_t(unsigned long, util, READ_ONCE(rq->avg_dl.util_avg)); > > + > > + return util; > > Anyway, just a quick thought. I guess we should experiment with this a > bit. Now, I don't unfortunately have a Arm

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 28 May 2018 at 17:22, Juri Lelli wrote: > On 28/05/18 16:57, Vincent Guittot wrote: >> Hi Juri, >> >> On 28 May 2018 at 12:12, Juri Lelli wrote: >> > Hi Vincent, >> > >> > On 25/05/18 15:12, Vincent Guittot wrote: >> >> Now that we have both the

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 28 May 2018 at 17:22, Juri Lelli wrote: > On 28/05/18 16:57, Vincent Guittot wrote: >> Hi Juri, >> >> On 28 May 2018 at 12:12, Juri Lelli wrote: >> > Hi Vincent, >> > >> > On 25/05/18 15:12, Vincent Guittot wrote: >> >> Now that we have both the dl class bandwidth requirement and the dl class

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

Hi Vincent, On 25/05/18 15:12, Vincent Guittot wrote: > Now that we have both the dl class bandwidth requirement and the dl class > utilization, we can use the max of the 2 values when agregating the > utilization of the CPU. > > Signed-off-by: Vincent Guittot > ---

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

Hi Vincent, On 25/05/18 15:12, Vincent Guittot wrote: > Now that we have both the dl class bandwidth requirement and the dl class > utilization, we can use the max of the 2 values when agregating the > utilization of the CPU. > > Signed-off-by: Vincent Guittot > --- > kernel/sched/sched.h | 6

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 28/05/18 16:57, Vincent Guittot wrote: > Hi Juri, > > On 28 May 2018 at 12:12, Juri Lelli wrote: > > Hi Vincent, > > > > On 25/05/18 15:12, Vincent Guittot wrote: > >> Now that we have both the dl class bandwidth requirement and the dl class > >> utilization, we can use

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

On 28/05/18 16:57, Vincent Guittot wrote: > Hi Juri, > > On 28 May 2018 at 12:12, Juri Lelli wrote: > > Hi Vincent, > > > > On 25/05/18 15:12, Vincent Guittot wrote: > >> Now that we have both the dl class bandwidth requirement and the dl class > >> utilization, we can use the max of the 2

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

Hi Juri, On 28 May 2018 at 12:12, Juri Lelli wrote: > Hi Vincent, > > On 25/05/18 15:12, Vincent Guittot wrote: >> Now that we have both the dl class bandwidth requirement and the dl class >> utilization, we can use the max of the 2 values when agregating the >>

Re: [PATCH v5 05/10] cpufreq/schedutil: get max utilization

Hi Juri, On 28 May 2018 at 12:12, Juri Lelli wrote: > Hi Vincent, > > On 25/05/18 15:12, Vincent Guittot wrote: >> Now that we have both the dl class bandwidth requirement and the dl class >> utilization, we can use the max of the 2 values when agregating the >> utilization of the CPU. >> >>

[PATCH v5 05/10] cpufreq/schedutil: get max utilization

Now that we have both the dl class bandwidth requirement and the dl class utilization, we can use the max of the 2 values when agregating the utilization of the CPU. Signed-off-by: Vincent Guittot --- kernel/sched/sched.h | 6 +- 1 file changed, 5 insertions(+),

[PATCH v5 05/10] cpufreq/schedutil: get max utilization

Now that we have both the dl class bandwidth requirement and the dl class utilization, we can use the max of the 2 values when agregating the utilization of the CPU. Signed-off-by: Vincent Guittot --- kernel/sched/sched.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git