Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-07 Thread Matthias Kaehlcke
Hi Chanwoo, On Tue, Aug 07, 2018 at 10:35:37AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 07일 09:23, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > On Tue, Aug 07, 2018 at 07:31:16AM +0900, Chanwoo Choi wrote: > >> Hi Matthias, > >> > >> On 2018년 08월 07일 04:21, Matthias

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-07 Thread Matthias Kaehlcke
Hi Chanwoo, On Tue, Aug 07, 2018 at 10:35:37AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 07일 09:23, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > On Tue, Aug 07, 2018 at 07:31:16AM +0900, Chanwoo Choi wrote: > >> Hi Matthias, > >> > >> On 2018년 08월 07일 04:21, Matthias

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-06 Thread Chanwoo Choi
Hi Matthias, On 2018년 08월 07일 09:23, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Tue, Aug 07, 2018 at 07:31:16AM +0900, Chanwoo Choi wrote: >> Hi Matthias, >> >> On 2018년 08월 07일 04:21, Matthias Kaehlcke wrote: >>> Hi Chanwoo, >>> >>> On Fri, Aug 03, 2018 at 09:14:46AM +0900, Chanwoo Choi

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-06 Thread Chanwoo Choi
Hi Matthias, On 2018년 08월 07일 09:23, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Tue, Aug 07, 2018 at 07:31:16AM +0900, Chanwoo Choi wrote: >> Hi Matthias, >> >> On 2018년 08월 07일 04:21, Matthias Kaehlcke wrote: >>> Hi Chanwoo, >>> >>> On Fri, Aug 03, 2018 at 09:14:46AM +0900, Chanwoo Choi

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-06 Thread Matthias Kaehlcke
Hi Chanwoo, On Tue, Aug 07, 2018 at 07:31:16AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 07일 04:21, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > On Fri, Aug 03, 2018 at 09:14:46AM +0900, Chanwoo Choi wrote: > >> Hi Matthias, > >> > >> On 2018년 08월 03일 08:48, Matthias

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-06 Thread Matthias Kaehlcke
Hi Chanwoo, On Tue, Aug 07, 2018 at 07:31:16AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 07일 04:21, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > On Fri, Aug 03, 2018 at 09:14:46AM +0900, Chanwoo Choi wrote: > >> Hi Matthias, > >> > >> On 2018년 08월 03일 08:48, Matthias

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-06 Thread Chanwoo Choi
Hi Viresh Kumar, I have a question about dev_pm_opp_enable() and dev_pm_opp_disable(). Two functions have 'available' field to indicate the status of specific OPP. If different device drivers try to control the same OPP, dev_pm_opp_enable() and dev_pm_opp_disable() will consider only last

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-06 Thread Chanwoo Choi
Hi Viresh Kumar, I have a question about dev_pm_opp_enable() and dev_pm_opp_disable(). Two functions have 'available' field to indicate the status of specific OPP. If different device drivers try to control the same OPP, dev_pm_opp_enable() and dev_pm_opp_disable() will consider only last

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-06 Thread Chanwoo Choi
Hi Matthias, On 2018년 08월 07일 04:21, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Fri, Aug 03, 2018 at 09:14:46AM +0900, Chanwoo Choi wrote: >> Hi Matthias, >> >> On 2018년 08월 03일 08:48, Matthias Kaehlcke wrote: >>> On Thu, Aug 02, 2018 at 04:13:43PM -0700, Matthias Kaehlcke wrote: Hi

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-06 Thread Chanwoo Choi
Hi Matthias, On 2018년 08월 07일 04:21, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Fri, Aug 03, 2018 at 09:14:46AM +0900, Chanwoo Choi wrote: >> Hi Matthias, >> >> On 2018년 08월 03일 08:48, Matthias Kaehlcke wrote: >>> On Thu, Aug 02, 2018 at 04:13:43PM -0700, Matthias Kaehlcke wrote: Hi

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-06 Thread Chanwoo Choi
Hi Matthias, On 2018년 08월 07일 03:46, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Fri, Aug 03, 2018 at 08:56:57AM +0900, Chanwoo Choi wrote: >> Hi Matthias, >> >> On 2018년 08월 03일 08:13, Matthias Kaehlcke wrote: >>> Hi Chanwoo, >>> >>> On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-06 Thread Chanwoo Choi
Hi Matthias, On 2018년 08월 07일 03:46, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Fri, Aug 03, 2018 at 08:56:57AM +0900, Chanwoo Choi wrote: >> Hi Matthias, >> >> On 2018년 08월 03일 08:13, Matthias Kaehlcke wrote: >>> Hi Chanwoo, >>> >>> On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-06 Thread Matthias Kaehlcke
Hi Chanwoo, On Fri, Aug 03, 2018 at 09:14:46AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 03일 08:48, Matthias Kaehlcke wrote: > > On Thu, Aug 02, 2018 at 04:13:43PM -0700, Matthias Kaehlcke wrote: > >> Hi Chanwoo, > >> > >> On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-06 Thread Matthias Kaehlcke
Hi Chanwoo, On Fri, Aug 03, 2018 at 09:14:46AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 03일 08:48, Matthias Kaehlcke wrote: > > On Thu, Aug 02, 2018 at 04:13:43PM -0700, Matthias Kaehlcke wrote: > >> Hi Chanwoo, > >> > >> On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-06 Thread Matthias Kaehlcke
Hi Chanwoo, On Fri, Aug 03, 2018 at 08:56:57AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 03일 08:13, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote: > >> Hi Matthias, > >> > >> On 2018년 08월 02일 02:08, Matthias

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-06 Thread Matthias Kaehlcke
Hi Chanwoo, On Fri, Aug 03, 2018 at 08:56:57AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 03일 08:13, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote: > >> Hi Matthias, > >> > >> On 2018년 08월 02일 02:08, Matthias

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-02 Thread Chanwoo Choi
Hi Matthias, On 2018년 08월 03일 08:48, Matthias Kaehlcke wrote: > On Thu, Aug 02, 2018 at 04:13:43PM -0700, Matthias Kaehlcke wrote: >> Hi Chanwoo, >> >> On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote: >>> Hi Matthias, >>> >>> On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote: Hi

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-02 Thread Chanwoo Choi
Hi Matthias, On 2018년 08월 03일 08:48, Matthias Kaehlcke wrote: > On Thu, Aug 02, 2018 at 04:13:43PM -0700, Matthias Kaehlcke wrote: >> Hi Chanwoo, >> >> On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote: >>> Hi Matthias, >>> >>> On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote: Hi

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-02 Thread Chanwoo Choi
Hi Matthias, On 2018년 08월 03일 08:13, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote: >> Hi Matthias, >> >> On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote: >>> Hi Chanwoo, >>> >>> On Wed, Aug 01, 2018 at 10:22:16AM +0900, Chanwoo Choi

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-02 Thread Chanwoo Choi
Hi Matthias, On 2018년 08월 03일 08:13, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote: >> Hi Matthias, >> >> On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote: >>> Hi Chanwoo, >>> >>> On Wed, Aug 01, 2018 at 10:22:16AM +0900, Chanwoo Choi

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-02 Thread Matthias Kaehlcke
On Thu, Aug 02, 2018 at 04:13:43PM -0700, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote: > > Hi Matthias, > > > > On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote: > > > Hi Chanwoo, > > > > > > On Wed, Aug 01, 2018 at 10:22:16AM +0900,

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-02 Thread Matthias Kaehlcke
On Thu, Aug 02, 2018 at 04:13:43PM -0700, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote: > > Hi Matthias, > > > > On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote: > > > Hi Chanwoo, > > > > > > On Wed, Aug 01, 2018 at 10:22:16AM +0900,

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-02 Thread Matthias Kaehlcke
Hi Chanwoo, On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > On Wed, Aug 01, 2018 at 10:22:16AM +0900, Chanwoo Choi wrote: > >> On 2018년 08월 01일 04:39, Matthias Kaehlcke wrote: > >>> On Mon,

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-02 Thread Matthias Kaehlcke
Hi Chanwoo, On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > On Wed, Aug 01, 2018 at 10:22:16AM +0900, Chanwoo Choi wrote: > >> On 2018년 08월 01일 04:39, Matthias Kaehlcke wrote: > >>> On Mon,

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-01 Thread Chanwoo Choi
Hi Matthias, On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Wed, Aug 01, 2018 at 10:22:16AM +0900, Chanwoo Choi wrote: >> On 2018년 08월 01일 04:39, Matthias Kaehlcke wrote: >>> On Mon, Jul 16, 2018 at 10:50:50AM -0700, Matthias Kaehlcke wrote: On Thu, Jul 12, 2018 at

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-01 Thread Chanwoo Choi
Hi Matthias, On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Wed, Aug 01, 2018 at 10:22:16AM +0900, Chanwoo Choi wrote: >> On 2018년 08월 01일 04:39, Matthias Kaehlcke wrote: >>> On Mon, Jul 16, 2018 at 10:50:50AM -0700, Matthias Kaehlcke wrote: On Thu, Jul 12, 2018 at

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-01 Thread Matthias Kaehlcke
Hi Chanwoo, On Wed, Aug 01, 2018 at 10:22:16AM +0900, Chanwoo Choi wrote: > On 2018년 08월 01일 04:39, Matthias Kaehlcke wrote: > > On Mon, Jul 16, 2018 at 10:50:50AM -0700, Matthias Kaehlcke wrote: > >> On Thu, Jul 12, 2018 at 05:44:33PM +0900, Chanwoo Choi wrote: > >>> Hi Matthias, > >>> > >>> On

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-01 Thread Matthias Kaehlcke
Hi Chanwoo, On Wed, Aug 01, 2018 at 10:22:16AM +0900, Chanwoo Choi wrote: > On 2018년 08월 01일 04:39, Matthias Kaehlcke wrote: > > On Mon, Jul 16, 2018 at 10:50:50AM -0700, Matthias Kaehlcke wrote: > >> On Thu, Jul 12, 2018 at 05:44:33PM +0900, Chanwoo Choi wrote: > >>> Hi Matthias, > >>> > >>> On

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-07-31 Thread Chanwoo Choi
On 2018년 08월 01일 04:39, Matthias Kaehlcke wrote: > On Mon, Jul 16, 2018 at 10:50:50AM -0700, Matthias Kaehlcke wrote: >> On Thu, Jul 12, 2018 at 05:44:33PM +0900, Chanwoo Choi wrote: >>> Hi Matthias, >>> >>> On 2018년 07월 07일 02:53, Matthias Kaehlcke wrote: Hi Chanwoo, On Wed, Jul

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-07-31 Thread Chanwoo Choi
On 2018년 08월 01일 04:39, Matthias Kaehlcke wrote: > On Mon, Jul 16, 2018 at 10:50:50AM -0700, Matthias Kaehlcke wrote: >> On Thu, Jul 12, 2018 at 05:44:33PM +0900, Chanwoo Choi wrote: >>> Hi Matthias, >>> >>> On 2018년 07월 07일 02:53, Matthias Kaehlcke wrote: Hi Chanwoo, On Wed, Jul

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-07-31 Thread Matthias Kaehlcke
On Mon, Jul 16, 2018 at 10:50:50AM -0700, Matthias Kaehlcke wrote: > On Thu, Jul 12, 2018 at 05:44:33PM +0900, Chanwoo Choi wrote: > > Hi Matthias, > > > > On 2018년 07월 07일 02:53, Matthias Kaehlcke wrote: > > > Hi Chanwoo, > > > > > > On Wed, Jul 04, 2018 at 03:41:46PM +0900, Chanwoo Choi wrote:

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-07-31 Thread Matthias Kaehlcke
On Mon, Jul 16, 2018 at 10:50:50AM -0700, Matthias Kaehlcke wrote: > On Thu, Jul 12, 2018 at 05:44:33PM +0900, Chanwoo Choi wrote: > > Hi Matthias, > > > > On 2018년 07월 07일 02:53, Matthias Kaehlcke wrote: > > > Hi Chanwoo, > > > > > > On Wed, Jul 04, 2018 at 03:41:46PM +0900, Chanwoo Choi wrote:

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-07-16 Thread Matthias Kaehlcke
On Thu, Jul 12, 2018 at 05:44:33PM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 07월 07일 02:53, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > On Wed, Jul 04, 2018 at 03:41:46PM +0900, Chanwoo Choi wrote: > > > >> Firstly, > >> I'm not sure why devfreq needs the

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-07-16 Thread Matthias Kaehlcke
On Thu, Jul 12, 2018 at 05:44:33PM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 07월 07일 02:53, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > On Wed, Jul 04, 2018 at 03:41:46PM +0900, Chanwoo Choi wrote: > > > >> Firstly, > >> I'm not sure why devfreq needs the

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-07-12 Thread Chanwoo Choi
Hi Matthias, On 2018년 07월 07일 02:53, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Wed, Jul 04, 2018 at 03:41:46PM +0900, Chanwoo Choi wrote: > >> Firstly, >> I'm not sure why devfreq needs the devfreq_verify_within_limits() function. >> >> devfreq already used the OPP interface as default. It

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-07-12 Thread Chanwoo Choi
Hi Matthias, On 2018년 07월 07일 02:53, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Wed, Jul 04, 2018 at 03:41:46PM +0900, Chanwoo Choi wrote: > >> Firstly, >> I'm not sure why devfreq needs the devfreq_verify_within_limits() function. >> >> devfreq already used the OPP interface as default. It

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-07-06 Thread Matthias Kaehlcke
Hi Chanwoo, On Wed, Jul 04, 2018 at 03:41:46PM +0900, Chanwoo Choi wrote: > Firstly, > I'm not sure why devfreq needs the devfreq_verify_within_limits() function. > > devfreq already used the OPP interface as default. It means that > the outside of 'drivers/devfreq' can disable/enable the

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-07-06 Thread Matthias Kaehlcke
Hi Chanwoo, On Wed, Jul 04, 2018 at 03:41:46PM +0900, Chanwoo Choi wrote: > Firstly, > I'm not sure why devfreq needs the devfreq_verify_within_limits() function. > > devfreq already used the OPP interface as default. It means that > the outside of 'drivers/devfreq' can disable/enable the

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-07-04 Thread Chanwoo Choi
Hi Matthias, Firstly, I'm not sure why devfreq needs the devfreq_verify_within_limits() function. devfreq already used the OPP interface as default. It means that the outside of 'drivers/devfreq' can disable/enable the frequency such as drivers/thermal/devfreq_cooling.c. Also, when some device

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-07-04 Thread Chanwoo Choi
Hi Matthias, Firstly, I'm not sure why devfreq needs the devfreq_verify_within_limits() function. devfreq already used the OPP interface as default. It means that the outside of 'drivers/devfreq' can disable/enable the frequency such as drivers/thermal/devfreq_cooling.c. Also, when some device

[PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-07-03 Thread Matthias Kaehlcke
Policy notifiers are called before a frequency change and may narrow the min/max frequency range in devfreq_policy, which is used to adjust the target frequency if it is beyond this range. Also add a few helpers: - devfreq_verify_within_[dev_]limits() - should be used by the notifiers for

[PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-07-03 Thread Matthias Kaehlcke
Policy notifiers are called before a frequency change and may narrow the min/max frequency range in devfreq_policy, which is used to adjust the target frequency if it is beyond this range. Also add a few helpers: - devfreq_verify_within_[dev_]limits() - should be used by the notifiers for