Re: [PATCH v5 08/11] i2c: designware: Convert driver to using regmap API

2020-05-27 Thread Serge Semin
On Wed, May 27, 2020 at 07:03:37PM +0300, Andy Shevchenko wrote: > On Wed, May 27, 2020 at 06:30:43PM +0300, Serge Semin wrote: > > Seeing the DW I2C driver is using flags-based accessors with two > > conditional clauses it would be better to replace them with the regmap > > API IO methods and to

Re: [PATCH v5 08/11] i2c: designware: Convert driver to using regmap API

2020-05-27 Thread Andy Shevchenko
On Wed, May 27, 2020 at 06:30:43PM +0300, Serge Semin wrote: > Seeing the DW I2C driver is using flags-based accessors with two > conditional clauses it would be better to replace them with the regmap > API IO methods and to initialize the regmap object with read/write > callbacks specific to the

[PATCH v5 08/11] i2c: designware: Convert driver to using regmap API

2020-05-27 Thread Serge Semin
Seeing the DW I2C driver is using flags-based accessors with two conditional clauses it would be better to replace them with the regmap API IO methods and to initialize the regmap object with read/write callbacks specific to the controller registers map implementation. This will be also handy for