Re: [PATCH v5 1/1] watchdog: Add tegra watchdog

2014-02-12 Thread Guenter Roeck
On Wed, Feb 12, 2014 at 01:43:37PM -0800, Andrew Chew wrote: > > > +static void tegra_wdt_unref(struct watchdog_device *wdd) { > > > + struct tegra_wdt *wdt = watchdog_get_drvdata(wdd); > > > + > > > + kref_put(>kref, tegra_wdt_release_resources); } > > > > I forget why these were needed; they

RE: [PATCH v5 1/1] watchdog: Add tegra watchdog

2014-02-12 Thread Andrew Chew
> > +static void tegra_wdt_unref(struct watchdog_device *wdd) { > > + struct tegra_wdt *wdt = watchdog_get_drvdata(wdd); > > + > > + kref_put(>kref, tegra_wdt_release_resources); } > > I forget why these were needed; they seem to do nothing. The reason I did the whole kref thing was by

Re: [PATCH v5 1/1] watchdog: Add tegra watchdog

2014-02-12 Thread Stephen Warren
On 02/06/2014 06:54 PM, Andrew Chew wrote: > Add a driver for the hardware watchdogs in NVIDIA Tegra SoCs (Tegra30 and > later). This driver will configure one watchdog timer that will reset the > system in the case of a watchdog timeout. > > This driver binds to the nvidia,tegra30-timer device

Re: [PATCH v5 1/1] watchdog: Add tegra watchdog

2014-02-12 Thread Stephen Warren
On 02/06/2014 06:54 PM, Andrew Chew wrote: Add a driver for the hardware watchdogs in NVIDIA Tegra SoCs (Tegra30 and later). This driver will configure one watchdog timer that will reset the system in the case of a watchdog timeout. This driver binds to the nvidia,tegra30-timer device node

RE: [PATCH v5 1/1] watchdog: Add tegra watchdog

2014-02-12 Thread Andrew Chew
+static void tegra_wdt_unref(struct watchdog_device *wdd) { + struct tegra_wdt *wdt = watchdog_get_drvdata(wdd); + + kref_put(wdt-kref, tegra_wdt_release_resources); } I forget why these were needed; they seem to do nothing. The reason I did the whole kref thing was by following

Re: [PATCH v5 1/1] watchdog: Add tegra watchdog

2014-02-12 Thread Guenter Roeck
On Wed, Feb 12, 2014 at 01:43:37PM -0800, Andrew Chew wrote: +static void tegra_wdt_unref(struct watchdog_device *wdd) { + struct tegra_wdt *wdt = watchdog_get_drvdata(wdd); + + kref_put(wdt-kref, tegra_wdt_release_resources); } I forget why these were needed; they seem to do

RE: [PATCH v5 1/1] watchdog: Add tegra watchdog

2014-02-11 Thread Andrew Chew
> On 02/06/2014 05:54 PM, Andrew Chew wrote: > > Add a driver for the hardware watchdogs in NVIDIA Tegra SoCs (Tegra30 > > and later). This driver will configure one watchdog timer that will > > reset the system in the case of a watchdog timeout. > > > > This driver binds to the

RE: [PATCH v5 1/1] watchdog: Add tegra watchdog

2014-02-11 Thread Andrew Chew
On 02/06/2014 05:54 PM, Andrew Chew wrote: Add a driver for the hardware watchdogs in NVIDIA Tegra SoCs (Tegra30 and later). This driver will configure one watchdog timer that will reset the system in the case of a watchdog timeout. This driver binds to the nvidia,tegra30-timer device

Re: [PATCH v5 1/1] watchdog: Add tegra watchdog

2014-02-06 Thread Guenter Roeck
On 02/06/2014 05:54 PM, Andrew Chew wrote: Add a driver for the hardware watchdogs in NVIDIA Tegra SoCs (Tegra30 and later). This driver will configure one watchdog timer that will reset the system in the case of a watchdog timeout. This driver binds to the nvidia,tegra30-timer device node and

[PATCH v5 1/1] watchdog: Add tegra watchdog

2014-02-06 Thread Andrew Chew
Add a driver for the hardware watchdogs in NVIDIA Tegra SoCs (Tegra30 and later). This driver will configure one watchdog timer that will reset the system in the case of a watchdog timeout. This driver binds to the nvidia,tegra30-timer device node and gets its register base from there.

Re: [PATCH v5 1/1] watchdog: Add tegra watchdog

2014-02-06 Thread Guenter Roeck
On 02/06/2014 05:54 PM, Andrew Chew wrote: Add a driver for the hardware watchdogs in NVIDIA Tegra SoCs (Tegra30 and later). This driver will configure one watchdog timer that will reset the system in the case of a watchdog timeout. This driver binds to the nvidia,tegra30-timer device node and

[PATCH v5 1/1] watchdog: Add tegra watchdog

2014-02-06 Thread Andrew Chew
Add a driver for the hardware watchdogs in NVIDIA Tegra SoCs (Tegra30 and later). This driver will configure one watchdog timer that will reset the system in the case of a watchdog timeout. This driver binds to the nvidia,tegra30-timer device node and gets its register base from there.