Re: [PATCH v5 1/2] dmaengine: 8250_mtk_dma: add Mediatek uart DMA support

2018-12-17 Thread Long Cheng
On Mon, 2018-12-17 at 02:07 -0800, Sean Wang wrote: > On Mon, Dec 17, 2018 at 12:40 AM Long Cheng wrote: > > > > On Fri, 2018-12-14 at 12:09 -0800, Sean Wang wrote: > > < ... > > > > > > > > + > > > > > > + mtk_dma_chan_write(c, VFF_ADDR, cfg->src_addr); > > > > > > +

Re: [PATCH v5 1/2] dmaengine: 8250_mtk_dma: add Mediatek uart DMA support

2018-12-17 Thread Sean Wang
On Mon, Dec 17, 2018 at 12:40 AM Long Cheng wrote: > > On Fri, 2018-12-14 at 12:09 -0800, Sean Wang wrote: < ... > > > > > > + > > > > > + mtk_dma_chan_write(c, VFF_ADDR, cfg->src_addr); > > > > > + mtk_dma_chan_write(c, VFF_LEN, rx_len); > > > > > +

Re: [PATCH v5 1/2] dmaengine: 8250_mtk_dma: add Mediatek uart DMA support

2018-12-17 Thread Long Cheng
On Fri, 2018-12-14 at 12:09 -0800, Sean Wang wrote: thanks for your reply. > On Thu, Dec 13, 2018 at 3:36 AM Long Cheng wrote: > > Hope those comments did not get a response that means they're fine with you. > > < ... > > > > > > +struct mtk_dmadev { > > > > + struct dma_device ddev; >

Re: [PATCH v5 1/2] dmaengine: 8250_mtk_dma: add Mediatek uart DMA support

2018-12-14 Thread Sean Wang
On Thu, Dec 13, 2018 at 3:36 AM Long Cheng wrote: Hope those comments did not get a response that means they're fine with you. < ... > > > > +struct mtk_dmadev { > > > + struct dma_device ddev; > > > + void __iomem *mem_base[MTK_APDMA_CHANNELS]; > > > + spinlock_t lock; /*

Re: [PATCH v5 1/2] dmaengine: 8250_mtk_dma: add Mediatek uart DMA support

2018-12-13 Thread Long Cheng
On Tue, 2018-12-11 at 15:12 -0800, Sean Wang wrote: > Sorry for that I didn't have a full review at one time in the earlier version > >On Mon, Dec 10, 2018 at 9:37 PM Long Cheng > wrote: > > > > In DMA engine framework, add 8250 mtk dma to support it. > > It looks like there are still

Re: [PATCH v5 1/2] dmaengine: 8250_mtk_dma: add Mediatek uart DMA support

2018-12-11 Thread Sean Wang
Sorry for that I didn't have a full review at one time in the earlier version On Mon, Dec 10, 2018 at 9:37 PM Long Cheng wrote: > > In DMA engine framework, add 8250 mtk dma to support it. It looks like there are still many rooms to improve the description, especially it's a totally new

[PATCH v5 1/2] dmaengine: 8250_mtk_dma: add Mediatek uart DMA support

2018-12-10 Thread Long Cheng
In DMA engine framework, add 8250 mtk dma to support it. Signed-off-by: Long Cheng --- drivers/dma/mediatek/8250_mtk_dma.c | 830 +++ drivers/dma/mediatek/Kconfig| 11 + drivers/dma/mediatek/Makefile |1 + 3 files changed, 842 insertions(+)