Re: [PATCH v5 1/2] dt-bindings: regulator: add support for MT6392

2020-10-28 Thread Mark Brown
On Tue, Oct 27, 2020 at 10:16:22PM +0100, Fabien Parent wrote: > You are correct, the regulator driver is running and probes > successfully. From my investigation it seems the failure when removing > the compatible string from the MFD and the DTS is because the > regulator driver does not have a

Re: [PATCH v5 1/2] dt-bindings: regulator: add support for MT6392

2020-10-28 Thread Fabien Parent
On Wed, Oct 28, 2020 at 1:33 PM Mark Brown wrote: > > You should be using the of_node from the parent device to find the > regulators set, look at how other drivers do this. Thanks for the help. I got it to work. I will send a new revision of the patches.

Re: [PATCH v5 1/2] dt-bindings: regulator: add support for MT6392

2020-10-27 Thread Fabien Parent
Hi Mark, On Mon, Oct 26, 2020 at 9:36 PM Mark Brown wrote: > > On Mon, Oct 26, 2020 at 07:38:14PM +0100, Fabien Parent wrote: > > On Mon, Oct 26, 2020 at 6:24 PM Mark Brown wrote: > > > > > .name = "mt6392-regulator", > > > > .of_compatible = "mediatek,mt6392-regulator" > > > >

Re: [PATCH v5 1/2] dt-bindings: regulator: add support for MT6392

2020-10-26 Thread Mark Brown
On Mon, Oct 26, 2020 at 07:38:14PM +0100, Fabien Parent wrote: > On Mon, Oct 26, 2020 at 6:24 PM Mark Brown wrote: > > > .name = "mt6392-regulator", > > > .of_compatible = "mediatek,mt6392-regulator" > > This is still unneeded, it's just a reflection of Linux implementation > >

Re: [PATCH v5 1/2] dt-bindings: regulator: add support for MT6392

2020-10-26 Thread Fabien Parent
Hi Mark, On Mon, Oct 26, 2020 at 6:24 PM Mark Brown wrote: > > On Mon, Oct 26, 2020 at 06:18:35PM +0100, Fabien Parent wrote: > > On Mon, Oct 26, 2020 at 1:13 PM Mark Brown wrote: > > > > On Sat, Oct 24, 2020 at 10:03:03PM +0200, Fabien Parent wrote: > > > > > +Required properties: > > > > +-

Re: [PATCH v5 1/2] dt-bindings: regulator: add support for MT6392

2020-10-26 Thread Mark Brown
On Mon, Oct 26, 2020 at 06:18:35PM +0100, Fabien Parent wrote: > On Mon, Oct 26, 2020 at 1:13 PM Mark Brown wrote: > > On Sat, Oct 24, 2020 at 10:03:03PM +0200, Fabien Parent wrote: > > > +Required properties: > > > +- compatible: "mediatek,mt6392-regulator" > > This is no longer used by the

Re: [PATCH v5 1/2] dt-bindings: regulator: add support for MT6392

2020-10-26 Thread Fabien Parent
Hi Mark, On Mon, Oct 26, 2020 at 1:13 PM Mark Brown wrote: > > On Sat, Oct 24, 2020 at 10:03:03PM +0200, Fabien Parent wrote: > > > +Required properties: > > +- compatible: "mediatek,mt6392-regulator" > > This is no longer used by the driver, should be unneeded and therefore > should be removed.

Re: [PATCH v5 1/2] dt-bindings: regulator: add support for MT6392

2020-10-26 Thread Mark Brown
On Sat, Oct 24, 2020 at 10:03:03PM +0200, Fabien Parent wrote: > +Required properties: > +- compatible: "mediatek,mt6392-regulator" This is no longer used by the driver, should be unneeded and therefore should be removed. > +- mt6392regulator: List of regulators provided by this controller. It

[PATCH v5 1/2] dt-bindings: regulator: add support for MT6392

2020-10-24 Thread Fabien Parent
Add binding documentation of the regulator for MT6392 SoCs. Signed-off-by: Fabien Parent Reviewed-by: Rob Herring --- v5: * No change v4: * No change v3: * No change v2: * Use 'pmic' as node name for the pmic. * Use 'regulators' as node name for the