Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-03-11 Thread Beomho Seo
On 03/11/2015 08:06 PM, Paul Bolle wrote: > On Mon, 2015-03-09 at 10:23 +0900, Beomho Seo wrote: >> --- /dev/null >> +++ b/drivers/power/rt5033_charger.c >> @@ -0,0 +1,485 @@ >> +/* >> + * Battery charger driver for RT5033 >> + * >> + * Copyright (C) 2014 Samsung Electronics, Co., Ltd. >> + *

Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-03-11 Thread Paul Bolle
On Mon, 2015-03-09 at 10:23 +0900, Beomho Seo wrote: > --- /dev/null > +++ b/drivers/power/rt5033_charger.c > @@ -0,0 +1,485 @@ > +/* > + * Battery charger driver for RT5033 > + * > + * Copyright (C) 2014 Samsung Electronics, Co., Ltd. > + * Author: Beomho Seo > + * > + * This program is free

Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-03-11 Thread Beomho Seo
On 03/11/2015 08:06 PM, Paul Bolle wrote: On Mon, 2015-03-09 at 10:23 +0900, Beomho Seo wrote: --- /dev/null +++ b/drivers/power/rt5033_charger.c @@ -0,0 +1,485 @@ +/* + * Battery charger driver for RT5033 + * + * Copyright (C) 2014 Samsung Electronics, Co., Ltd. + * Author: Beomho Seo

Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-03-11 Thread Paul Bolle
On Mon, 2015-03-09 at 10:23 +0900, Beomho Seo wrote: --- /dev/null +++ b/drivers/power/rt5033_charger.c @@ -0,0 +1,485 @@ +/* + * Battery charger driver for RT5033 + * + * Copyright (C) 2014 Samsung Electronics, Co., Ltd. + * Author: Beomho Seo beomho@samsung.com + * + * This program

Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-03-09 Thread Sebastian Reichel
Hi, On Mon, Mar 09, 2015 at 01:53:58PM +0900, Beomho Seo wrote: > >> remove the special handling of POWER_SUPPLY_PROP_CURRENT_MAX in > >> rt5033_get_charger_current() and do it like this: > >> > >> case POWER_SUPPLY_PROP_CURRENT_NOW: > >> val->intval = rt5033_get_charger_current(charger); >

Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-03-09 Thread Sebastian Reichel
Hi, On Mon, Mar 09, 2015 at 01:53:58PM +0900, Beomho Seo wrote: remove the special handling of POWER_SUPPLY_PROP_CURRENT_MAX in rt5033_get_charger_current() and do it like this: case POWER_SUPPLY_PROP_CURRENT_NOW: val-intval = rt5033_get_charger_current(charger); break;

Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-03-08 Thread Beomho Seo
On 03/09/2015 12:46 PM, Beomho Seo wrote: > On 03/09/2015 10:50 AM, Sebastian Reichel wrote: >> Hi Beomho, >> >> On Mon, Mar 09, 2015 at 10:23:10AM +0900, Beomho Seo wrote: >>> This patch add device driver of Richtek RT5033 PMIC. The driver support >>> switching charger. rt5033 charger provide

Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-03-08 Thread Beomho Seo
On 03/09/2015 10:50 AM, Sebastian Reichel wrote: > Hi Beomho, > > On Mon, Mar 09, 2015 at 10:23:10AM +0900, Beomho Seo wrote: >> This patch add device driver of Richtek RT5033 PMIC. The driver support >> switching charger. rt5033 charger provide three charging mode. >> Three charging mode are pre

Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-03-08 Thread Sebastian Reichel
Hi Beomho, On Mon, Mar 09, 2015 at 10:23:10AM +0900, Beomho Seo wrote: > This patch add device driver of Richtek RT5033 PMIC. The driver support > switching charger. rt5033 charger provide three charging mode. > Three charging mode are pre charge mode, fast cahrge mode and constant voltage >

[PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-03-08 Thread Beomho Seo
This patch add device driver of Richtek RT5033 PMIC. The driver support switching charger. rt5033 charger provide three charging mode. Three charging mode are pre charge mode, fast cahrge mode and constant voltage mode. They are have vary charge rate, charge parameters. The charge parameters can

[PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-03-08 Thread Beomho Seo
This patch add device driver of Richtek RT5033 PMIC. The driver support switching charger. rt5033 charger provide three charging mode. Three charging mode are pre charge mode, fast cahrge mode and constant voltage mode. They are have vary charge rate, charge parameters. The charge parameters can

Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-03-08 Thread Sebastian Reichel
Hi Beomho, On Mon, Mar 09, 2015 at 10:23:10AM +0900, Beomho Seo wrote: This patch add device driver of Richtek RT5033 PMIC. The driver support switching charger. rt5033 charger provide three charging mode. Three charging mode are pre charge mode, fast cahrge mode and constant voltage mode.

Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-03-08 Thread Beomho Seo
On 03/09/2015 10:50 AM, Sebastian Reichel wrote: Hi Beomho, On Mon, Mar 09, 2015 at 10:23:10AM +0900, Beomho Seo wrote: This patch add device driver of Richtek RT5033 PMIC. The driver support switching charger. rt5033 charger provide three charging mode. Three charging mode are pre charge

Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-03-08 Thread Beomho Seo
On 03/09/2015 12:46 PM, Beomho Seo wrote: On 03/09/2015 10:50 AM, Sebastian Reichel wrote: Hi Beomho, On Mon, Mar 09, 2015 at 10:23:10AM +0900, Beomho Seo wrote: This patch add device driver of Richtek RT5033 PMIC. The driver support switching charger. rt5033 charger provide three charging