Re: [PATCH v5 1/2] soc: samsung: add exynos chipid driver support

2015-01-12 Thread Pankaj Dubey
Hi Arnd, Sorry for late reply. On Friday 12 December 2014 05:01 PM, Arnd Bergmann wrote: On Friday 12 December 2014 13:15:43 Pankaj Dubey wrote: + +static void __iomem *exynos_chipid_base; + +struct exynos_chipid_info exynos_soc_info; +EXPORT_SYMBOL(exynos_soc_info); The soc_device already

Re: [PATCH v5 1/2] soc: samsung: add exynos chipid driver support

2015-01-12 Thread Pankaj Dubey
Hi Arnd, Sorry for late reply. On Friday 12 December 2014 05:01 PM, Arnd Bergmann wrote: On Friday 12 December 2014 13:15:43 Pankaj Dubey wrote: + +static void __iomem *exynos_chipid_base; + +struct exynos_chipid_info exynos_soc_info; +EXPORT_SYMBOL(exynos_soc_info); The soc_device already

Re: [PATCH v5 1/2] soc: samsung: add exynos chipid driver support

2014-12-13 Thread Rob Herring
On Fri, Dec 12, 2014 at 1:45 AM, Pankaj Dubey wrote: > Hi Rob, > > On Thursday 11 December 2014 11:00 PM, Rob Herring wrote: >> >> On Thu, Dec 11, 2014 at 2:07 AM, Pankaj Dubey >> wrote: >>> >>> Exynos SoCs have Chipid, for identification of product IDs >>> and SoC revisions. This patch intendes

Re: [PATCH v5 1/2] soc: samsung: add exynos chipid driver support

2014-12-13 Thread Rob Herring
On Fri, Dec 12, 2014 at 1:45 AM, Pankaj Dubey pankaj.du...@samsung.com wrote: Hi Rob, On Thursday 11 December 2014 11:00 PM, Rob Herring wrote: On Thu, Dec 11, 2014 at 2:07 AM, Pankaj Dubey pankaj.du...@samsung.com wrote: Exynos SoCs have Chipid, for identification of product IDs and SoC

Re: [PATCH v5 1/2] soc: samsung: add exynos chipid driver support

2014-12-12 Thread Arnd Bergmann
On Friday 12 December 2014 13:15:43 Pankaj Dubey wrote: > >> + > >> +static void __iomem *exynos_chipid_base; > >> + > >> +struct exynos_chipid_info exynos_soc_info; > >> +EXPORT_SYMBOL(exynos_soc_info); > > > > The soc_device already has similar data.Why is this needed? Is it > > temporary for

Re: [PATCH v5 1/2] soc: samsung: add exynos chipid driver support

2014-12-12 Thread Arnd Bergmann
On Friday 12 December 2014 13:15:43 Pankaj Dubey wrote: + +static void __iomem *exynos_chipid_base; + +struct exynos_chipid_info exynos_soc_info; +EXPORT_SYMBOL(exynos_soc_info); The soc_device already has similar data.Why is this needed? Is it temporary for compatibility?

Re: [PATCH v5 1/2] soc: samsung: add exynos chipid driver support

2014-12-11 Thread Pankaj Dubey
Hi Rob, On Thursday 11 December 2014 11:00 PM, Rob Herring wrote: On Thu, Dec 11, 2014 at 2:07 AM, Pankaj Dubey wrote: Exynos SoCs have Chipid, for identification of product IDs and SoC revisions. This patch intendes to provide initialization code for all these functionalites. This driver

Re: [PATCH v5 1/2] soc: samsung: add exynos chipid driver support

2014-12-11 Thread Rob Herring
On Thu, Dec 11, 2014 at 2:07 AM, Pankaj Dubey wrote: > Exynos SoCs have Chipid, for identification of product IDs > and SoC revisions. This patch intendes to provide initialization > code for all these functionalites. > > This driver usese existing binding for exnos-chipid. s/usese/uses/

[PATCH v5 1/2] soc: samsung: add exynos chipid driver support

2014-12-11 Thread Pankaj Dubey
Exynos SoCs have Chipid, for identification of product IDs and SoC revisions. This patch intendes to provide initialization code for all these functionalites. This driver usese existing binding for exnos-chipid. CC: Grant Likely CC: Rob Herring CC: Linus Walleij Signed-off-by: Pankaj Dubey

[PATCH v5 1/2] soc: samsung: add exynos chipid driver support

2014-12-11 Thread Pankaj Dubey
Exynos SoCs have Chipid, for identification of product IDs and SoC revisions. This patch intendes to provide initialization code for all these functionalites. This driver usese existing binding for exnos-chipid. CC: Grant Likely grant.lik...@linaro.org CC: Rob Herring robh...@kernel.org CC:

Re: [PATCH v5 1/2] soc: samsung: add exynos chipid driver support

2014-12-11 Thread Rob Herring
On Thu, Dec 11, 2014 at 2:07 AM, Pankaj Dubey pankaj.du...@samsung.com wrote: Exynos SoCs have Chipid, for identification of product IDs and SoC revisions. This patch intendes to provide initialization code for all these functionalites. This driver usese existing binding for exnos-chipid.

Re: [PATCH v5 1/2] soc: samsung: add exynos chipid driver support

2014-12-11 Thread Pankaj Dubey
Hi Rob, On Thursday 11 December 2014 11:00 PM, Rob Herring wrote: On Thu, Dec 11, 2014 at 2:07 AM, Pankaj Dubey pankaj.du...@samsung.com wrote: Exynos SoCs have Chipid, for identification of product IDs and SoC revisions. This patch intendes to provide initialization code for all these