Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

2016-02-16 Thread Tadeusz Struk
Hi David, On 02/11/2016 02:08 AM, David Howells wrote: > David Howells wrote: > >> > Tadeusz Struk wrote: >> > > > > Why didn't you put the RSA signature parsing - ie. where the OID and > > > the other > > > bits are checked - into

Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

2016-02-16 Thread Tadeusz Struk
Hi David, On 02/11/2016 02:08 AM, David Howells wrote: > David Howells wrote: > >> > Tadeusz Struk wrote: >> > > > > Why didn't you put the RSA signature parsing - ie. where the OID and > > > the other > > > bits are checked - into crypto/rsa.c? > > > >>> > > >>> > > Do

Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

2016-02-11 Thread David Howells
David Howells wrote: > Tadeusz Struk wrote: > > > > Why didn't you put the RSA signature parsing - ie. where the OID and the > > > other > > > bits are checked - into crypto/rsa.c? > > > > > > > Do you want to get rid of the crypto/asymmetric_keys/rsa.c completely? > > I wanted to make the

Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

2016-02-11 Thread David Howells
Tadeusz Struk wrote: > > Why didn't you put the RSA signature parsing - ie. where the OID and the > > other > > bits are checked - into crypto/rsa.c? > > > > Do you want to get rid of the crypto/asymmetric_keys/rsa.c completely? > I wanted to make the conversion churn as small as possible. >

Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

2016-02-11 Thread David Howells
Tadeusz Struk wrote: > > Why didn't you put the RSA signature parsing - ie. where the OID and the > > other > > bits are checked - into crypto/rsa.c? > > > > Do you want to get rid of the crypto/asymmetric_keys/rsa.c completely? > I wanted to make the conversion churn

Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

2016-02-11 Thread David Howells
David Howells wrote: > Tadeusz Struk wrote: > > > > Why didn't you put the RSA signature parsing - ie. where the OID and the > > > other > > > bits are checked - into crypto/rsa.c? > > > > > > > Do you want to get rid of the

Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

2016-02-10 Thread Tadeusz Struk
Hi David, On 02/10/2016 06:17 AM, David Howells wrote: > Why didn't you put the RSA signature parsing - ie. where the OID and the other > bits are checked - into crypto/rsa.c? > Do you want to get rid of the crypto/asymmetric_keys/rsa.c completely? I wanted to make the conversion churn as small

Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

2016-02-10 Thread David Howells
Why didn't you put the RSA signature parsing - ie. where the OID and the other bits are checked - into crypto/rsa.c? David

Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

2016-02-10 Thread David Howells
Why didn't you put the RSA signature parsing - ie. where the OID and the other bits are checked - into crypto/rsa.c? David

Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

2016-02-10 Thread Tadeusz Struk
Hi David, On 02/10/2016 06:17 AM, David Howells wrote: > Why didn't you put the RSA signature parsing - ie. where the OID and the other > bits are checked - into crypto/rsa.c? > Do you want to get rid of the crypto/asymmetric_keys/rsa.c completely? I wanted to make the conversion churn as small

[PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

2016-02-02 Thread Tadeusz Struk
This patch converts the module verification code to the new akcipher API. Signed-off-by: Tadeusz Struk --- crypto/asymmetric_keys/Kconfig|2 crypto/asymmetric_keys/Makefile |7 - crypto/asymmetric_keys/pkcs7_parser.c | 12 +-

[PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

2016-02-02 Thread Tadeusz Struk
This patch converts the module verification code to the new akcipher API. Signed-off-by: Tadeusz Struk --- crypto/asymmetric_keys/Kconfig|2 crypto/asymmetric_keys/Makefile |7 - crypto/asymmetric_keys/pkcs7_parser.c | 12 +-

[PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

2015-12-23 Thread Tadeusz Struk
This patch converts the module verification code to the new akcipher API. Signed-off-by: Tadeusz Struk --- crypto/asymmetric_keys/Kconfig|2 crypto/asymmetric_keys/Makefile |7 - crypto/asymmetric_keys/pkcs7_parser.c | 12 +-

[PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

2015-12-23 Thread Tadeusz Struk
This patch converts the module verification code to the new akcipher API. Signed-off-by: Tadeusz Struk --- crypto/asymmetric_keys/Kconfig|2 crypto/asymmetric_keys/Makefile |7 - crypto/asymmetric_keys/pkcs7_parser.c | 12 +-