Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-07-01 Thread Michael Holzheu
On Mon, 1 Jul 2013 13:37:27 -0400 Vivek Goyal wrote: > On Fri, Jun 28, 2013 at 10:15:52AM +0200, Michael Holzheu wrote: > > On Thu, 27 Jun 2013 16:23:34 -0400 > > Vivek Goyal wrote: > > > > > On Thu, Jun 27, 2013 at 03:32:02PM -0400, Vivek Goyal wrote: > > > > On Fri, Jun 21, 2013 at

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-07-01 Thread Vivek Goyal
On Fri, Jun 28, 2013 at 10:15:52AM +0200, Michael Holzheu wrote: > On Thu, 27 Jun 2013 16:23:34 -0400 > Vivek Goyal wrote: > > > On Thu, Jun 27, 2013 at 03:32:02PM -0400, Vivek Goyal wrote: > > > On Fri, Jun 21, 2013 at 04:17:03PM +0200, Michael Holzheu wrote: > > > > On Fri, 14 Jun 2013

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-07-01 Thread Vivek Goyal
On Fri, Jun 28, 2013 at 10:15:52AM +0200, Michael Holzheu wrote: On Thu, 27 Jun 2013 16:23:34 -0400 Vivek Goyal vgo...@redhat.com wrote: On Thu, Jun 27, 2013 at 03:32:02PM -0400, Vivek Goyal wrote: On Fri, Jun 21, 2013 at 04:17:03PM +0200, Michael Holzheu wrote: On Fri, 14 Jun 2013

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-07-01 Thread Michael Holzheu
On Mon, 1 Jul 2013 13:37:27 -0400 Vivek Goyal vgo...@redhat.com wrote: On Fri, Jun 28, 2013 at 10:15:52AM +0200, Michael Holzheu wrote: On Thu, 27 Jun 2013 16:23:34 -0400 Vivek Goyal vgo...@redhat.com wrote: On Thu, Jun 27, 2013 at 03:32:02PM -0400, Vivek Goyal wrote: On Fri, Jun

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-28 Thread Michael Holzheu
On Thu, 27 Jun 2013 16:23:34 -0400 Vivek Goyal wrote: > On Thu, Jun 27, 2013 at 03:32:02PM -0400, Vivek Goyal wrote: > > On Fri, Jun 21, 2013 at 04:17:03PM +0200, Michael Holzheu wrote: > > > On Fri, 14 Jun 2013 14:54:02 -0400 > > > Vivek Goyal wrote: [snip] > Thinking more about it, I think

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-28 Thread Michael Holzheu
On Thu, 27 Jun 2013 16:23:34 -0400 Vivek Goyal vgo...@redhat.com wrote: On Thu, Jun 27, 2013 at 03:32:02PM -0400, Vivek Goyal wrote: On Fri, Jun 21, 2013 at 04:17:03PM +0200, Michael Holzheu wrote: On Fri, 14 Jun 2013 14:54:02 -0400 Vivek Goyal vgo...@redhat.com wrote: [snip] Thinking

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-27 Thread Vivek Goyal
On Thu, Jun 27, 2013 at 03:32:02PM -0400, Vivek Goyal wrote: > On Fri, Jun 21, 2013 at 04:17:03PM +0200, Michael Holzheu wrote: > > On Fri, 14 Jun 2013 14:54:02 -0400 > > Vivek Goyal wrote: > > > > > On Fri, Jun 07, 2013 at 06:55:57PM +0200, Michael Holzheu wrote: > > > > > > [..] > > > > @@

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-27 Thread Cliff Wickman
On Thu, Jun 27, 2013 at 03:32:02PM -0400, Vivek Goyal wrote: > On Fri, Jun 21, 2013 at 04:17:03PM +0200, Michael Holzheu wrote: > > On Fri, 14 Jun 2013 14:54:02 -0400 > > Vivek Goyal wrote: > > > > > On Fri, Jun 07, 2013 at 06:55:57PM +0200, Michael Holzheu wrote: > > > > > > [..] > > > > @@

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-27 Thread Vivek Goyal
On Fri, Jun 21, 2013 at 04:17:03PM +0200, Michael Holzheu wrote: > On Fri, 14 Jun 2013 14:54:02 -0400 > Vivek Goyal wrote: > > > On Fri, Jun 07, 2013 at 06:55:57PM +0200, Michael Holzheu wrote: > > > > [..] > > > @@ -935,10 +967,17 @@ static int __init vmcore_init(void) > > > { > > > int rc

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-27 Thread Vivek Goyal
On Fri, Jun 21, 2013 at 04:17:03PM +0200, Michael Holzheu wrote: On Fri, 14 Jun 2013 14:54:02 -0400 Vivek Goyal vgo...@redhat.com wrote: On Fri, Jun 07, 2013 at 06:55:57PM +0200, Michael Holzheu wrote: [..] @@ -935,10 +967,17 @@ static int __init vmcore_init(void) { int rc =

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-27 Thread Cliff Wickman
On Thu, Jun 27, 2013 at 03:32:02PM -0400, Vivek Goyal wrote: On Fri, Jun 21, 2013 at 04:17:03PM +0200, Michael Holzheu wrote: On Fri, 14 Jun 2013 14:54:02 -0400 Vivek Goyal vgo...@redhat.com wrote: On Fri, Jun 07, 2013 at 06:55:57PM +0200, Michael Holzheu wrote: [..] @@

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-27 Thread Vivek Goyal
On Thu, Jun 27, 2013 at 03:32:02PM -0400, Vivek Goyal wrote: On Fri, Jun 21, 2013 at 04:17:03PM +0200, Michael Holzheu wrote: On Fri, 14 Jun 2013 14:54:02 -0400 Vivek Goyal vgo...@redhat.com wrote: On Fri, Jun 07, 2013 at 06:55:57PM +0200, Michael Holzheu wrote: [..] @@

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-21 Thread Michael Holzheu
On Fri, 14 Jun 2013 14:54:02 -0400 Vivek Goyal wrote: > On Fri, Jun 07, 2013 at 06:55:57PM +0200, Michael Holzheu wrote: > > [..] > > @@ -935,10 +967,17 @@ static int __init vmcore_init(void) > > { > > int rc = 0; > > > > - /* If elfcorehdr= has been passed in cmdline, then capture the

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-21 Thread Michael Holzheu
On Fri, 14 Jun 2013 14:54:02 -0400 Vivek Goyal vgo...@redhat.com wrote: On Fri, Jun 07, 2013 at 06:55:57PM +0200, Michael Holzheu wrote: [..] @@ -935,10 +967,17 @@ static int __init vmcore_init(void) { int rc = 0; - /* If elfcorehdr= has been passed in cmdline, then capture

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-14 Thread Vivek Goyal
On Fri, Jun 07, 2013 at 06:55:57PM +0200, Michael Holzheu wrote: [..] > @@ -935,10 +967,17 @@ static int __init vmcore_init(void) > { > int rc = 0; > > - /* If elfcorehdr= has been passed in cmdline, then capture the dump.*/ > - if (!(is_vmcore_usable())) > - return

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-14 Thread Vivek Goyal
On Fri, Jun 07, 2013 at 06:55:57PM +0200, Michael Holzheu wrote: [..] @@ -935,10 +967,17 @@ static int __init vmcore_init(void) { int rc = 0; - /* If elfcorehdr= has been passed in cmdline, then capture the dump.*/ - if (!(is_vmcore_usable())) - return rc; +

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-10 Thread Michael Holzheu
On Mon, 10 Jun 2013 22:35:30 +0900 HATAYAMA Daisuke wrote: > 2013/6/8 Michael Holzheu : > > > @@ -935,10 +967,17 @@ static int __init vmcore_init(void) > > { > > int rc = 0; > > > > - /* If elfcorehdr= has been passed in cmdline, then capture the > > dump.*/ > > - if

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-10 Thread HATAYAMA Daisuke
2013/6/8 Michael Holzheu : > @@ -935,10 +967,17 @@ static int __init vmcore_init(void) > { > int rc = 0; > > - /* If elfcorehdr= has been passed in cmdline, then capture the dump.*/ > - if (!(is_vmcore_usable())) > - return rc; > + /* > +* If

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-10 Thread HATAYAMA Daisuke
2013/6/8 Michael Holzheu holz...@linux.vnet.ibm.com: cut @@ -935,10 +967,17 @@ static int __init vmcore_init(void) { int rc = 0; - /* If elfcorehdr= has been passed in cmdline, then capture the dump.*/ - if (!(is_vmcore_usable())) - return rc; + /*

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-10 Thread Michael Holzheu
On Mon, 10 Jun 2013 22:35:30 +0900 HATAYAMA Daisuke d.hatay...@gmail.com wrote: 2013/6/8 Michael Holzheu holz...@linux.vnet.ibm.com: cut @@ -935,10 +967,17 @@ static int __init vmcore_init(void) { int rc = 0; - /* If elfcorehdr= has been passed in cmdline, then capture

[PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-07 Thread Michael Holzheu
Currently for s390 we create the ELF core header in the 2nd kernel with a small trick. We relocate the addresses in the ELF header in a way that for the /proc/vmcore code it seems to be in the 1st kernel (old) memory and the read_from_oldmem() returns the correct data. This allows the /proc/vmcore

[PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-07 Thread Michael Holzheu
Currently for s390 we create the ELF core header in the 2nd kernel with a small trick. We relocate the addresses in the ELF header in a way that for the /proc/vmcore code it seems to be in the 1st kernel (old) memory and the read_from_oldmem() returns the correct data. This allows the /proc/vmcore