Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-06 Thread Sven Van Asbroeck
Hi Greg, On Thu, Dec 6, 2018 at 9:07 AM Greg KH wrote: > > And as these are really devices, why not make them a "device" and a bus? > What type of topology do you have on these busses? Are everything > "flat" and connected directly to a PCI/USB/platform device? Or are > there multiple devices

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-06 Thread Sven Van Asbroeck
Hi Greg, On Thu, Dec 6, 2018 at 9:07 AM Greg KH wrote: > > And as these are really devices, why not make them a "device" and a bus? > What type of topology do you have on these busses? Are everything > "flat" and connected directly to a PCI/USB/platform device? Or are > there multiple devices

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-06 Thread Greg KH
On Wed, Dec 05, 2018 at 05:32:19PM -0500, Sven Van Asbroeck wrote: > Thanks :) > > On Wed, Dec 5, 2018 at 2:17 PM Greg KH wrote: > > > > Great, then call it a 'fieldbus' class, not "fieldbus_dev' class. > > Small nit: > > Hardware connected to a fieldbus comes in two distinct flavours: > -

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-06 Thread Greg KH
On Wed, Dec 05, 2018 at 05:32:19PM -0500, Sven Van Asbroeck wrote: > Thanks :) > > On Wed, Dec 5, 2018 at 2:17 PM Greg KH wrote: > > > > Great, then call it a 'fieldbus' class, not "fieldbus_dev' class. > > Small nit: > > Hardware connected to a fieldbus comes in two distinct flavours: > -

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-05 Thread Arnd Bergmann
On Wed, Dec 5, 2018 at 11:32 PM Sven Van Asbroeck wrote: > On Wed, Dec 5, 2018 at 2:17 PM Greg KH wrote: > > > > Great, then call it a 'fieldbus' class, not "fieldbus_dev' class. > > Small nit: > > Hardware connected to a fieldbus comes in two distinct flavours: > - clients (e.g. thermometer,

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-05 Thread Arnd Bergmann
On Wed, Dec 5, 2018 at 11:32 PM Sven Van Asbroeck wrote: > On Wed, Dec 5, 2018 at 2:17 PM Greg KH wrote: > > > > Great, then call it a 'fieldbus' class, not "fieldbus_dev' class. > > Small nit: > > Hardware connected to a fieldbus comes in two distinct flavours: > - clients (e.g. thermometer,

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-05 Thread Sven Van Asbroeck
Thanks :) On Wed, Dec 5, 2018 at 2:17 PM Greg KH wrote: > > Great, then call it a 'fieldbus' class, not "fieldbus_dev' class. Small nit: Hardware connected to a fieldbus comes in two distinct flavours: - clients (e.g. thermometer, robotic arm) called "fieldbus devices" - servers (e.g. a PLC)

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-05 Thread Sven Van Asbroeck
Thanks :) On Wed, Dec 5, 2018 at 2:17 PM Greg KH wrote: > > Great, then call it a 'fieldbus' class, not "fieldbus_dev' class. Small nit: Hardware connected to a fieldbus comes in two distinct flavours: - clients (e.g. thermometer, robotic arm) called "fieldbus devices" - servers (e.g. a PLC)

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-05 Thread Greg KH
On Wed, Dec 05, 2018 at 10:39:56AM -0500, Sven Van Asbroeck wrote: > Hello Greg, thanks for the feedback! > > On Wed, Dec 5, 2018 at 5:17 AM Greg KH wrote: > > And why is this a class and not just a "normal" device and bus? Devices > > live on busses, not generally as a class. Can your devices

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-05 Thread Greg KH
On Wed, Dec 05, 2018 at 10:39:56AM -0500, Sven Van Asbroeck wrote: > Hello Greg, thanks for the feedback! > > On Wed, Dec 5, 2018 at 5:17 AM Greg KH wrote: > > And why is this a class and not just a "normal" device and bus? Devices > > live on busses, not generally as a class. Can your devices

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-05 Thread Sven Van Asbroeck
Hello Greg, thanks for the feedback! On Wed, Dec 5, 2018 at 5:17 AM Greg KH wrote: > And why is this a class and not just a "normal" device and bus? Devices > live on busses, not generally as a class. Can your devices live on > different types of busses (USB, PCI, etc.)? This patchset can be

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-05 Thread Sven Van Asbroeck
Hello Greg, thanks for the feedback! On Wed, Dec 5, 2018 at 5:17 AM Greg KH wrote: > And why is this a class and not just a "normal" device and bus? Devices > live on busses, not generally as a class. Can your devices live on > different types of busses (USB, PCI, etc.)? This patchset can be

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-05 Thread Greg KH
On Tue, Dec 04, 2018 at 05:02:19PM -0500, Sven Van Asbroeck wrote: > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-class-fieldbus-dev > @@ -0,0 +1,63 @@ > +What:/sys/class/fieldbus_dev/fieldbus_devX/card_name Here's a good example of your naming being a bit too "verbose"

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-05 Thread Greg KH
On Tue, Dec 04, 2018 at 05:02:19PM -0500, Sven Van Asbroeck wrote: > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-class-fieldbus-dev > @@ -0,0 +1,63 @@ > +What:/sys/class/fieldbus_dev/fieldbus_devX/card_name Here's a good example of your naming being a bit too "verbose"

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-04 Thread Randy Dunlap
On 12/4/18 2:02 PM, Sven Van Asbroeck wrote: > Fieldbus device (client) adapters allow data exchange with a PLC aka. > "Fieldbus Controller" over a fieldbus (Profinet, FLNet, etc.) > > They are typically used when a Linux device wants to expose itself > as an actuator, motor, console light,

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-04 Thread Randy Dunlap
On 12/4/18 2:02 PM, Sven Van Asbroeck wrote: > Fieldbus device (client) adapters allow data exchange with a PLC aka. > "Fieldbus Controller" over a fieldbus (Profinet, FLNet, etc.) > > They are typically used when a Linux device wants to expose itself > as an actuator, motor, console light,

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-04 Thread Randy Dunlap
On 12/4/18 2:02 PM, Sven Van Asbroeck wrote: > diff --git a/drivers/fieldbus/Kconfig b/drivers/fieldbus/Kconfig > new file mode 100644 > index ..1d1929ba7e27 > --- /dev/null > +++ b/drivers/fieldbus/Kconfig > @@ -0,0 +1,19 @@ > +menuconfig FIELDBUS_DEV > +bool "Fieldbus Device

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-04 Thread Randy Dunlap
On 12/4/18 2:02 PM, Sven Van Asbroeck wrote: > diff --git a/drivers/fieldbus/Kconfig b/drivers/fieldbus/Kconfig > new file mode 100644 > index ..1d1929ba7e27 > --- /dev/null > +++ b/drivers/fieldbus/Kconfig > @@ -0,0 +1,19 @@ > +menuconfig FIELDBUS_DEV > +bool "Fieldbus Device

[PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-04 Thread Sven Van Asbroeck
Fieldbus device (client) adapters allow data exchange with a PLC aka. "Fieldbus Controller" over a fieldbus (Profinet, FLNet, etc.) They are typically used when a Linux device wants to expose itself as an actuator, motor, console light, switch, etc. over the fieldbus. This framework is designed

[PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-04 Thread Sven Van Asbroeck
Fieldbus device (client) adapters allow data exchange with a PLC aka. "Fieldbus Controller" over a fieldbus (Profinet, FLNet, etc.) They are typically used when a Linux device wants to expose itself as an actuator, motor, console light, switch, etc. over the fieldbus. This framework is designed