Re: [PATCH v5 1/8] perf: Add a flags parameter to pmu txn interfaces

Peter Zijlstra [pet...@infradead.org] wrote: | | when looking at this (I almost pressed A for apply) it occurred to me | that we now keep double state, cpuhw->txn_flags and cpuhw->group_flag | are basically the same thing. | | Would not something like the below avoid this duplication? Yes, it

Re: [PATCH v5 1/8] perf: Add a flags parameter to pmu txn interfaces

On Thu, Aug 13, 2015 at 11:49:34PM -0700, Sukadev Bhattiprolu wrote: I'm ever so sorry I keep going on about this, but.. > diff --git a/arch/powerpc/perf/core-book3s.c b/arch/powerpc/perf/core-book3s.c > index d90893b..b18efe4 100644 > --- a/arch/powerpc/perf/core-book3s.c > +++

Re: [PATCH v5 1/8] perf: Add a flags parameter to pmu txn interfaces

Peter Zijlstra [pet...@infradead.org] wrote: | | when looking at this (I almost pressed A for apply) it occurred to me | that we now keep double state, cpuhw->txn_flags and cpuhw->group_flag | are basically the same thing. | | Would not something like the below avoid this duplication? Yes, it

Re: [PATCH v5 1/8] perf: Add a flags parameter to pmu txn interfaces

On Thu, Aug 13, 2015 at 11:49:34PM -0700, Sukadev Bhattiprolu wrote: I'm ever so sorry I keep going on about this, but.. > diff --git a/arch/powerpc/perf/core-book3s.c b/arch/powerpc/perf/core-book3s.c > index d90893b..b18efe4 100644 > --- a/arch/powerpc/perf/core-book3s.c > +++

[PATCH v5 1/8] perf: Add a flags parameter to pmu txn interfaces

Currently, the PMU interface allows reading only one counter at a time. But some PMUs like the 24x7 counters in Power, support reading several counters at once. To leveage this functionality, extend the transaction interface to support a "transaction type". The first type, PERF_PMU_TXN_ADD,

[PATCH v5 1/8] perf: Add a flags parameter to pmu txn interfaces

Currently, the PMU interface allows reading only one counter at a time. But some PMUs like the 24x7 counters in Power, support reading several counters at once. To leveage this functionality, extend the transaction interface to support a transaction type. The first type, PERF_PMU_TXN_ADD, refers