Re: [PATCH v5 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-12 Thread Thierry Reding
On Tue, Jul 12, 2016 at 12:34:02PM +0200, Daniel Vetter wrote: > On Mon, Jul 11, 2016 at 02:29:37PM +0200, Thierry Reding wrote: > > On Thu, Jun 16, 2016 at 06:02:53PM +0100, Emil Velikov wrote: > > > On 16 June 2016 at 04:00, Vinay Simha BN wrote: > > [...] > > > > +static

Re: [PATCH v5 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-12 Thread Thierry Reding
On Tue, Jul 12, 2016 at 12:34:02PM +0200, Daniel Vetter wrote: > On Mon, Jul 11, 2016 at 02:29:37PM +0200, Thierry Reding wrote: > > On Thu, Jun 16, 2016 at 06:02:53PM +0100, Emil Velikov wrote: > > > On 16 June 2016 at 04:00, Vinay Simha BN wrote: > > [...] > > > > +static int

Re: [PATCH v5 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-12 Thread Daniel Vetter
On Mon, Jul 11, 2016 at 02:29:37PM +0200, Thierry Reding wrote: > On Thu, Jun 16, 2016 at 06:02:53PM +0100, Emil Velikov wrote: > > On 16 June 2016 at 04:00, Vinay Simha BN wrote: > [...] > > > +static int jdi_panel_disable(struct drm_panel *panel) > > > +{ > > > +

Re: [PATCH v5 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-12 Thread Daniel Vetter
On Mon, Jul 11, 2016 at 02:29:37PM +0200, Thierry Reding wrote: > On Thu, Jun 16, 2016 at 06:02:53PM +0100, Emil Velikov wrote: > > On 16 June 2016 at 04:00, Vinay Simha BN wrote: > [...] > > > +static int jdi_panel_disable(struct drm_panel *panel) > > > +{ > > > + struct jdi_panel *jdi =

Re: [PATCH v5 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-11 Thread Thierry Reding
On Thu, Jun 16, 2016 at 06:02:53PM +0100, Emil Velikov wrote: > On 16 June 2016 at 04:00, Vinay Simha BN wrote: [...] > > +static int jdi_panel_disable(struct drm_panel *panel) > > +{ > > + struct jdi_panel *jdi = to_jdi_panel(panel); > > + > > + if (!jdi->enabled)

Re: [PATCH v5 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-11 Thread Thierry Reding
On Thu, Jun 16, 2016 at 06:02:53PM +0100, Emil Velikov wrote: > On 16 June 2016 at 04:00, Vinay Simha BN wrote: [...] > > +static int jdi_panel_disable(struct drm_panel *panel) > > +{ > > + struct jdi_panel *jdi = to_jdi_panel(panel); > > + > > + if (!jdi->enabled) > > +

Re: [PATCH v5 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-06-16 Thread Emil Velikov
Hi Vinay, I belive I've spotted a few issues. If my understanding is correct, then I'll defer to Thierry if he'd like them fixed here, or as follow-ups. On 16 June 2016 at 04:00, Vinay Simha BN wrote: > +#define PANEL_NUM_REGULATORS 3 > + Nit: #define

Re: [PATCH v5 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-06-16 Thread Emil Velikov
Hi Vinay, I belive I've spotted a few issues. If my understanding is correct, then I'll defer to Thierry if he'd like them fixed here, or as follow-ups. On 16 June 2016 at 04:00, Vinay Simha BN wrote: > +#define PANEL_NUM_REGULATORS 3 > + Nit: #define PANEL_NUM_REGULATORS

[PATCH v5 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-06-15 Thread Vinay Simha BN
Add support for the JDI LT070ME05000 WUXGA DSI panel used in Nexus 7 2013 devices. Programming sequence for the panel is was originally found in the android-msm-flo-3.4-lollipop-release branch from: https://android.googlesource.com/kernel/msm.git And video mode setting is from

[PATCH v5 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-06-15 Thread Vinay Simha BN
Add support for the JDI LT070ME05000 WUXGA DSI panel used in Nexus 7 2013 devices. Programming sequence for the panel is was originally found in the android-msm-flo-3.4-lollipop-release branch from: https://android.googlesource.com/kernel/msm.git And video mode setting is from