Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-06 Thread Chanwoo Choi
Hi Andi, 2017-01-06 22:43 GMT+09:00 Andi Shyti : > Currently tm2e dts includes tm2 but there are some differences > between the two boards and tm2 has some properties that tm2e > doesn't have. > > That's why it's important to keep the two dts files independent > and put

Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-06 Thread Chanwoo Choi
Hi Andi, 2017-01-06 22:43 GMT+09:00 Andi Shyti : > Currently tm2e dts includes tm2 but there are some differences > between the two boards and tm2 has some properties that tm2e > doesn't have. > > That's why it's important to keep the two dts files independent > and put all the commonalities in a

Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-06 Thread Javier Martinez Canillas
Hello Krzysztof, On 01/06/2017 10:49 AM, Krzysztof Kozlowski wrote: > On Fri, Jan 06, 2017 at 10:43:47PM +0900, Andi Shyti wrote: >> Currently tm2e dts includes tm2 but there are some differences >> between the two boards and tm2 has some properties that tm2e >> doesn't have. >> >> That's why

Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-06 Thread Javier Martinez Canillas
Hello Krzysztof, On 01/06/2017 10:49 AM, Krzysztof Kozlowski wrote: > On Fri, Jan 06, 2017 at 10:43:47PM +0900, Andi Shyti wrote: >> Currently tm2e dts includes tm2 but there are some differences >> between the two boards and tm2 has some properties that tm2e >> doesn't have. >> >> That's why

Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-06 Thread Krzysztof Kozlowski
On Fri, Jan 6, 2017 at 3:53 PM, Andi Shyti wrote: > Hi Krzysztof, > >> > -#include "exynos5433-tm2.dts" >> > +#include "exynos5433-tm2-common.dtsi" >> > >> > / { >> > model = "Samsung TM2E board"; >> >> Where are the regulators? > > No need, they were already

Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-06 Thread Krzysztof Kozlowski
On Fri, Jan 6, 2017 at 3:53 PM, Andi Shyti wrote: > Hi Krzysztof, > >> > -#include "exynos5433-tm2.dts" >> > +#include "exynos5433-tm2-common.dtsi" >> > >> > / { >> > model = "Samsung TM2E board"; >> >> Where are the regulators? > > No need, they were already overwriting the original

Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-06 Thread Andi Shyti
Hi Krzysztof, > > -#include "exynos5433-tm2.dts" > > +#include "exynos5433-tm2-common.dtsi" > > > > / { > > model = "Samsung TM2E board"; > > Where are the regulators? No need, they were already overwriting the original property, so with your suggestion they didn't change in tm2e. That's

Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-06 Thread Andi Shyti
Hi Krzysztof, > > -#include "exynos5433-tm2.dts" > > +#include "exynos5433-tm2-common.dtsi" > > > > / { > > model = "Samsung TM2E board"; > > Where are the regulators? No need, they were already overwriting the original property, so with your suggestion they didn't change in tm2e. That's

Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-06 Thread Krzysztof Kozlowski
On Fri, Jan 06, 2017 at 10:43:47PM +0900, Andi Shyti wrote: > Currently tm2e dts includes tm2 but there are some differences > between the two boards and tm2 has some properties that tm2e > doesn't have. > > That's why it's important to keep the two dts files independent > and put all the

Re: [PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-06 Thread Krzysztof Kozlowski
On Fri, Jan 06, 2017 at 10:43:47PM +0900, Andi Shyti wrote: > Currently tm2e dts includes tm2 but there are some differences > between the two boards and tm2 has some properties that tm2e > doesn't have. > > That's why it's important to keep the two dts files independent > and put all the

[PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-06 Thread Andi Shyti
Currently tm2e dts includes tm2 but there are some differences between the two boards and tm2 has some properties that tm2e doesn't have. That's why it's important to keep the two dts files independent and put all the commonalities in a tm2-common.dtsi file. At the current status the only two

[PATCH v5 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other

2017-01-06 Thread Andi Shyti
Currently tm2e dts includes tm2 but there are some differences between the two boards and tm2 has some properties that tm2e doesn't have. That's why it's important to keep the two dts files independent and put all the commonalities in a tm2-common.dtsi file. At the current status the only two